Uploaded image for project: 'Infrastructure'
  1. Infrastructure
  2. INFRA-2641

Branch and PRs have different incoming check hooks

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Case:

      I want to enable status checks for Pull Requests for the master branch.

      Problem:

      • When a Pull Request is opened from a branch directly from the repository, the check that is pushed to the PR result is named:  continuous-integration/jenkins/branch - see here
      • When a Pull Request is opened from a branch from a fork, the check that is pushed to the PR result is named:  continuous-integration/jenkins/pr-merge - see here

       It should always return the same hook name in both cases similarly to travis-ci, coveralls and others.
       

        Attachments

          Activity

          Hide
          timja Tim Jacomb added a comment -

          Discover pull requests from origin was missing, added now

          Show
          timja Tim Jacomb added a comment - Discover pull requests from origin was missing, added now
          Hide
          timja Tim Jacomb added a comment -

          It's very slow to test changes due to API limits, we should move ci.jenkins.io to GitHub apps rather than a bot user

          Show
          timja Tim Jacomb added a comment - It's very slow to test changes due to API limits, we should move ci.jenkins.io to GitHub apps rather than a bot user
          Hide
          warden Radek Antoniuk added a comment -

          Still no change for me:
          https://github.com/jenkinsci/jira-plugin/pull/254
          https://github.com/jenkinsci/jira-plugin/pull/253

          I even renamed the branches to be sure (cause I don't know how often ci cleans stale branches) - https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fjira-plugin/branches
          Also note that another difference - fork PR runs two hooks (incrementals+pr) while branch only runs PR.

          This is also related with INFRA-1393 since close/re-open of PR doesn't re-trigger ci builds so I had to do everything from scratch.

          Show
          warden Radek Antoniuk added a comment - Still no change for me: https://github.com/jenkinsci/jira-plugin/pull/254 https://github.com/jenkinsci/jira-plugin/pull/253 I even renamed the branches to be sure (cause I don't know how often ci cleans stale branches) - https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fjira-plugin/branches Also note that another difference - fork PR runs two hooks (incrementals+pr) while branch only runs PR. This is also related with INFRA-1393 since close/re-open of PR doesn't re-trigger ci builds so I had to do everything from scratch.
          Hide
          timja Tim Jacomb added a comment -

          This worked for me https://github.com/jenkinsci/slack-plugin/pull/702

          and seems like your PRs as well.

          As I said before it's very slow to apply changes because of API limits, the org scan is very slow (i.e. seems to take hours)

          Show
          timja Tim Jacomb added a comment - This worked for me https://github.com/jenkinsci/slack-plugin/pull/702 and seems like your PRs as well. As I said before it's very slow to apply changes because of API limits, the org scan is very slow (i.e. seems to take hours)
          Hide
          warden Radek Antoniuk added a comment -

          Oh, I thought slow is like 15 minutes, not hours..
          Yup, I can see now continuous-integration/jenkins/pr-merge on both PRs, so I guess it works, thanks!

          Show
          warden Radek Antoniuk added a comment - Oh, I thought slow is like 15 minutes, not hours.. Yup, I can see now continuous-integration/jenkins/pr-merge on both PRs, so I guess it works, thanks!

            People

            Assignee:
            timja Tim Jacomb
            Reporter:
            warden Radek Antoniuk
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: