Uploaded image for project: 'Infrastructure'
  1. Infrastructure
  2. INFRA-957

Core changelog Community Ratings: Do not accept negative votes without issue links

    XMLWordPrintable

    Details

    • Type: New Feature
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: www
    • Labels:
      None
    • Similar Issues:

      Description

      Just because they do not help at all.

      Or maybe we should put a much more visible warning that the issue is required

        Attachments

          Activity

          Hide
          orrc Christopher Orr added a comment -

          I think that if an issue number is mandatory to leave a negative comment, we'll suddenly start seeing a lot of sunny releases

          A more visible notice would be preferable, IMO.

          Show
          orrc Christopher Orr added a comment - I think that if an issue number is mandatory to leave a negative comment, we'll suddenly start seeing a lot of sunny releases A more visible notice would be preferable, IMO.
          Hide
          danielbeck Daniel Beck added a comment -

          I think that if an issue number is mandatory to leave a negative comment, we'll suddenly start seeing a lot of sunny releases

          That's also my fear.

          Of course, rain clouds not telling us what's wrong don't help either, e.g. I don't know why 2.26 looks so bad.

          Show
          danielbeck Daniel Beck added a comment - I think that if an issue number is mandatory to leave a negative comment, we'll suddenly start seeing a lot of sunny releases That's also my fear. Of course, rain clouds not telling us what's wrong don't help either, e.g. I don't know why 2.26 looks so bad.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: R. Tyler Croy
          Path:
          src/rate.js
          http://jenkins-ci.org/commit/rating/8a3eb30ba4c102daa5c6b1d818c3350c546f785f
          Log:
          Merge pull request #9 from daniel-beck/confirm-no-issue

          INFRA-957 Ask again if user specifies no issue reference when cloudy

          Compare: https://github.com/jenkins-infra/rating/compare/d25436ca6dd9...8a3eb30ba4c1

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: R. Tyler Croy Path: src/rate.js http://jenkins-ci.org/commit/rating/8a3eb30ba4c102daa5c6b1d818c3350c546f785f Log: Merge pull request #9 from daniel-beck/confirm-no-issue INFRA-957 Ask again if user specifies no issue reference when cloudy Compare: https://github.com/jenkins-infra/rating/compare/d25436ca6dd9...8a3eb30ba4c1
          Hide
          danielbeck Daniel Beck added a comment -

          Oleg Nenashev Good enough for you?

          Show
          danielbeck Daniel Beck added a comment - Oleg Nenashev Good enough for you?
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: R. Tyler Croy
          Path:
          hieradata/common.yaml
          http://jenkins-ci.org/commit/jenkins-infra/0630cf71ce240a87371d9a26f0f62b74150dee4e
          Log:
          Deploy the latest rating app container

          Fixes INFRA-957

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: R. Tyler Croy Path: hieradata/common.yaml http://jenkins-ci.org/commit/jenkins-infra/0630cf71ce240a87371d9a26f0f62b74150dee4e Log: Deploy the latest rating app container Fixes INFRA-957
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          LGTM

          Show
          oleg_nenashev Oleg Nenashev added a comment - LGTM

            People

            Assignee:
            rtyler R. Tyler Croy
            Reporter:
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: