Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-10410

Test URLs need to be escaped

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Duplicate
    • Icon: Major Major
    • junit-plugin
    • None

      1. is a character that needs to be escaped in URLs. Similar to JENINS-1768 and JENKINS-2788 we get broken links to test results (both normal links and the inline ajax links) where the part after the # is treated by the browser as the target causing the links to be 404.

      If we fix the URL by replacing the # with the url escaped %23 it works correctly.

      This is a problem to us because it's best practice to use # in test names in Ruby as described in this tutorial: http://eggsonbread.com/2010/03/28/my-rspec-best-practices-and-tips/

      After some digging I found hudson.tasks.test.TestObject.safe(String s) which was modified in the previous bug that now handles "/" "\" and ":", but not #.

      Can provide more details and produce test cases as needed.

      Thanks,
      Morgan

          [JENKINS-10410] Test URLs need to be escaped

          Morgan Christiansson created issue -
          Morgan Christiansson made changes -
          Description Original: # is a character that needs to be escaped in URLs. Similar to JENINS-1768 and JENKINS-2788 we get broken links to test results (both normal links and the inline ajax links) where the part after the # is treated by the browser as the target causing the links to be 404.

          If we fix the URL by replacing the # with the url escaped %23 it works correctly.


          This is a problem to us because it's best practice to use # in test names in Ruby as described in this tutorial: http://eggsonbread.com/2010/03/28/my-rspec-best-practices-and-tips/

          After some digging I found hudson.tasks.test.TestObject.safe(String s) which was modified in the previous bug that now handles "/" "\\" and ":", but not #.


          Can provide more details and produce test cases as needed.

          Thanks,
          Morgan           		New: # is a character that needs to be escaped in URLs. Similar to JENINS-1768 and JENKINS-2788 we get broken links to test results (both normal links and the inline ajax links) where the part after the # is treated by the browser as the target causing the links to be 404.

          If we fix the URL by replacing the # with the url escaped %23 it works correctly.


          This is a problem to us because it's best practice to use # in test names in Ruby as described in this tutorial: http://eggsonbread.com/2010/03/28/my-rspec-best-practices-and-tips/

          After some digging I found hudson.tasks.test.TestObject.safe(String s) which was modified in the previous bug that now handles "/" "\" and ":", but not #.


          Can provide more details and produce test cases as needed.

          Thanks,
          Morgan
          Morgan Christiansson made changes -
          Link New: This issue duplicates JENKINS-10458 [ JENKINS-10458 ]
          kutzi made changes -
          Resolution New: Duplicate [ 3 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 140602 ] New: JNJira + In-Review [ 189147 ]

            Unassigned Unassigned
            mog Morgan Christiansson
            Votes:
            2 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved: