Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-10460

Loading a view with an iframe in the description causes the "Import" button to not render to the DOM after query

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      I have a job with an iframe in its description, and the src was relative so it was bad when viewed on the import page. Somehow, the iframe caused the "Import" button to not render to the DOM at all. Removing the iframe allowed the jobs to import normally.

      I was doing a mass "VIEW" import, if that's relevant.

        Attachments

          Activity

          stefankendall Stefan Kendall created issue -
          Hide
          jieryn jieryn added a comment -

          It isn't important, but thank you. I am not sure how to handle this. I guess we'll have to scrub the html ..... know of a scrubbing library? Or something in Jenkins natively?

          Show
          jieryn jieryn added a comment - It isn't important, but thank you. I am not sure how to handle this. I guess we'll have to scrub the html ..... know of a scrubbing library? Or something in Jenkins natively?
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Farinacci
          Path:
          pom.xml
          src/main/java/org/jenkins/ci/plugins/jobimport/RemoteJob.java
          http://jenkins-ci.org/commit/job-import-plugin/ec1711f1bd0ab146225bca3057a17ae7a4154828
          Log:
          [FIXED JENKINS-10460] do not let raw html be imported from remote job description

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Farinacci Path: pom.xml src/main/java/org/jenkins/ci/plugins/jobimport/RemoteJob.java http://jenkins-ci.org/commit/job-import-plugin/ec1711f1bd0ab146225bca3057a17ae7a4154828 Log: [FIXED JENKINS-10460] do not let raw html be imported from remote job description
          scm_issue_link SCM/JIRA link daemon made changes -
          Field Original Value New Value
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]
          Hide
          jieryn jieryn added a comment -

          Found a convenient way to do it in a dependency already included in the plugin. New release coming soonish.

          Show
          jieryn jieryn added a comment - Found a convenient way to do it in a dependency already included in the plugin. New release coming soonish.
          Hide
          dogfood dogfood added a comment -

          Integrated in plugins_job-import #6
          [FIXED JENKINS-10460] do not let raw html be imported from remote job description

          Jesse Farinacci :
          Files :

          • src/main/java/org/jenkins/ci/plugins/jobimport/RemoteJob.java
          • pom.xml
          Show
          dogfood dogfood added a comment - Integrated in plugins_job-import #6 [FIXED JENKINS-10460] do not let raw html be imported from remote job description Jesse Farinacci : Files : src/main/java/org/jenkins/ci/plugins/jobimport/RemoteJob.java pom.xml
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 140653 ] JNJira + In-Review [ 189174 ]

            People

            Assignee:
            jieryn jieryn
            Reporter:
            stefankendall Stefan Kendall
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: