Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-10472

clodubees-deploy-plugin's MavenArtifactFilePathSaver does not check if the Publisher is enabled

    XMLWordPrintable

Details

    Description

      org.jenkins.plugins.cloudbees.MavenArtifactFilePathSaver can break Maven builds even when the cloudbees-deployer plugin is not enabled for a certain build. For instance, I'm getting the following exception for a build:

      https://gist.github.com/1109680

      I think the solution is for this reporter to verify that the parent MavenModuleSet has the CloudbeesPublisher enabled.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          recampbell Ryan Campbell added a comment -

          I think there are two issues here. One is the fact that it doesn't regard whether the Publisher is enabled. The other is that it doesn't seem to handle site artifacts? Perhaps this is what the "TODO take of NPE !!" is for?

          recampbell Ryan Campbell added a comment - I think there are two issues here. One is the fact that it doesn't regard whether the Publisher is enabled. The other is that it doesn't seem to handle site artifacts? Perhaps this is what the "TODO take of NPE !!" is for?
          olamy Olivier Lamy added a comment -

          yup TODO always need to be done one day

          olamy Olivier Lamy added a comment - yup TODO always need to be done one day
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Olivier Lamy
          Path:
          src/main/java/org/jenkins/plugins/cloudbees/MavenArtifactFilePathSaver.java
          http://jenkins-ci.org/commit/cloudbees-deployer-plugin/1cf091c229736ef40f88a84f43dea45797dc53cf
          Log:
          [FIXED JENKINS-10472] take care of builds which don't produce artifacts

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Olivier Lamy Path: src/main/java/org/jenkins/plugins/cloudbees/MavenArtifactFilePathSaver.java http://jenkins-ci.org/commit/cloudbees-deployer-plugin/1cf091c229736ef40f88a84f43dea45797dc53cf Log: [FIXED JENKINS-10472] take care of builds which don't produce artifacts
          olamy Olivier Lamy added a comment -

          so I have added more null check as a quick fix

          olamy Olivier Lamy added a comment - so I have added more null check as a quick fix
          recampbell Ryan Campbell added a comment -

          The main problem (not just the NPE) is that this MavenArtifactFilePathSaver is acting on builds which don't have the cloudbees-deployer activated. It needs to be more discriminating.

          recampbell Ryan Campbell added a comment - The main problem (not just the NPE) is that this MavenArtifactFilePathSaver is acting on builds which don't have the cloudbees-deployer activated. It needs to be more discriminating.
          dogfood dogfood added a comment -

          Integrated in plugins_cloudbees-deployer-plugin #22
          [FIXED JENKINS-10472] take care of builds which don't produce artifacts

          Olivier Lamy :
          Files :

          • src/main/java/org/jenkins/plugins/cloudbees/MavenArtifactFilePathSaver.java
          dogfood dogfood added a comment - Integrated in plugins_cloudbees-deployer-plugin #22 [FIXED JENKINS-10472] take care of builds which don't produce artifacts Olivier Lamy : Files : src/main/java/org/jenkins/plugins/cloudbees/MavenArtifactFilePathSaver.java
          olamy Olivier Lamy added a comment -

          reopen as not really fixed

          olamy Olivier Lamy added a comment - reopen as not really fixed
          pascalleclercq pascalleclercq added a comment -

          Hi Olivier,
          as you suggest I complete here.
          https://github.com/olamy/cloudbees-deployer-plugin/issues/2

          I'm sorry to say I miss time for a correct answer but may issue is probably related.

          I will be off for 2 weeks stating today.

          Please let me know how I can test, I can only reproduce the problem on cloudbees and I can't upgrade the plugin.

          Thx again

          pascalleclercq pascalleclercq added a comment - Hi Olivier, as you suggest I complete here. https://github.com/olamy/cloudbees-deployer-plugin/issues/2 I'm sorry to say I miss time for a correct answer but may issue is probably related. I will be off for 2 weeks stating today. Please let me know how I can test, I can only reproduce the problem on cloudbees and I can't upgrade the plugin. Thx again
          pascalleclercq pascalleclercq added a comment -

          Just tested here :

          https://opensagres.ci.cloudbees.com/job/xdocreport/

          It works like a charm now.

          Thx !

          pascalleclercq pascalleclercq added a comment - Just tested here : https://opensagres.ci.cloudbees.com/job/xdocreport/ It works like a charm now. Thx !
          olamy Olivier Lamy added a comment -

          not used anymore

          olamy Olivier Lamy added a comment - not used anymore

          People

            olamy Olivier Lamy
            recampbell Ryan Campbell
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: