Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-10629

Tar implimentation can't handle > 8GB and doesn't error out.

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      During archiving from a slave the untaring can fail with files > 8GB. This is because the tar creator makes a corrupt archive. I think it doesn't properly null terminate the size value when the file size is gets to the 12th digit - which is a violation of tar spec (from Wikipedia tar article: Numeric values are encoded in octal numbers using ASCII digits, with leading zeroes. For historical reasons, a final NUL or space character should be used. Thus although there are 12 bytes reserved for storing the file size, only 11 octal digits can be stored. This gives a maximum file size of 8 gigabytes on archived files.)
      Changing to gnutar might be nice to handle large files, or at least making the library error out when it hits large files rather than happily building corrupt archives.

      Error caused by this bug (due to reading the corrupt header):

      Archiving artifacts
      ERROR: Publisher hudson.tasks.ArtifactArchiver aborted due to exception
      java.lang.IllegalArgumentException: Negative time
      at java.io.File.setLastModified(File.java:1258)
      at hudson.FilePath.readFromTar(FilePath.java:1605)
      at hudson.FilePath.copyRecursiveTo(FilePath.java:1530)
      at hudson.tasks.ArtifactArchiver.perform(ArtifactArchiver.java:117)
      at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:19)
      at hudson.model.AbstractBuild$AbstractRunner.perform(AbstractBuild.java:649)
      at hudson.model.AbstractBuild$AbstractRunner.performAllBuildSteps(AbstractBuild.java:625)
      at hudson.model.AbstractBuild$AbstractRunner.performAllBuildSteps(AbstractBuild.java:603)
      at hudson.model.Build$RunnerImpl.post2(Build.java:161)
      at hudson.model.AbstractBuild$AbstractRunner.post(AbstractBuild.java:572)
      at hudson.model.Run.run(Run.java:1386)
      at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46)
      at hudson.model.ResourceController.execute(ResourceController.java:88)
      at hudson.model.Executor.run(Executor.java:145)
      Finished: FAILURE

        Attachments

          Issue Links

            Activity

            Hide
            mindless Alan Harder added a comment -

            tar functionality is in core, not within copyartifact plugin.. reassigning component.

            Show
            mindless Alan Harder added a comment - tar functionality is in core, not within copyartifact plugin.. reassigning component.
            Hide
            hiteswar_kumar hiteswar kumar added a comment -

            any solution and workaorund for this issue.
            still we are facing this issue while copying workspace of another project by "Copy artifacts from another project"

            Show
            hiteswar_kumar hiteswar kumar added a comment - any solution and workaorund for this issue. still we are facing this issue while copying workspace of another project by "Copy artifacts from another project"
            Hide
            dfitzger don fitzgerald added a comment -

            I am experiencing this problem as well. How does jenkins invoke tar on a windows slave?

            Show
            dfitzger don fitzgerald added a comment - I am experiencing this problem as well. How does jenkins invoke tar on a windows slave?
            Hide
            danielbeck Daniel Beck added a comment -

            Jenkins uses a patched variant of Ant's org.apache.tools.tar.TarInputStream imported from Ant 1.7.0:
            https://github.com/jenkinsci/jenkins/tree/master/core/src/main/java/hudson/org/apache/tools/tar

            Maybe it's time to update this a bit, there've been a few changes since – cannot tell whether relevant to this issue yet though:
            http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/tar/TarInputStream.java?view=log

            Show
            danielbeck Daniel Beck added a comment - Jenkins uses a patched variant of Ant's org.apache.tools.tar.TarInputStream imported from Ant 1.7.0: https://github.com/jenkinsci/jenkins/tree/master/core/src/main/java/hudson/org/apache/tools/tar Maybe it's time to update this a bit, there've been a few changes since – cannot tell whether relevant to this issue yet though: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/tar/TarInputStream.java?view=log
            Hide
            kayama Akihiro KAYAMA added a comment -

            This is critical for my project. Is there any workaround?

            Show
            kayama Akihiro KAYAMA added a comment - This is critical for my project. Is there any workaround?
            Hide
            danielbeck Daniel Beck added a comment -

            Akihiro KAYAMA: Create smaller files (e.g. splitting them up for archiving every 7GB, or packaging them using a tool that can split archives.

            Show
            danielbeck Daniel Beck added a comment - Akihiro KAYAMA : Create smaller files (e.g. splitting them up for archiving every 7GB, or packaging them using a tool that can split archives.
            Hide
            kayama Akihiro KAYAMA added a comment -

            Thanks for your comment. I have a single large proprietary package file as artifact. Splitting it is inconvenience but I understand there is no other way.

            Show
            kayama Akihiro KAYAMA added a comment - Thanks for your comment. I have a single large proprietary package file as artifact. Splitting it is inconvenience but I understand there is no other way.
            Hide
            danielbeck Daniel Beck added a comment -

            Also, building on the master node should not invoke the tar implementation.

            Show
            danielbeck Daniel Beck added a comment - Also, building on the master node should not invoke the tar implementation.
            Hide
            olenz Olaf Lenz added a comment -

            I have started to work on this issue.

            Show
            olenz Olaf Lenz added a comment - I have started to work on this issue.
            Hide
            recampbell Ryan Campbell added a comment -

            Any progress, Olaf?

            Show
            recampbell Ryan Campbell added a comment - Any progress, Olaf?
            Hide
            olivergondza Oliver Gondža added a comment -

            TARs are used internally to transfer directories. I wonder if we can safely switch to use zip64 (FilePath#zip produce that) to fix #copyRecursiveTo and friends. Whoever needs tar explicitly should deal with the limitations we will document.

            Show
            olivergondza Oliver Gondža added a comment - TARs are used internally to transfer directories. I wonder if we can safely switch to use zip64 ( FilePath#zip produce that) to fix #copyRecursiveTo and friends. Whoever needs tar explicitly should deal with the limitations we will document.
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            I'm working on the implementation for TARs

            Show
            oleg_nenashev Oleg Nenashev added a comment - I'm working on the implementation for TARs
            Show
            oleg_nenashev Oleg Nenashev added a comment - https://github.com/jenkinsci/jenkins/pull/1647
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            core/src/test/java/hudson/FilePathTest.java
            http://jenkins-ci.org/commit/jenkins/32dca8819c003ee6d815d1c9858dccb19f64b71d
            Log:
            JENKINS-10629 - Direct unit test for the issue

            This test also introduces additional round-trip tests for small files

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/test/java/hudson/FilePathTest.java http://jenkins-ci.org/commit/jenkins/32dca8819c003ee6d815d1c9858dccb19f64b71d Log: JENKINS-10629 - Direct unit test for the issue This test also introduces additional round-trip tests for small files
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            core/pom.xml
            core/src/main/java/hudson/FilePath.java
            core/src/main/java/hudson/org/apache/tools/tar/TarInputStream.java
            core/src/main/java/hudson/org/apache/tools/tar/TarOutputStream.java
            core/src/main/java/hudson/util/io/TarArchiver.java
            http://jenkins-ci.org/commit/jenkins/b6c7b83e7ba1a7538382d220d044626f2b2e65be
            Log:
            JENKINS-10629 - Migrate the Tar archives handling code to commons-compress

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/pom.xml core/src/main/java/hudson/FilePath.java core/src/main/java/hudson/org/apache/tools/tar/TarInputStream.java core/src/main/java/hudson/org/apache/tools/tar/TarOutputStream.java core/src/main/java/hudson/util/io/TarArchiver.java http://jenkins-ci.org/commit/jenkins/b6c7b83e7ba1a7538382d220d044626f2b2e65be Log: JENKINS-10629 - Migrate the Tar archives handling code to commons-compress
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            core/src/main/java/hudson/util/io/TarArchiver.java
            http://jenkins-ci.org/commit/jenkins/4ddeeb84195fa29c964ef2e55661b669c310baeb
            Log:
            FIXED JENKINS-10629] - Enable BigNumber mode to support archiving of files with size >8Gb

            BIGNUMBER_STAR mode has been selected, because it utilizes GNU extensions (like LONGFILE_GNU does).

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/util/io/TarArchiver.java http://jenkins-ci.org/commit/jenkins/4ddeeb84195fa29c964ef2e55661b669c310baeb Log: FIXED JENKINS-10629 ] - Enable BigNumber mode to support archiving of files with size >8Gb BIGNUMBER_STAR mode has been selected, because it utilizes GNU extensions (like LONGFILE_GNU does).
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Marked the issue as LTS candidate

            Show
            oleg_nenashev Oleg Nenashev added a comment - Marked the issue as LTS candidate
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #4082

            Result = SUCCESS

            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4082 Result = SUCCESS
            Hide
            olenz Olaf Lenz added a comment -

            Well done! I had started to work on it, by I had only gotten as far as writing a regression test that shows the problem. If that test is of any interest, I can provide it. Unfortunately, the test is relatively costly (time and memory). Daniel Beck suggested to put the test into the acceptance test harness, however the test is currently written as a "normal" unit test, and to my understanding, converting it to a test useful for the acceptance test harness does not work as easily. Anyway, if you are interested, have a look here:
            https://github.com/olenz/jenkins/commit/4ec5b7f30a843383739f80ddf12072f93865741a

            Show
            olenz Olaf Lenz added a comment - Well done! I had started to work on it, by I had only gotten as far as writing a regression test that shows the problem. If that test is of any interest, I can provide it. Unfortunately, the test is relatively costly (time and memory). Daniel Beck suggested to put the test into the acceptance test harness, however the test is currently written as a "normal" unit test, and to my understanding, converting it to a test useful for the acceptance test harness does not work as easily. Anyway, if you are interested, have a look here: https://github.com/olenz/jenkins/commit/4ec5b7f30a843383739f80ddf12072f93865741a
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            @Olaf
            I've also created a unit test for the issue. BTW, any additional tests (especially use-case-reproductory builds with large artefacts archiving) will be appreciated. It would be great if you finalize your test and submit a pull request to jenkins or to https://github.com/jenkinsci/acceptance-test-harness

            Show
            oleg_nenashev Oleg Nenashev added a comment - @Olaf I've also created a unit test for the issue. BTW, any additional tests (especially use-case-reproductory builds with large artefacts archiving) will be appreciated. It would be great if you finalize your test and submit a pull request to jenkins or to https://github.com/jenkinsci/acceptance-test-harness
            Hide
            olenz Olaf Lenz added a comment -

            The trouble with the acceptance test harness is, that it would mean I first have to create a >8GB file in a job, then archive it, and finally download it to compare it. In sum, the test would require more than 24GB of disk space, even if it could be deleted afterwards. At the moment, the system were I develop Jenkins doesn't have that much free space... ;-(

            Show
            olenz Olaf Lenz added a comment - The trouble with the acceptance test harness is, that it would mean I first have to create a >8GB file in a job, then archive it, and finally download it to compare it. In sum, the test would require more than 24GB of disk space, even if it could be deleted afterwards. At the moment, the system were I develop Jenkins doesn't have that much free space... ;-(
            Hide
            integer Kanstantsin Shautsou added a comment -

            Do you know fallocate?

            Show
            integer Kanstantsin Shautsou added a comment - Do you know fallocate?
            Hide
            olenz Olaf Lenz added a comment -

            How portable is fallocate? Also, this helps to make the creation of the file fast, but it does not reduce the disk space requirements, does it?

            Show
            olenz Olaf Lenz added a comment - How portable is fallocate ? Also, this helps to make the creation of the file fast, but it does not reduce the disk space requirements, does it?
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            fallocate is not portable at all (it's missing on default Mac/Windows installations)

            @Olaf
            You could develop and debug a test, which requires less space (e.g. create a configurable test method). After that, I can test it on big files.

            Show
            oleg_nenashev Oleg Nenashev added a comment - fallocate is not portable at all (it's missing on default Mac/Windows installations) @Olaf You could develop and debug a test, which requires less space (e.g. create a configurable test method). After that, I can test it on big files.
            Hide
            danielbeck Daniel Beck added a comment -

            May have caused JENKINS-28013.

            Show
            danielbeck Daniel Beck added a comment - May have caused JENKINS-28013 .
            Hide
            danielbeck Daniel Beck added a comment -

            Typo in commit seems to have prevented the bot from resolving.

            Regression in 1.610 is tracked as JENKINS-28013.

            Show
            danielbeck Daniel Beck added a comment - Typo in commit seems to have prevented the bot from resolving. Regression in 1.610 is tracked as JENKINS-28013 .
            Hide
            integer Kanstantsin Shautsou added a comment -

            lets remote lts-candidate, it causes issues.

            Show
            integer Kanstantsin Shautsou added a comment - lets remote lts-candidate, it causes issues.
            Hide
            danielbeck Daniel Beck added a comment -

            Could be backported together with the future fix to JENKINS-28013 once both are soaked enough.

            Show
            danielbeck Daniel Beck added a comment - Could be backported together with the future fix to JENKINS-28013 once both are soaked enough.
            Hide
            integer Kanstantsin Shautsou added a comment -

            I see no fixes, so my suggestion to add lts label when issue will be resolved to exclude potential lts breakage. Or add some additional tag like "not-ready"

            Show
            integer Kanstantsin Shautsou added a comment - I see no fixes, so my suggestion to add lts label when issue will be resolved to exclude potential lts breakage. Or add some additional tag like "not-ready"
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            We may need to revert the fix if I don't find the solution till 1.611 kick-off.

            Show
            oleg_nenashev Oleg Nenashev added a comment - We may need to revert the fix if I don't find the solution till 1.611 kick-off.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            core/src/main/java/hudson/util/io/TarArchiver.java
            http://jenkins-ci.org/commit/jenkins/ee57300963ca0137565f61fe314d459b627ad74b
            Log:
            Revert "FIXED JENKINS-10629] - Enable BigNumber mode to support archiving of files with size >8Gb"

            This reverts commit 4ddeeb84195fa29c964ef2e55661b669c310baeb.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/util/io/TarArchiver.java http://jenkins-ci.org/commit/jenkins/ee57300963ca0137565f61fe314d459b627ad74b Log: Revert "FIXED JENKINS-10629 ] - Enable BigNumber mode to support archiving of files with size >8Gb" This reverts commit 4ddeeb84195fa29c964ef2e55661b669c310baeb.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            core/pom.xml
            core/src/main/java/hudson/FilePath.java
            core/src/main/java/hudson/org/apache/tools/tar/TarInputStream.java
            core/src/main/java/hudson/org/apache/tools/tar/TarOutputStream.java
            core/src/main/java/hudson/util/io/TarArchiver.java
            http://jenkins-ci.org/commit/jenkins/8f1280a85c54ea6150b15c38303464ab23b32e92
            Log:
            Revert "JENKINS-10629 - Migrate the Tar archives handling code to commons-compress"

            This reverts commit b6c7b83e7ba1a7538382d220d044626f2b2e65be.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/pom.xml core/src/main/java/hudson/FilePath.java core/src/main/java/hudson/org/apache/tools/tar/TarInputStream.java core/src/main/java/hudson/org/apache/tools/tar/TarOutputStream.java core/src/main/java/hudson/util/io/TarArchiver.java http://jenkins-ci.org/commit/jenkins/8f1280a85c54ea6150b15c38303464ab23b32e92 Log: Revert " JENKINS-10629 - Migrate the Tar archives handling code to commons-compress" This reverts commit b6c7b83e7ba1a7538382d220d044626f2b2e65be.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            core/pom.xml
            core/src/main/java/hudson/FilePath.java
            core/src/main/java/hudson/org/apache/tools/tar/TarInputStream.java
            core/src/main/java/hudson/org/apache/tools/tar/TarOutputStream.java
            core/src/main/java/hudson/util/io/TarArchiver.java
            http://jenkins-ci.org/commit/jenkins/ca21c65bf2538982126bd465eb70840071a61e4e
            Log:
            Merge pull request #1667 from oleg-nenashev/JENKINS-10629-FIX

            [JENKINS-28013,JENKINS-28012] - Revert changes for JENKINS-10629

            Compare: https://github.com/jenkinsci/jenkins/compare/8c94920973c4...ca21c65bf253

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/pom.xml core/src/main/java/hudson/FilePath.java core/src/main/java/hudson/org/apache/tools/tar/TarInputStream.java core/src/main/java/hudson/org/apache/tools/tar/TarOutputStream.java core/src/main/java/hudson/util/io/TarArchiver.java http://jenkins-ci.org/commit/jenkins/ca21c65bf2538982126bd465eb70840071a61e4e Log: Merge pull request #1667 from oleg-nenashev/ JENKINS-10629 -FIX [JENKINS-28013,JENKINS-28012] - Revert changes for JENKINS-10629 Compare: https://github.com/jenkinsci/jenkins/compare/8c94920973c4...ca21c65bf253
            Hide
            danielbeck Daniel Beck added a comment -

            Reopening this issue as the fix has been reverted due to regressions.

            Show
            danielbeck Daniel Beck added a comment - Reopening this issue as the fix has been reverted due to regressions.
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Daniel, thanks for handling JIRA issues.
            I'll continue working on the issue to achieve a better test coverage.

            Show
            oleg_nenashev Oleg Nenashev added a comment - Daniel, thanks for handling JIRA issues. I'll continue working on the issue to achieve a better test coverage.
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #4103

            Result = SUCCESS

            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4103 Result = SUCCESS
            Hide
            integer Kanstantsin Shautsou added a comment -
            Show
            integer Kanstantsin Shautsou added a comment - Those who interested in >8GB files please try this build https://jenkins.ci.cloudbees.com/job/core/job/jenkins-core/2480/artifact/war/target/jenkins.war
            Hide
            integer Kanstantsin Shautsou added a comment -

            User on IRC reported that this build fixes issue.

            Show
            integer Kanstantsin Shautsou added a comment - User on IRC reported that this build fixes issue.
            Hide
            olenz Olaf Lenz added a comment -

            What is the current state of this issue? As far as I understood, the integration into the main branch has been reverted, as it caused some problems. Does anybody work on this? What needs to be done?

            Show
            olenz Olaf Lenz added a comment - What is the current state of this issue? As far as I understood, the integration into the main branch has been reverted, as it caused some problems. Does anybody work on this? What needs to be done?
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            We need to develop more extensive tests. It's my action item, but I have not implemented them yet. ETA - July 2015th

            Show
            oleg_nenashev Oleg Nenashev added a comment - We need to develop more extensive tests. It's my action item, but I have not implemented them yet. ETA - July 2015th
            Hide
            marksyms Mark Syms added a comment -

            At the very least, the TarArchive.visit method (or actually more likely, to preserve encapsulation, the TarEntry.setSIze() method except this is in the Apache code) should validate the file.length and error out hard if the file is too big for the format.

            Show
            marksyms Mark Syms added a comment - At the very least, the TarArchive.visit method (or actually more likely, to preserve encapsulation, the TarEntry.setSIze() method except this is in the Apache code) should validate the file.length and error out hard if the file is too big for the format.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kanstantsin Shautsou
            Path:
            core/pom.xml
            core/src/main/java/hudson/FilePath.java
            core/src/main/java/hudson/org/apache/tools/tar/TarInputStream.java
            core/src/main/java/hudson/org/apache/tools/tar/TarOutputStream.java
            core/src/main/java/hudson/util/io/TarArchiver.java
            http://jenkins-ci.org/commit/jenkins/03bd5959cb94a0e626c5ace910d14c3083a9db2c
            Log:
            Revert "Revert "JENKINS-10629 - Migrate the Tar archives handling code to commons-compress""

            This reverts commit 8f1280a85c54ea6150b15c38303464ab23b32e92.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kanstantsin Shautsou Path: core/pom.xml core/src/main/java/hudson/FilePath.java core/src/main/java/hudson/org/apache/tools/tar/TarInputStream.java core/src/main/java/hudson/org/apache/tools/tar/TarOutputStream.java core/src/main/java/hudson/util/io/TarArchiver.java http://jenkins-ci.org/commit/jenkins/03bd5959cb94a0e626c5ace910d14c3083a9db2c Log: Revert "Revert " JENKINS-10629 - Migrate the Tar archives handling code to commons-compress"" This reverts commit 8f1280a85c54ea6150b15c38303464ab23b32e92.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kanstantsin Shautsou
            Path:
            core/src/main/java/hudson/util/io/TarArchiver.java
            http://jenkins-ci.org/commit/jenkins/2ef29215c2b311a9d5c2e515268285b5623ce833
            Log:
            Revert "Revert "FIXED JENKINS-10629] - Enable BigNumber mode to support archiving of files with size >8Gb""

            This reverts commit ee57300963ca0137565f61fe314d459b627ad74b.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kanstantsin Shautsou Path: core/src/main/java/hudson/util/io/TarArchiver.java http://jenkins-ci.org/commit/jenkins/2ef29215c2b311a9d5c2e515268285b5623ce833 Log: Revert "Revert "FIXED JENKINS-10629 ] - Enable BigNumber mode to support archiving of files with size >8Gb"" This reverts commit ee57300963ca0137565f61fe314d459b627ad74b.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kanstantsin Shautsou
            Path:
            core/src/main/java/hudson/util/io/TarArchiver.java
            core/src/test/java/hudson/FilePathTest.java
            http://jenkins-ci.org/commit/jenkins/3e187a026408d5ca74202f7e26dd565cde2e87d0
            Log:
            [FIXED JENKINS-10629] Unbroke stream with new tar implementation.

            Causes bytes lost and truncated tar archive.
            TarBuffer not used in TarArchiveOutputStream.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kanstantsin Shautsou Path: core/src/main/java/hudson/util/io/TarArchiver.java core/src/test/java/hudson/FilePathTest.java http://jenkins-ci.org/commit/jenkins/3e187a026408d5ca74202f7e26dd565cde2e87d0 Log: [FIXED JENKINS-10629] Unbroke stream with new tar implementation. Causes bytes lost and truncated tar archive. TarBuffer not used in TarArchiveOutputStream.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            changelog.html
            core/pom.xml
            core/src/main/java/hudson/FilePath.java
            core/src/main/java/hudson/org/apache/tools/tar/TarInputStream.java
            core/src/main/java/hudson/org/apache/tools/tar/TarOutputStream.java
            core/src/main/java/hudson/util/io/TarArchiver.java
            core/src/test/java/hudson/FilePathTest.java
            http://jenkins-ci.org/commit/jenkins/b5b377997c5f30d66d7abb73460fd66f67d3a523
            Log:
            JENKINS-10629 Merging #1670.

            Compare: https://github.com/jenkinsci/jenkins/compare/79bf40bc2d91...b5b377997c5f

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/pom.xml core/src/main/java/hudson/FilePath.java core/src/main/java/hudson/org/apache/tools/tar/TarInputStream.java core/src/main/java/hudson/org/apache/tools/tar/TarOutputStream.java core/src/main/java/hudson/util/io/TarArchiver.java core/src/test/java/hudson/FilePathTest.java http://jenkins-ci.org/commit/jenkins/b5b377997c5f30d66d7abb73460fd66f67d3a523 Log: JENKINS-10629 Merging #1670. Compare: https://github.com/jenkinsci/jenkins/compare/79bf40bc2d91...b5b377997c5f
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #4270
            Revert "Revert "JENKINS-10629 - Migrate the Tar archives handling code to commons-compress"" (Revision 03bd5959cb94a0e626c5ace910d14c3083a9db2c)
            Revert "Revert "FIXED JENKINS-10629] - Enable BigNumber mode to support archiving of files with size >8Gb"" (Revision 2ef29215c2b311a9d5c2e515268285b5623ce833)
            [FIXED JENKINS-10629] Unbroke stream with new tar implementation. (Revision 3e187a026408d5ca74202f7e26dd565cde2e87d0)

            Result = SUCCESS
            kanstantsin.sha : 03bd5959cb94a0e626c5ace910d14c3083a9db2c
            Files :

            • core/src/main/java/hudson/org/apache/tools/tar/TarOutputStream.java
            • core/src/main/java/hudson/FilePath.java
            • core/pom.xml
            • core/src/main/java/hudson/util/io/TarArchiver.java
            • core/src/main/java/hudson/org/apache/tools/tar/TarInputStream.java

            kanstantsin.sha : 2ef29215c2b311a9d5c2e515268285b5623ce833
            Files :

            • core/src/main/java/hudson/util/io/TarArchiver.java

            kanstantsin.sha : 3e187a026408d5ca74202f7e26dd565cde2e87d0
            Files :

            • core/src/test/java/hudson/FilePathTest.java
            • core/src/main/java/hudson/util/io/TarArchiver.java
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4270 Revert "Revert " JENKINS-10629 - Migrate the Tar archives handling code to commons-compress"" (Revision 03bd5959cb94a0e626c5ace910d14c3083a9db2c) Revert "Revert "FIXED JENKINS-10629 ] - Enable BigNumber mode to support archiving of files with size >8Gb"" (Revision 2ef29215c2b311a9d5c2e515268285b5623ce833) [FIXED JENKINS-10629] Unbroke stream with new tar implementation. (Revision 3e187a026408d5ca74202f7e26dd565cde2e87d0) Result = SUCCESS kanstantsin.sha : 03bd5959cb94a0e626c5ace910d14c3083a9db2c Files : core/src/main/java/hudson/org/apache/tools/tar/TarOutputStream.java core/src/main/java/hudson/FilePath.java core/pom.xml core/src/main/java/hudson/util/io/TarArchiver.java core/src/main/java/hudson/org/apache/tools/tar/TarInputStream.java kanstantsin.sha : 2ef29215c2b311a9d5c2e515268285b5623ce833 Files : core/src/main/java/hudson/util/io/TarArchiver.java kanstantsin.sha : 3e187a026408d5ca74202f7e26dd565cde2e87d0 Files : core/src/test/java/hudson/FilePathTest.java core/src/main/java/hudson/util/io/TarArchiver.java
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: tfennelly
            Path:
            changelog.html
            core/pom.xml
            core/src/main/java/hudson/FilePath.java
            core/src/main/java/hudson/PluginManager.java
            core/src/main/java/hudson/PluginManagerStaplerOverride.java
            core/src/main/java/hudson/org/apache/tools/tar/TarInputStream.java
            core/src/main/java/hudson/org/apache/tools/tar/TarOutputStream.java
            core/src/main/java/hudson/util/io/TarArchiver.java
            core/src/test/java/hudson/FilePathTest.java
            test/src/main/java/hudson/core/PluginManagerOverrideTest.java
            test/src/main/resources/hudson/core/PluginManagerOverrideTest/BasicPluginManagerOverride/newview.jelly
            http://jenkins-ci.org/commit/jenkins/3f98011bd4aae0ee6956d264c952782452389f79
            Log:
            Merge branch 'master' into upgrade-htmlunit

            • master:
              commons-compress -> 1.10
              Noting #1788
              Remove hardcode in tar test
              [FIXED JENKINS-10629] Unbroke stream with new tar implementation.
              Revert "Revert "FIXED JENKINS-10629] - Enable BigNumber mode to support archiving of files with size >8Gb""
              Revert "Revert "JENKINS-10629 - Migrate the Tar archives handling code to commons-compress""
              Fix at-since from PR #1788
              Merge PR #1788: Make plugin manager pluggable
            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: tfennelly Path: changelog.html core/pom.xml core/src/main/java/hudson/FilePath.java core/src/main/java/hudson/PluginManager.java core/src/main/java/hudson/PluginManagerStaplerOverride.java core/src/main/java/hudson/org/apache/tools/tar/TarInputStream.java core/src/main/java/hudson/org/apache/tools/tar/TarOutputStream.java core/src/main/java/hudson/util/io/TarArchiver.java core/src/test/java/hudson/FilePathTest.java test/src/main/java/hudson/core/PluginManagerOverrideTest.java test/src/main/resources/hudson/core/PluginManagerOverrideTest/BasicPluginManagerOverride/newview.jelly http://jenkins-ci.org/commit/jenkins/3f98011bd4aae0ee6956d264c952782452389f79 Log: Merge branch 'master' into upgrade-htmlunit master: commons-compress -> 1.10 Noting #1788 Remove hardcode in tar test [FIXED JENKINS-10629] Unbroke stream with new tar implementation. Revert "Revert "FIXED JENKINS-10629 ] - Enable BigNumber mode to support archiving of files with size >8Gb"" Revert "Revert " JENKINS-10629 - Migrate the Tar archives handling code to commons-compress"" Fix at-since from PR #1788 Merge PR #1788: Make plugin manager pluggable
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: tfennelly
            Path:
            changelog.html
            cli/pom.xml
            core/pom.xml
            core/src/main/java/hudson/FilePath.java
            core/src/main/java/hudson/FileSystemProvisioner.java
            core/src/main/java/hudson/FileSystemProvisionerDescriptor.java
            core/src/main/java/hudson/Functions.java
            core/src/main/java/hudson/PluginManager.java
            core/src/main/java/hudson/PluginManagerStaplerOverride.java
            core/src/main/java/hudson/PluginWrapper.java
            core/src/main/java/hudson/cli/CloneableCLICommand.java
            core/src/main/java/hudson/diagnosis/OldDataMonitor.java
            core/src/main/java/hudson/model/AbstractProject.java
            core/src/main/java/hudson/model/ChoiceParameterDefinition.java
            core/src/main/java/hudson/model/Computer.java
            core/src/main/java/hudson/model/Executor.java
            core/src/main/java/hudson/model/Items.java
            core/src/main/java/hudson/model/Result.java
            core/src/main/java/hudson/model/Slave.java
            core/src/main/java/hudson/model/UsageStatistics.java
            core/src/main/java/hudson/org/apache/tools/tar/TarInputStream.java
            core/src/main/java/hudson/org/apache/tools/tar/TarOutputStream.java
            core/src/main/java/hudson/os/SU.java
            core/src/main/java/hudson/scheduler/CronTab.java
            core/src/main/java/hudson/scheduler/CronTabList.java
            core/src/main/java/hudson/security/ACL.java
            core/src/main/java/hudson/security/SecurityRealm.java
            core/src/main/java/hudson/slaves/NodeProvisioner.java
            core/src/main/java/hudson/slaves/SlaveComputer.java
            core/src/main/java/hudson/tasks/Maven.java
            core/src/main/java/hudson/tools/DownloadFromUrlInstaller.java
            core/src/main/java/hudson/triggers/SCMTrigger.java
            core/src/main/java/hudson/triggers/TimerTrigger.java
            core/src/main/java/hudson/triggers/Trigger.java
            core/src/main/java/hudson/util/ChartUtil.java
            core/src/main/java/hudson/util/CopyOnWriteList.java
            core/src/main/java/hudson/util/DoubleLaunchChecker.java
            core/src/main/java/hudson/util/QuotedStringTokenizer.java
            core/src/main/java/hudson/util/RobustCollectionConverter.java
            core/src/main/java/hudson/util/RobustMapConverter.java
            core/src/main/java/hudson/util/RobustReflectionConverter.java
            core/src/main/java/hudson/util/SequentialExecutionQueue.java
            core/src/main/java/hudson/util/io/TarArchiver.java
            core/src/main/java/hudson/util/jna/DotNet.java
            core/src/main/java/hudson/util/xstream/ImmutableListConverter.java
            core/src/main/java/jenkins/model/BlockedBecauseOfBuildInProgress.java
            core/src/main/java/jenkins/model/CauseOfInterruption.java
            core/src/main/java/jenkins/model/Jenkins.java
            core/src/main/java/jenkins/model/JenkinsLocationConfiguration.java
            core/src/main/java/jenkins/model/ParameterizedJobMixIn.java
            core/src/main/java/jenkins/model/RunIdMigrator.java
            core/src/main/java/jenkins/slaves/restarter/SlaveRestarter.java
            core/src/main/java/jenkins/triggers/ReverseBuildTrigger.java
            core/src/main/java/jenkins/util/xstream/CriticalXStreamException.java
            core/src/main/resources/hudson/model/AbstractBuild/changes.jelly
            core/src/main/resources/hudson/model/AbstractBuild/index_pt_BR.properties
            core/src/main/resources/hudson/model/AbstractBuild/index_pt_PT.properties
            core/src/main/resources/hudson/model/AbstractBuild/sidepanel_pt_PT.properties
            core/src/main/resources/hudson/model/Messages.properties
            core/src/main/resources/hudson/model/Messages_ca.properties
            core/src/main/resources/hudson/model/Messages_da.properties
            core/src/main/resources/hudson/model/Messages_de.properties
            core/src/main/resources/hudson/model/Messages_es.properties
            core/src/main/resources/hudson/model/Messages_fi.properties
            core/src/main/resources/hudson/model/Messages_fr.properties
            core/src/main/resources/hudson/model/Messages_hu.properties
            core/src/main/resources/hudson/model/Messages_it.properties
            core/src/main/resources/hudson/model/Messages_ja.properties
            core/src/main/resources/hudson/model/Messages_nl.properties
            core/src/main/resources/hudson/model/Messages_pt_BR.properties
            core/src/main/resources/hudson/model/Messages_ru.properties
            core/src/main/resources/hudson/model/Messages_sl.properties
            core/src/main/resources/hudson/model/Messages_sv_SE.properties
            core/src/main/resources/hudson/model/Messages_tr.properties
            core/src/main/resources/hudson/model/Messages_zh_CN.properties
            core/src/main/resources/hudson/model/Messages_zh_TW.properties
            core/src/main/resources/jenkins/model/CauseOfInterruption/ExceptionInterruption/summary.groovy
            core/src/main/resources/jenkins/model/Messages.properties
            core/src/main/resources/jenkins/model/Messages_ca.properties
            core/src/main/resources/jenkins/model/Messages_da.properties
            core/src/main/resources/jenkins/model/Messages_de.properties
            core/src/main/resources/jenkins/model/Messages_es.properties
            core/src/main/resources/jenkins/model/Messages_fi.properties
            core/src/main/resources/jenkins/model/Messages_fr.properties
            core/src/main/resources/jenkins/model/Messages_hu.properties
            core/src/main/resources/jenkins/model/Messages_it.properties
            core/src/main/resources/jenkins/model/Messages_ja.properties
            core/src/main/resources/jenkins/model/Messages_nl.properties
            core/src/main/resources/jenkins/model/Messages_pt_BR.properties
            core/src/main/resources/jenkins/model/Messages_ru.properties
            core/src/main/resources/jenkins/model/Messages_sl.properties
            core/src/main/resources/jenkins/model/Messages_sv_SE.properties
            core/src/main/resources/jenkins/model/Messages_tr.properties
            core/src/main/resources/jenkins/model/Messages_zh_CN.properties
            core/src/main/resources/jenkins/model/Messages_zh_TW.properties
            core/src/main/resources/jenkins/security/s2m/filepath-filter.conf
            core/src/main/resources/lib/hudson/scriptConsole.properties
            core/src/main/resources/lib/hudson/scriptConsole_da.properties
            core/src/main/resources/lib/hudson/scriptConsole_de.properties
            core/src/main/resources/lib/hudson/scriptConsole_es.properties
            core/src/main/resources/lib/hudson/scriptConsole_fr.properties
            core/src/main/resources/lib/hudson/scriptConsole_ja.properties
            core/src/main/resources/lib/hudson/scriptConsole_ko.properties
            core/src/main/resources/lib/hudson/scriptConsole_nb_NO.properties
            core/src/main/resources/lib/hudson/scriptConsole_nl.properties
            core/src/main/resources/lib/hudson/scriptConsole_pl.properties
            core/src/main/resources/lib/hudson/scriptConsole_pt_BR.properties
            core/src/main/resources/lib/hudson/scriptConsole_ru.properties
            core/src/main/resources/lib/hudson/scriptConsole_sv_SE.properties
            core/src/main/resources/lib/hudson/scriptConsole_zh_TW.properties
            core/src/site/markdown/index.md
            core/src/test/java/hudson/FilePathTest.java
            core/src/test/java/hudson/UtilTest.java
            core/src/test/java/hudson/model/ItemsTest.java
            core/src/test/java/hudson/model/ParametersActionTest.java
            core/src/test/java/hudson/triggers/SCMTriggerTest.java
            core/src/test/java/hudson/triggers/TimerTriggerTest.java
            core/src/test/java/hudson/util/ArgumentListBuilderTest.java
            core/src/test/java/jenkins/model/RunIdMigratorTest.java
            plugins/pom.xml
            pom.xml
            test/pom.xml
            test/src/main/java/com/gargoylesoftware/htmlunit/README.md
            test/src/main/java/com/gargoylesoftware/htmlunit/WebClientUtil.java
            test/src/main/java/com/gargoylesoftware/htmlunit/WebResponseListener.java
            test/src/main/java/com/gargoylesoftware/htmlunit/html/DomNodeUtil.java
            test/src/main/java/com/gargoylesoftware/htmlunit/html/HtmlElementUtil.java
            test/src/main/java/com/gargoylesoftware/htmlunit/html/HtmlFormUtil.java
            test/src/main/java/hudson/core/PluginManagerOverrideTest.java
            test/src/main/java/org/jvnet/hudson/test/ExtractResourceSCM.java
            test/src/main/java/org/jvnet/hudson/test/HudsonPageCreator.java
            test/src/main/java/org/jvnet/hudson/test/HudsonTestCase.java
            test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java
            test/src/main/java/org/jvnet/hudson/test/junit/FailedTest.java
            test/src/main/resources/hudson/core/PluginManagerOverrideTest/BasicPluginManagerOverride/newview.jelly
            test/src/test/groovy/hudson/model/AbstractProjectTest.groovy
            test/src/test/groovy/hudson/security/TokenBasedRememberMeServices2Test.groovy
            test/src/test/groovy/jenkins/bugs/Jenkins19124Test.groovy
            test/src/test/java/hudson/ExceptionTest.java
            test/src/test/java/hudson/PluginTest.java
            test/src/test/java/hudson/bugs/JnlpAccessWithSecuredHudsonTest.java
            test/src/test/java/hudson/bugs/LoginRedirectTest.java
            test/src/test/java/hudson/cli/SetBuildDisplayNameCommandTest.java
            test/src/test/java/hudson/console/ConsoleAnnotatorTest.java
            test/src/test/java/hudson/diagnosis/ReverseProxySetupMonitorTest.java
            test/src/test/java/hudson/diagnosis/TooManyJobsButNoViewTest.java
            test/src/test/java/hudson/model/AsynchPeopleTest.java
            test/src/test/java/hudson/model/DirectlyModifiableViewTest.java
            test/src/test/java/hudson/model/HelpLinkTest.java
            test/src/test/java/hudson/model/HudsonTest.java
            test/src/test/java/hudson/model/JobQueueTest.java
            test/src/test/java/hudson/model/JobTest.java
            test/src/test/java/hudson/model/ManagementLinkTest.java
            test/src/test/java/hudson/model/MyViewsPropertyTest.java
            test/src/test/java/hudson/model/ParametersTest.java
            test/src/test/java/hudson/model/ProjectTest.java
            test/src/test/java/hudson/model/QueueTest.java
            test/src/test/java/hudson/model/SimpleJobTest.java
            test/src/test/java/hudson/model/UserTest.java
            test/src/test/java/hudson/model/ViewPropertyTest.java
            test/src/test/java/hudson/model/ViewTest.java
            test/src/test/java/hudson/model/queue/WideExecutionTest.java
            test/src/test/java/hudson/search/SearchTest.java
            test/src/test/java/hudson/security/LoginTest.java
            test/src/test/java/hudson/security/pages/SignupPage.java
            test/src/test/java/hudson/slaves/JNLPLauncherTest.java
            test/src/test/java/hudson/slaves/NodePropertyTest.java
            test/src/test/java/hudson/tools/JDKInstallerTest.java
            test/src/test/java/hudson/util/AlternativeUiTextProviderTest.java
            test/src/test/java/hudson/util/FormFieldValidatorTest.java
            test/src/test/java/hudson/util/RobustReflectionConverterTest.java
            test/src/test/java/jenkins/model/JenkinsTest.java
            test/src/test/java/jenkins/security/ApiTokenPropertyTest.java
            test/src/test/java/jenkins/security/BasicHeaderProcessorTest.java
            test/src/test/java/jenkins/security/FrameOptionsPageDecoratorTest.java
            test/src/test/java/jenkins/security/RekeySecretAdminMonitorTest.java
            test/src/test/java/jenkins/security/Security177Test.java
            test/src/test/java/jenkins/widgets/BuildListTableTest.java
            test/src/test/java/lib/form/AdvancedButtonTest.java
            test/src/test/java/lib/form/ExpandableTextboxTest.java
            test/src/test/java/lib/form/RepeatableTest.java
            test/src/test/java/lib/form/RowVisibilityGroupTest.java
            test/src/test/java/lib/form/ValidateButtonTest.java
            test/src/test/java/lib/hudson/ListScmBrowsersTest.java
            test/src/test/java/lib/layout/IconTest.java
            test/src/test/java/lib/layout/LayoutTest.java
            test/src/test/java/lib/layout/RenderOnDemandTest.java
            test/src/test/java/lib/layout/TaskTest.java
            test/src/test/java/org/jvnet/hudson/main/JenkinsRuleTimeoutTest.java
            test/src/test/java/org/jvnet/hudson/main/UseRecipesWithJenkinsRuleTest.java
            translation-tool.pl
            war/pom.xml
            war/src/main/webapp/help/project-config/custom-workspace.html
            war/src/main/webapp/scripts/hudson-behavior.js
            war/src/main/webapp/scripts/prototype.js
            http://jenkins-ci.org/commit/jenkins/3ab5336f3c6b9c6577560faf8c85fb0d38d3642b
            Log:
            Merge branch 'master' into config-ui-changes

            • master: (178 commits)
              Some docs
              Some docs
              Fixing comments from @amuniz
              Fixing NITs from @KostyaSha
              commons-compress -> 1.10
              Noting #1788
              Remove hardcode in tar test
              [FIXED JENKINS-10629] Unbroke stream with new tar implementation.
              Revert "Revert "FIXED JENKINS-10629] - Enable BigNumber mode to support archiving of files with size >8Gb""
              Revert "Revert "JENKINS-10629 - Migrate the Tar archives handling code to commons-compress""
              Fix at-since from PR #1788
              Merge PR #1788: Make plugin manager pluggable
              WebClientUtil (HtmlUnit to v2.18)
              Updated HtmlUnit to v2.18
              Remove JavaScriptEngine override
              Fixed TaskTest tests
              Fixed RobustReflectionConverterTest tests
              Fixed RobustReflectionConverterTest compile errors after merge
              Make sure all background JS is done executing before querying the DOM
              ApiTokenPropertyTest fixes
              ...

            Compare: https://github.com/jenkinsci/jenkins/compare/71adc679050a...3ab5336f3c6b

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: tfennelly Path: changelog.html cli/pom.xml core/pom.xml core/src/main/java/hudson/FilePath.java core/src/main/java/hudson/FileSystemProvisioner.java core/src/main/java/hudson/FileSystemProvisionerDescriptor.java core/src/main/java/hudson/Functions.java core/src/main/java/hudson/PluginManager.java core/src/main/java/hudson/PluginManagerStaplerOverride.java core/src/main/java/hudson/PluginWrapper.java core/src/main/java/hudson/cli/CloneableCLICommand.java core/src/main/java/hudson/diagnosis/OldDataMonitor.java core/src/main/java/hudson/model/AbstractProject.java core/src/main/java/hudson/model/ChoiceParameterDefinition.java core/src/main/java/hudson/model/Computer.java core/src/main/java/hudson/model/Executor.java core/src/main/java/hudson/model/Items.java core/src/main/java/hudson/model/Result.java core/src/main/java/hudson/model/Slave.java core/src/main/java/hudson/model/UsageStatistics.java core/src/main/java/hudson/org/apache/tools/tar/TarInputStream.java core/src/main/java/hudson/org/apache/tools/tar/TarOutputStream.java core/src/main/java/hudson/os/SU.java core/src/main/java/hudson/scheduler/CronTab.java core/src/main/java/hudson/scheduler/CronTabList.java core/src/main/java/hudson/security/ACL.java core/src/main/java/hudson/security/SecurityRealm.java core/src/main/java/hudson/slaves/NodeProvisioner.java core/src/main/java/hudson/slaves/SlaveComputer.java core/src/main/java/hudson/tasks/Maven.java core/src/main/java/hudson/tools/DownloadFromUrlInstaller.java core/src/main/java/hudson/triggers/SCMTrigger.java core/src/main/java/hudson/triggers/TimerTrigger.java core/src/main/java/hudson/triggers/Trigger.java core/src/main/java/hudson/util/ChartUtil.java core/src/main/java/hudson/util/CopyOnWriteList.java core/src/main/java/hudson/util/DoubleLaunchChecker.java core/src/main/java/hudson/util/QuotedStringTokenizer.java core/src/main/java/hudson/util/RobustCollectionConverter.java core/src/main/java/hudson/util/RobustMapConverter.java core/src/main/java/hudson/util/RobustReflectionConverter.java core/src/main/java/hudson/util/SequentialExecutionQueue.java core/src/main/java/hudson/util/io/TarArchiver.java core/src/main/java/hudson/util/jna/DotNet.java core/src/main/java/hudson/util/xstream/ImmutableListConverter.java core/src/main/java/jenkins/model/BlockedBecauseOfBuildInProgress.java core/src/main/java/jenkins/model/CauseOfInterruption.java core/src/main/java/jenkins/model/Jenkins.java core/src/main/java/jenkins/model/JenkinsLocationConfiguration.java core/src/main/java/jenkins/model/ParameterizedJobMixIn.java core/src/main/java/jenkins/model/RunIdMigrator.java core/src/main/java/jenkins/slaves/restarter/SlaveRestarter.java core/src/main/java/jenkins/triggers/ReverseBuildTrigger.java core/src/main/java/jenkins/util/xstream/CriticalXStreamException.java core/src/main/resources/hudson/model/AbstractBuild/changes.jelly core/src/main/resources/hudson/model/AbstractBuild/index_pt_BR.properties core/src/main/resources/hudson/model/AbstractBuild/index_pt_PT.properties core/src/main/resources/hudson/model/AbstractBuild/sidepanel_pt_PT.properties core/src/main/resources/hudson/model/Messages.properties core/src/main/resources/hudson/model/Messages_ca.properties core/src/main/resources/hudson/model/Messages_da.properties core/src/main/resources/hudson/model/Messages_de.properties core/src/main/resources/hudson/model/Messages_es.properties core/src/main/resources/hudson/model/Messages_fi.properties core/src/main/resources/hudson/model/Messages_fr.properties core/src/main/resources/hudson/model/Messages_hu.properties core/src/main/resources/hudson/model/Messages_it.properties core/src/main/resources/hudson/model/Messages_ja.properties core/src/main/resources/hudson/model/Messages_nl.properties core/src/main/resources/hudson/model/Messages_pt_BR.properties core/src/main/resources/hudson/model/Messages_ru.properties core/src/main/resources/hudson/model/Messages_sl.properties core/src/main/resources/hudson/model/Messages_sv_SE.properties core/src/main/resources/hudson/model/Messages_tr.properties core/src/main/resources/hudson/model/Messages_zh_CN.properties core/src/main/resources/hudson/model/Messages_zh_TW.properties core/src/main/resources/jenkins/model/CauseOfInterruption/ExceptionInterruption/summary.groovy core/src/main/resources/jenkins/model/Messages.properties core/src/main/resources/jenkins/model/Messages_ca.properties core/src/main/resources/jenkins/model/Messages_da.properties core/src/main/resources/jenkins/model/Messages_de.properties core/src/main/resources/jenkins/model/Messages_es.properties core/src/main/resources/jenkins/model/Messages_fi.properties core/src/main/resources/jenkins/model/Messages_fr.properties core/src/main/resources/jenkins/model/Messages_hu.properties core/src/main/resources/jenkins/model/Messages_it.properties core/src/main/resources/jenkins/model/Messages_ja.properties core/src/main/resources/jenkins/model/Messages_nl.properties core/src/main/resources/jenkins/model/Messages_pt_BR.properties core/src/main/resources/jenkins/model/Messages_ru.properties core/src/main/resources/jenkins/model/Messages_sl.properties core/src/main/resources/jenkins/model/Messages_sv_SE.properties core/src/main/resources/jenkins/model/Messages_tr.properties core/src/main/resources/jenkins/model/Messages_zh_CN.properties core/src/main/resources/jenkins/model/Messages_zh_TW.properties core/src/main/resources/jenkins/security/s2m/filepath-filter.conf core/src/main/resources/lib/hudson/scriptConsole.properties core/src/main/resources/lib/hudson/scriptConsole_da.properties core/src/main/resources/lib/hudson/scriptConsole_de.properties core/src/main/resources/lib/hudson/scriptConsole_es.properties core/src/main/resources/lib/hudson/scriptConsole_fr.properties core/src/main/resources/lib/hudson/scriptConsole_ja.properties core/src/main/resources/lib/hudson/scriptConsole_ko.properties core/src/main/resources/lib/hudson/scriptConsole_nb_NO.properties core/src/main/resources/lib/hudson/scriptConsole_nl.properties core/src/main/resources/lib/hudson/scriptConsole_pl.properties core/src/main/resources/lib/hudson/scriptConsole_pt_BR.properties core/src/main/resources/lib/hudson/scriptConsole_ru.properties core/src/main/resources/lib/hudson/scriptConsole_sv_SE.properties core/src/main/resources/lib/hudson/scriptConsole_zh_TW.properties core/src/site/markdown/index.md core/src/test/java/hudson/FilePathTest.java core/src/test/java/hudson/UtilTest.java core/src/test/java/hudson/model/ItemsTest.java core/src/test/java/hudson/model/ParametersActionTest.java core/src/test/java/hudson/triggers/SCMTriggerTest.java core/src/test/java/hudson/triggers/TimerTriggerTest.java core/src/test/java/hudson/util/ArgumentListBuilderTest.java core/src/test/java/jenkins/model/RunIdMigratorTest.java plugins/pom.xml pom.xml test/pom.xml test/src/main/java/com/gargoylesoftware/htmlunit/README.md test/src/main/java/com/gargoylesoftware/htmlunit/WebClientUtil.java test/src/main/java/com/gargoylesoftware/htmlunit/WebResponseListener.java test/src/main/java/com/gargoylesoftware/htmlunit/html/DomNodeUtil.java test/src/main/java/com/gargoylesoftware/htmlunit/html/HtmlElementUtil.java test/src/main/java/com/gargoylesoftware/htmlunit/html/HtmlFormUtil.java test/src/main/java/hudson/core/PluginManagerOverrideTest.java test/src/main/java/org/jvnet/hudson/test/ExtractResourceSCM.java test/src/main/java/org/jvnet/hudson/test/HudsonPageCreator.java test/src/main/java/org/jvnet/hudson/test/HudsonTestCase.java test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java test/src/main/java/org/jvnet/hudson/test/junit/FailedTest.java test/src/main/resources/hudson/core/PluginManagerOverrideTest/BasicPluginManagerOverride/newview.jelly test/src/test/groovy/hudson/model/AbstractProjectTest.groovy test/src/test/groovy/hudson/security/TokenBasedRememberMeServices2Test.groovy test/src/test/groovy/jenkins/bugs/Jenkins19124Test.groovy test/src/test/java/hudson/ExceptionTest.java test/src/test/java/hudson/PluginTest.java test/src/test/java/hudson/bugs/JnlpAccessWithSecuredHudsonTest.java test/src/test/java/hudson/bugs/LoginRedirectTest.java test/src/test/java/hudson/cli/SetBuildDisplayNameCommandTest.java test/src/test/java/hudson/console/ConsoleAnnotatorTest.java test/src/test/java/hudson/diagnosis/ReverseProxySetupMonitorTest.java test/src/test/java/hudson/diagnosis/TooManyJobsButNoViewTest.java test/src/test/java/hudson/model/AsynchPeopleTest.java test/src/test/java/hudson/model/DirectlyModifiableViewTest.java test/src/test/java/hudson/model/HelpLinkTest.java test/src/test/java/hudson/model/HudsonTest.java test/src/test/java/hudson/model/JobQueueTest.java test/src/test/java/hudson/model/JobTest.java test/src/test/java/hudson/model/ManagementLinkTest.java test/src/test/java/hudson/model/MyViewsPropertyTest.java test/src/test/java/hudson/model/ParametersTest.java test/src/test/java/hudson/model/ProjectTest.java test/src/test/java/hudson/model/QueueTest.java test/src/test/java/hudson/model/SimpleJobTest.java test/src/test/java/hudson/model/UserTest.java test/src/test/java/hudson/model/ViewPropertyTest.java test/src/test/java/hudson/model/ViewTest.java test/src/test/java/hudson/model/queue/WideExecutionTest.java test/src/test/java/hudson/search/SearchTest.java test/src/test/java/hudson/security/LoginTest.java test/src/test/java/hudson/security/pages/SignupPage.java test/src/test/java/hudson/slaves/JNLPLauncherTest.java test/src/test/java/hudson/slaves/NodePropertyTest.java test/src/test/java/hudson/tools/JDKInstallerTest.java test/src/test/java/hudson/util/AlternativeUiTextProviderTest.java test/src/test/java/hudson/util/FormFieldValidatorTest.java test/src/test/java/hudson/util/RobustReflectionConverterTest.java test/src/test/java/jenkins/model/JenkinsTest.java test/src/test/java/jenkins/security/ApiTokenPropertyTest.java test/src/test/java/jenkins/security/BasicHeaderProcessorTest.java test/src/test/java/jenkins/security/FrameOptionsPageDecoratorTest.java test/src/test/java/jenkins/security/RekeySecretAdminMonitorTest.java test/src/test/java/jenkins/security/Security177Test.java test/src/test/java/jenkins/widgets/BuildListTableTest.java test/src/test/java/lib/form/AdvancedButtonTest.java test/src/test/java/lib/form/ExpandableTextboxTest.java test/src/test/java/lib/form/RepeatableTest.java test/src/test/java/lib/form/RowVisibilityGroupTest.java test/src/test/java/lib/form/ValidateButtonTest.java test/src/test/java/lib/hudson/ListScmBrowsersTest.java test/src/test/java/lib/layout/IconTest.java test/src/test/java/lib/layout/LayoutTest.java test/src/test/java/lib/layout/RenderOnDemandTest.java test/src/test/java/lib/layout/TaskTest.java test/src/test/java/org/jvnet/hudson/main/JenkinsRuleTimeoutTest.java test/src/test/java/org/jvnet/hudson/main/UseRecipesWithJenkinsRuleTest.java translation-tool.pl war/pom.xml war/src/main/webapp/help/project-config/custom-workspace.html war/src/main/webapp/scripts/hudson-behavior.js war/src/main/webapp/scripts/prototype.js http://jenkins-ci.org/commit/jenkins/3ab5336f3c6b9c6577560faf8c85fb0d38d3642b Log: Merge branch 'master' into config-ui-changes master: (178 commits) Some docs Some docs Fixing comments from @amuniz Fixing NITs from @KostyaSha commons-compress -> 1.10 Noting #1788 Remove hardcode in tar test [FIXED JENKINS-10629] Unbroke stream with new tar implementation. Revert "Revert "FIXED JENKINS-10629 ] - Enable BigNumber mode to support archiving of files with size >8Gb"" Revert "Revert " JENKINS-10629 - Migrate the Tar archives handling code to commons-compress"" Fix at-since from PR #1788 Merge PR #1788: Make plugin manager pluggable WebClientUtil (HtmlUnit to v2.18) Updated HtmlUnit to v2.18 Remove JavaScriptEngine override Fixed TaskTest tests Fixed RobustReflectionConverterTest tests Fixed RobustReflectionConverterTest compile errors after merge Make sure all background JS is done executing before querying the DOM ApiTokenPropertyTest fixes ... Compare: https://github.com/jenkinsci/jenkins/compare/71adc679050a...3ab5336f3c6b
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kanstantsin Shautsou
            Path:
            core/pom.xml
            core/src/main/java/hudson/FilePath.java
            core/src/main/java/hudson/org/apache/tools/tar/TarInputStream.java
            core/src/main/java/hudson/org/apache/tools/tar/TarOutputStream.java
            core/src/main/java/hudson/util/io/TarArchiver.java
            http://jenkins-ci.org/commit/jenkins/6e5740eb5be85ede0cbd01d900cb6d5fbf71ee62
            Log:
            Revert "Revert "JENKINS-10629 - Migrate the Tar archives handling code to commons-compress""

            This reverts commit 8f1280a85c54ea6150b15c38303464ab23b32e92.

            (cherry picked from commit 03bd5959cb94a0e626c5ace910d14c3083a9db2c)

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kanstantsin Shautsou Path: core/pom.xml core/src/main/java/hudson/FilePath.java core/src/main/java/hudson/org/apache/tools/tar/TarInputStream.java core/src/main/java/hudson/org/apache/tools/tar/TarOutputStream.java core/src/main/java/hudson/util/io/TarArchiver.java http://jenkins-ci.org/commit/jenkins/6e5740eb5be85ede0cbd01d900cb6d5fbf71ee62 Log: Revert "Revert " JENKINS-10629 - Migrate the Tar archives handling code to commons-compress"" This reverts commit 8f1280a85c54ea6150b15c38303464ab23b32e92. (cherry picked from commit 03bd5959cb94a0e626c5ace910d14c3083a9db2c)
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kanstantsin Shautsou
            Path:
            core/src/main/java/hudson/util/io/TarArchiver.java
            http://jenkins-ci.org/commit/jenkins/2b63fea84739c1ae900e6997efc18658bcdbaee0
            Log:
            Revert "Revert "FIXED JENKINS-10629] - Enable BigNumber mode to support archiving of files with size >8Gb""

            This reverts commit ee57300963ca0137565f61fe314d459b627ad74b.

            (cherry picked from commit 2ef29215c2b311a9d5c2e515268285b5623ce833)

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kanstantsin Shautsou Path: core/src/main/java/hudson/util/io/TarArchiver.java http://jenkins-ci.org/commit/jenkins/2b63fea84739c1ae900e6997efc18658bcdbaee0 Log: Revert "Revert "FIXED JENKINS-10629 ] - Enable BigNumber mode to support archiving of files with size >8Gb"" This reverts commit ee57300963ca0137565f61fe314d459b627ad74b. (cherry picked from commit 2ef29215c2b311a9d5c2e515268285b5623ce833)
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kanstantsin Shautsou
            Path:
            core/src/main/java/hudson/util/io/TarArchiver.java
            core/src/test/java/hudson/FilePathTest.java
            http://jenkins-ci.org/commit/jenkins/fd1e392fd4cb9d9feade9da7540c00921d32d816
            Log:
            [FIXED JENKINS-10629] Unbroke stream with new tar implementation.

            Causes bytes lost and truncated tar archive.
            TarBuffer not used in TarArchiveOutputStream.

            (cherry picked from commit 3e187a026408d5ca74202f7e26dd565cde2e87d0)

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kanstantsin Shautsou Path: core/src/main/java/hudson/util/io/TarArchiver.java core/src/test/java/hudson/FilePathTest.java http://jenkins-ci.org/commit/jenkins/fd1e392fd4cb9d9feade9da7540c00921d32d816 Log: [FIXED JENKINS-10629] Unbroke stream with new tar implementation. Causes bytes lost and truncated tar archive. TarBuffer not used in TarArchiveOutputStream. (cherry picked from commit 3e187a026408d5ca74202f7e26dd565cde2e87d0)
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #4358
            Revert "Revert "JENKINS-10629 - Migrate the Tar archives handling code to commons-compress"" (Revision 6e5740eb5be85ede0cbd01d900cb6d5fbf71ee62)
            Revert "Revert "FIXED JENKINS-10629] - Enable BigNumber mode to support archiving of files with size >8Gb"" (Revision 2b63fea84739c1ae900e6997efc18658bcdbaee0)
            [FIXED JENKINS-10629] Unbroke stream with new tar implementation. (Revision fd1e392fd4cb9d9feade9da7540c00921d32d816)

            Result = UNSTABLE
            ogondza : 6e5740eb5be85ede0cbd01d900cb6d5fbf71ee62
            Files :

            • core/src/main/java/hudson/org/apache/tools/tar/TarInputStream.java
            • core/src/main/java/hudson/FilePath.java
            • core/src/main/java/hudson/util/io/TarArchiver.java
            • core/src/main/java/hudson/org/apache/tools/tar/TarOutputStream.java
            • core/pom.xml

            ogondza : 2b63fea84739c1ae900e6997efc18658bcdbaee0
            Files :

            • core/src/main/java/hudson/util/io/TarArchiver.java

            ogondza : fd1e392fd4cb9d9feade9da7540c00921d32d816
            Files :

            • core/src/test/java/hudson/FilePathTest.java
            • core/src/main/java/hudson/util/io/TarArchiver.java
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4358 Revert "Revert " JENKINS-10629 - Migrate the Tar archives handling code to commons-compress"" (Revision 6e5740eb5be85ede0cbd01d900cb6d5fbf71ee62) Revert "Revert "FIXED JENKINS-10629 ] - Enable BigNumber mode to support archiving of files with size >8Gb"" (Revision 2b63fea84739c1ae900e6997efc18658bcdbaee0) [FIXED JENKINS-10629] Unbroke stream with new tar implementation. (Revision fd1e392fd4cb9d9feade9da7540c00921d32d816) Result = UNSTABLE ogondza : 6e5740eb5be85ede0cbd01d900cb6d5fbf71ee62 Files : core/src/main/java/hudson/org/apache/tools/tar/TarInputStream.java core/src/main/java/hudson/FilePath.java core/src/main/java/hudson/util/io/TarArchiver.java core/src/main/java/hudson/org/apache/tools/tar/TarOutputStream.java core/pom.xml ogondza : 2b63fea84739c1ae900e6997efc18658bcdbaee0 Files : core/src/main/java/hudson/util/io/TarArchiver.java ogondza : fd1e392fd4cb9d9feade9da7540c00921d32d816 Files : core/src/test/java/hudson/FilePathTest.java core/src/main/java/hudson/util/io/TarArchiver.java
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: tfennelly
            Path:
            test/src/main/java/hudson/core/PluginManagerOverrideTest.java
            test/src/main/resources/hudson/core/PluginManagerOverrideTest/BasicPluginManagerOverride/newview.jelly
            http://jenkins-ci.org/commit/jenkins-test-harness/9823d43e2d9ebd9cccad7efca8eb965bc4aafedf
            Log:
            Merge branch 'master' into upgrade-htmlunit

            • master:
              commons-compress -> 1.10
              Noting #1788
              Remove hardcode in tar test
              [FIXED JENKINS-10629] Unbroke stream with new tar implementation.
              Revert "Revert "FIXED JENKINS-10629] - Enable BigNumber mode to support archiving of files with size >8Gb""
              Revert "Revert "JENKINS-10629 - Migrate the Tar archives handling code to commons-compress""
              Fix at-since from PR #1788
              Merge PR #1788: Make plugin manager pluggable

            Originally-Committed-As: 3f98011bd4aae0ee6956d264c952782452389f79

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: tfennelly Path: test/src/main/java/hudson/core/PluginManagerOverrideTest.java test/src/main/resources/hudson/core/PluginManagerOverrideTest/BasicPluginManagerOverride/newview.jelly http://jenkins-ci.org/commit/jenkins-test-harness/9823d43e2d9ebd9cccad7efca8eb965bc4aafedf Log: Merge branch 'master' into upgrade-htmlunit master: commons-compress -> 1.10 Noting #1788 Remove hardcode in tar test [FIXED JENKINS-10629] Unbroke stream with new tar implementation. Revert "Revert "FIXED JENKINS-10629 ] - Enable BigNumber mode to support archiving of files with size >8Gb"" Revert "Revert " JENKINS-10629 - Migrate the Tar archives handling code to commons-compress"" Fix at-since from PR #1788 Merge PR #1788: Make plugin manager pluggable Originally-Committed-As: 3f98011bd4aae0ee6956d264c952782452389f79

              People

              Assignee:
              integer Kanstantsin Shautsou
              Reporter:
              keibaker keith baker
              Votes:
              6 Vote for this issue
              Watchers:
              26 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: