[JENKINS-11333] Make fingerprinting configurable in Maven projects - Jenkins Jira

XML

Word

Printable

Details

Type: Improvement
Status: Resolved (View Workflow)
Priority: Major
Resolution: Fixed
Component/s: maven-plugin
Labels:
- fingerprints
- performance
Environment:
1.448

Similar Issues:

Show

Description

Currently, in a Maven Project, fingerprints are generated for all build artifacts (created and used).

In a freestyle project, you can manually select files to be fingerprinted using the Fingerprinter publisher.

This needs to be possible for Maven Projects, too.

Consider for example a Maven project that uses post-build steps to create additional artifacts. You can archive them (without them being fingerprinted), but you cannot choose to fingerprint them.

Looking at hudson.tasks.Fingerprinter, I see no reason why this publisher should not be available for configuration.

If you enter the publisher by hand into the config.xml of a job, it works (until you reconfig that job, of course), so this seems to be a display issue. One small drawback: two fingerprintActions are included.

Tasks:

make Fingerprinter available for Maven projects
prevent Fingerprinter from always creating a new FingerprintAction (i.e. let it check for any existing FingerprintActions (like MavenFingerprinter does))

the second part is trivial, I can create a pull request for that.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

FreeStylePublishers.png
11 kB
2012-01-23 14:25
MavenJobPublishers.png
5 kB
2012-01-23 14:25

Issue Links

depends on

JENKINS-17606 Copy Artifact's fingerprinting creates second hudson.tasks.Fingerprinter_-FingerprintAction section with just the artifacts copied

Closed

is duplicated by

JENKINS-18615 Add option do disable fingerprinting for maven jobs

Resolved

is related to

JENKINS-19712 [Fingerprint] Excessive Heap consumption during "Waiting for Jenkins to finish collecting data"

Open

JENKINS-11814 Maven artifact fingerprints are computed and recorded twice

Resolved

Activity

Ascending order - Click to sort in descending order

Stephan Pauxberger created issue - 2011-10-12 14:05

Andrew Bayer added a comment - 2012-01-18 00:30

Already is there.

Andrew Bayer added a comment - 2012-01-18 00:30 Already is there.

Andrew Bayer made changes - 2012-01-18 00:30

Field	Original Value	New Value
Resolution		Not A Defect [ 7 ]
Status	Open [ 1 ]	Resolved [ 5 ]

Stephan Pauxberger added a comment - 2012-01-23 14:06

Beg to differ.

Using a vanilla installation of jenkins 1.448

Create a new freestyle job. In job configuration, you select "record fingerprints..." and "archive artifacts"

Create a new Maven job. In job configuration, you can only select "archive artifacts", but not record fingerprints

Stephan Pauxberger added a comment - 2012-01-23 14:06 Beg to differ. Using a vanilla installation of jenkins 1.448 Create a new freestyle job. In job configuration, you select "record fingerprints..." and "archive artifacts" Create a new Maven job. In job configuration, you can only select "archive artifacts", but not record fingerprints

Stephan Pauxberger made changes - 2012-01-23 14:06

Resolution	Not A Defect [ 7 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Stephan Pauxberger made changes - 2012-01-23 14:08

Description	Currently, in a Maven Project, fingerprints are generated for all build artifacts (created and used). In a freestyle project, you can manually select files to be fingerprinted using the Fingerprinter publisher. This needs to be possible for Maven Projects, too. Consider for example a Maven project that uses post-build steps to create additional artifacts. You con archive them (without them being fingerprinted), but you cannot choose to fingerprint them. Looking at hudson.tasks.Fringerprinter, I see no reason why this publisher should not be available for configuration. If you enter the publisher by hand into the config.xml of a job, it works (until you reconfig that job, of course). One small drawback: two fingerprintActions are included. Tasks: - make Fingerprinter available for Maven projects - prevent Fingerprinter from always creating a new FingerprintAction (i.e. let it check for any existing FingerprintActions (like MavenFingerprinter does)) the second part is trivial, I can create a pull request for that.	Currently, in a Maven Project, fingerprints are generated for all build artifacts (created and used). In a freestyle project, you can manually select files to be fingerprinted using the Fingerprinter publisher. This needs to be possible for Maven Projects, too. Consider for example a Maven project that uses post-build steps to create additional artifacts. You can archive them (without them being fingerprinted), but you cannot choose to fingerprint them. Looking at hudson.tasks.Fingerprinter, I see no reason why this publisher should not be available for configuration. If you enter the publisher by hand into the config.xml of a job, it works (until you reconfig that job, of course), so this seems to be a display issue. One small drawback: two fingerprintActions are included. Tasks: - make Fingerprinter available for Maven projects - prevent Fingerprinter from always creating a new FingerprintAction (i.e. let it check for any existing FingerprintActions (like MavenFingerprinter does)) the second part is trivial, I can create a pull request for that.
Environment		1.448

Stephan Pauxberger added a comment - 2012-01-23 14:25

Screenshot of Publishers for freestyle and Maven projects

Stephan Pauxberger added a comment - 2012-01-23 14:25 Screenshot of Publishers for freestyle and Maven projects

Stephan Pauxberger made changes - 2012-01-23 14:25

Attachment		FreeStylePublishers.png [ 21437 ]
Attachment		MavenJobPublishers.png [ 21438 ]

Jesse Glick added a comment - 2014-05-21 21:03

I would like to broaden the scope of this a bit: you ought to be able to disable automatic fingerprinting for Maven projects, readding some manually configured fingerprints when required. The reason is that field data suggests that fingerprinting all consumed & produced artifacts can add a lot of overhead to the post-build phase, and it affects the more precious Jenkins master as well as the more disposable slave (since Fingerprint.save does disk I/O).

Jesse Glick added a comment - 2014-05-21 21:03 I would like to broaden the scope of this a bit: you ought to be able to disable automatic fingerprinting for Maven projects, readding some manually configured fingerprints when required. The reason is that field data suggests that fingerprinting all consumed & produced artifacts can add a lot of overhead to the post-build phase, and it affects the more precious Jenkins master as well as the more disposable slave (since Fingerprint.save does disk I/O).

Jesse Glick made changes - 2014-05-21 21:03

Labels		fingerprints performance
Summary	Fingerprinter-Publisher should be available in Maven jobs	Make fingerprinting configurable in Maven projects

Jesse Glick made changes - 2014-05-21 21:04

Link

This issue is related to JENKINS-19712 [ JENKINS-19712 ]

Jesse Glick made changes - 2014-05-21 21:04

Link

This issue is related to ~~JENKINS-11814~~ [ ~~JENKINS-11814~~ ]

Jesse Glick added a comment - 2014-05-21 21:16

The fix to Fingerprinter was already done in ~~JENKINS-17606~~.

Jesse Glick added a comment - 2014-05-21 21:16 The fix to Fingerprinter was already done in JENKINS-17606 .

Jesse Glick made changes - 2014-05-21 21:16

Link

This issue depends on ~~JENKINS-17606~~ [ ~~JENKINS-17606~~ ]

Jesse Glick made changes - 2014-05-21 21:49

Assignee

Jesse Glick [ jglick ]

Jesse Glick made changes - 2014-05-21 21:49

Status

Reopened [ 4 ]

Open [ 1 ]

Jesse Glick made changes - 2014-05-21 21:49

Status

Open [ 1 ]

In Progress [ 3 ]

SCM/JIRA link daemon added a comment - 2014-05-21 22:34

Code changed in jenkins
User: Jesse Glick
Path:
src/main/java/hudson/maven/MavenModule.java
src/main/java/hudson/maven/MavenModuleSet.java
src/main/java/hudson/maven/reporters/MavenArtifactArchiver.java
src/main/java/hudson/maven/reporters/MavenFingerprinter.java
src/main/resources/hudson/maven/MavenModuleSet/configure-entries.jelly
src/main/webapp/fingerprintingDisabled.html
src/test/java/hudson/maven/MavenModuleSetTest.java
http://jenkins-ci.org/commit/maven-plugin/33c52c897e893029631615cc5bebacd15d535454
Log:
[FIXED JENKINS-11333] Allow users to disable automatic fingerprinting, but add in explicit fingerprinting if desired.

SCM/JIRA link daemon added a comment - 2014-05-21 22:34 Code changed in jenkins User: Jesse Glick Path: src/main/java/hudson/maven/MavenModule.java src/main/java/hudson/maven/MavenModuleSet.java src/main/java/hudson/maven/reporters/MavenArtifactArchiver.java src/main/java/hudson/maven/reporters/MavenFingerprinter.java src/main/resources/hudson/maven/MavenModuleSet/configure-entries.jelly src/main/webapp/fingerprintingDisabled.html src/test/java/hudson/maven/MavenModuleSetTest.java http://jenkins-ci.org/commit/maven-plugin/33c52c897e893029631615cc5bebacd15d535454 Log: [FIXED JENKINS-11333] Allow users to disable automatic fingerprinting, but add in explicit fingerprinting if desired.

SCM/JIRA link daemon made changes - 2014-05-21 22:34

Resolution		Fixed [ 1 ]
Status	In Progress [ 3 ]	Resolved [ 5 ]

SCM/JIRA link daemon added a comment - 2014-05-21 23:50

Code changed in jenkins
User: Jesse Glick
Path:
src/main/java/hudson/maven/MavenModule.java
src/main/java/hudson/maven/MavenModuleSet.java
src/main/java/hudson/maven/reporters/MavenArtifactArchiver.java
src/main/java/hudson/maven/reporters/MavenFingerprinter.java
src/main/resources/hudson/maven/MavenModuleSet/configure-entries.jelly
src/main/webapp/fingerprintingDisabled.html
src/test/java/hudson/maven/MavenModuleSetTest.java
http://jenkins-ci.org/commit/maven-plugin/728878bed3c854dcc5c63aec1b7b12e3a133da51
Log:
[FIXED JENKINS-11333] Allow users to disable automatic fingerprinting, but add in explicit fingerprinting if desired.
Conflicts:
src/main/java/hudson/maven/MavenModuleSet.java
src/main/resources/hudson/maven/MavenModuleSet/configure-entries.jelly

SCM/JIRA link daemon added a comment - 2014-05-21 23:50 Code changed in jenkins User: Jesse Glick Path: src/main/java/hudson/maven/MavenModule.java src/main/java/hudson/maven/MavenModuleSet.java src/main/java/hudson/maven/reporters/MavenArtifactArchiver.java src/main/java/hudson/maven/reporters/MavenFingerprinter.java src/main/resources/hudson/maven/MavenModuleSet/configure-entries.jelly src/main/webapp/fingerprintingDisabled.html src/test/java/hudson/maven/MavenModuleSetTest.java http://jenkins-ci.org/commit/maven-plugin/728878bed3c854dcc5c63aec1b7b12e3a133da51 Log: [FIXED JENKINS-11333] Allow users to disable automatic fingerprinting, but add in explicit fingerprinting if desired. Conflicts: src/main/java/hudson/maven/MavenModuleSet.java src/main/resources/hudson/maven/MavenModuleSet/configure-entries.jelly

Joseph Benken added a comment - 2014-07-02 20:50

Does this address https://issues.jenkins-ci.org/browse/JENKINS-18615? Is there a target version for this enhancement?

Joseph Benken added a comment - 2014-07-02 20:50 Does this address https://issues.jenkins-ci.org/browse/JENKINS-18615? Is there a target version for this enhancement?

Jesse Glick made changes - 2014-07-03 21:21

Link

This issue is duplicated by ~~JENKINS-18615~~ [ ~~JENKINS-18615~~ ]

Jesse Glick added a comment - 2014-07-03 21:22

@benken_parasoft yes and it has been released.

Jesse Glick added a comment - 2014-07-03 21:22 @benken_parasoft yes and it has been released.

Jenkins IRC Bot made changes - 2014-09-27 18:27

Component/s		maven-plugin [ 16033 ]
Component/s	maven2 [ 15487 ]

R. Tyler Croy made changes - 2016-07-25 23:54

Workflow

JNJira [ 141552 ]

JNJira + In-Review [ 189685 ]

People

Assignee:: Jesse Glick

Reporter:: Stephan Pauxberger

Votes:: 1 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 2011-10-12 14:05

Updated:: 2014-09-27 18:27

Resolved:: 2014-05-21 22:34