Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-11502

join don't check for actual triggered job

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Major Major
    • join-plugin
    • None

      JOB_1 is configured with :
      join on JOB_3
      downstream project JOB_2
      Downstream ext set to trigger JOB_failure on build failure
      running JOB_1, JOB_3 is never triggered as join is waiting for both JOB_2 and JOB_failure to complete

      JoinTrigger.getDownstreamExtDownstream retrieves DownstreamTrigger to get the child project list, but should check DownstreamDependency.shouldTriggerBuild before

          [JENKINS-11502] join don't check for actual triggered job

          Nicolas De Loof created issue -
          Nicolas De Loof made changes -
          Assignee Original: mdonohue [ mdonohue ] New: Nicolas De Loof [ ndeloof ]

          Nicolas De Loof added a comment -

          fix proposal https://github.com/jenkinsci/join-plugin/pull/2

          Nicolas De Loof added a comment - fix proposal https://github.com/jenkinsci/join-plugin/pull/2

          Stefan Wolf added a comment -

          Did you check JENKINS-10435? It seems to me that this is related to this feature request. I agreed with Kutzi that this is no bug. Tell me what you think.
          Your pull request would for example add the following behavior:

          • Job A fails
          • No downstream jobs are triggered, since they all need the Job A to pass
          • Join Job gets triggered since there are no intermediate jobs
            I think that this would happen. I do not think that this is really desirable.

          If you write some tests for your pull request which make sure that this will not happen I will happily merge it.

          Stefan Wolf added a comment - Did you check JENKINS-10435 ? It seems to me that this is related to this feature request. I agreed with Kutzi that this is no bug. Tell me what you think. Your pull request would for example add the following behavior: Job A fails No downstream jobs are triggered, since they all need the Job A to pass Join Job gets triggered since there are no intermediate jobs I think that this would happen. I do not think that this is really desirable. If you write some tests for your pull request which make sure that this will not happen I will happily merge it.

          Nicolas De Loof added a comment -

          You're completely right, I'll have to review my strategy to detect which downstream job is expected to be triggered according to the join conditions.

          Nicolas De Loof added a comment - You're completely right, I'll have to review my strategy to detect which downstream job is expected to be triggered according to the join conditions.
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 141729 ] New: JNJira + In-Review [ 175540 ]
          Nicolas De Loof made changes -
          Assignee Original: Nicolas De Loof [ ndeloof ]

            Unassigned Unassigned
            ndeloof Nicolas De Loof
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: