Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-11513

Textbox for numbers should be type=number

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      Jenkins has sevral textboxes to input numbers,
      for instance, "# of executors" and "Days to keep builds".
      These input elements are currently <input type="text" />.
      If they are <input type="number" />, modern browsers will provide a better UI.

        Attachments

          Activity

          ohtake_tomohiro OHTAKE Tomohiro created issue -
          ohtake_tomohiro OHTAKE Tomohiro made changes -
          Field Original Value New Value
          Status Open [ 1 ] In Progress [ 3 ]
          Hide
          ohtake_tomohiro OHTAKE Tomohiro added a comment -
          Show
          ohtake_tomohiro OHTAKE Tomohiro added a comment - I have requested a pull. https://github.com/jenkinsci/jenkins/pull/298
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: OHTAKE Tomohiro
          Path:
          core/src/main/resources/lib/form/number.jelly
          http://jenkins-ci.org/commit/jenkins/fd7b09cf4be5745ce85ed689928b07753cd687da
          Log:
          [FIXED JENKINS-11513] Add f:number for <input type="number />

          • Based on textbox.jelly
            • Attributes removed: autoCompleteField, autoCompleteDelimChar
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: OHTAKE Tomohiro Path: core/src/main/resources/lib/form/number.jelly http://jenkins-ci.org/commit/jenkins/fd7b09cf4be5745ce85ed689928b07753cd687da Log: [FIXED JENKINS-11513] Add f:number for <input type="number /> Based on textbox.jelly Attributes removed: autoCompleteField, autoCompleteDelimChar
          scm_issue_link SCM/JIRA link daemon made changes -
          Resolution Fixed [ 1 ]
          Status In Progress [ 3 ] Resolved [ 5 ]
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: OHTAKE Tomohiro
          Path:
          war/src/main/webapp/scripts/hudson-behavior.js
          http://jenkins-ci.org/commit/jenkins/597a7ddc0f85ea12d842e0ba23ab942ec1312a1a
          Log:
          JENKINS-11513 Change error message from 'number' to 'integer'

          • hudson-behavior.js checks if value of INPUT.number is an integer
          • HTML5 <input type=number> checks if value of INPUT is a number (including floating point)
          • It's better to change error message for INPUT.number to 'integer'
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: OHTAKE Tomohiro Path: war/src/main/webapp/scripts/hudson-behavior.js http://jenkins-ci.org/commit/jenkins/597a7ddc0f85ea12d842e0ba23ab942ec1312a1a Log: JENKINS-11513 Change error message from 'number' to 'integer' hudson-behavior.js checks if value of INPUT.number is an integer HTML5 <input type=number> checks if value of INPUT is a number (including floating point) It's better to change error message for INPUT.number to 'integer'
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: OHTAKE Tomohiro
          Path:
          core/src/main/resources/hudson/PluginManager/advanced.jelly
          core/src/main/resources/hudson/slaves/DumbSlave/configure-entries.jelly
          core/src/main/resources/hudson/slaves/RetentionStrategy/Demand/config.jelly
          core/src/main/resources/hudson/slaves/SimpleScheduledRetentionStrategy/config.jelly
          core/src/main/resources/hudson/tasks/LogRotator/config.jelly
          core/src/main/resources/hudson/triggers/SCMTrigger/global.jelly
          core/src/main/resources/jenkins/model/GlobalQuietPeriodConfiguration/config.groovy
          core/src/main/resources/jenkins/model/GlobalSCMRetryCountConfiguration/config.groovy
          core/src/main/resources/jenkins/model/MasterBuildConfiguration/config.groovy
          core/src/main/resources/lib/hudson/project/config-quietPeriod.jelly
          core/src/main/resources/lib/hudson/project/config-retryCount.jelly
          http://jenkins-ci.org/commit/jenkins/8067940aadfe8dc73b5e166b7f4b0fc5be504468
          Log:
          JENKINS-11513 Change f:textbox to f:number

          • Add min, max, step and clazz attributes if appropriate
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: OHTAKE Tomohiro Path: core/src/main/resources/hudson/PluginManager/advanced.jelly core/src/main/resources/hudson/slaves/DumbSlave/configure-entries.jelly core/src/main/resources/hudson/slaves/RetentionStrategy/Demand/config.jelly core/src/main/resources/hudson/slaves/SimpleScheduledRetentionStrategy/config.jelly core/src/main/resources/hudson/tasks/LogRotator/config.jelly core/src/main/resources/hudson/triggers/SCMTrigger/global.jelly core/src/main/resources/jenkins/model/GlobalQuietPeriodConfiguration/config.groovy core/src/main/resources/jenkins/model/GlobalSCMRetryCountConfiguration/config.groovy core/src/main/resources/jenkins/model/MasterBuildConfiguration/config.groovy core/src/main/resources/lib/hudson/project/config-quietPeriod.jelly core/src/main/resources/lib/hudson/project/config-retryCount.jelly http://jenkins-ci.org/commit/jenkins/8067940aadfe8dc73b5e166b7f4b0fc5be504468 Log: JENKINS-11513 Change f:textbox to f:number Add min, max, step and clazz attributes if appropriate
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: OHTAKE Tomohiro
          Path:
          core/src/main/resources/hudson/security/GlobalSecurityConfiguration/config.groovy
          http://jenkins-ci.org/commit/jenkins/a6af173ff8448b8c61ffe46a6c61a53411b7fe29
          Log:
          JENKINS-11513 type=number for "TCP port for JNLP slave agents"

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: OHTAKE Tomohiro Path: core/src/main/resources/hudson/security/GlobalSecurityConfiguration/config.groovy http://jenkins-ci.org/commit/jenkins/a6af173ff8448b8c61ffe46a6c61a53411b7fe29 Log: JENKINS-11513 type=number for "TCP port for JNLP slave agents"
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          changelog.html
          http://jenkins-ci.org/commit/jenkins/117ed693f1d8bed874e418659848cea5c5b1beac
          Log:
          [FIXED JENKINS-11513] recording the past 5 changes

          Compare: https://github.com/jenkinsci/jenkins/compare/92496f9...117ed69

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html http://jenkins-ci.org/commit/jenkins/117ed693f1d8bed874e418659848cea5c5b1beac Log: [FIXED JENKINS-11513] recording the past 5 changes Compare: https://github.com/jenkinsci/jenkins/compare/92496f9...117ed69
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #1271
          [FIXED JENKINS-11513] Add f:number for <input type="number />
          JENKINS-11513 Change error message from 'number' to 'integer'
          JENKINS-11513 Change f:textbox to f:number
          JENKINS-11513 type=number for "TCP port for JNLP slave agents"
          [FIXED JENKINS-11513] recording the past 5 changes

          Kohsuke Kawaguchi : fd7b09cf4be5745ce85ed689928b07753cd687da
          Files :

          • core/src/main/resources/lib/form/number.jelly

          Kohsuke Kawaguchi : 597a7ddc0f85ea12d842e0ba23ab942ec1312a1a
          Files :

          • war/src/main/webapp/scripts/hudson-behavior.js

          Kohsuke Kawaguchi : 8067940aadfe8dc73b5e166b7f4b0fc5be504468
          Files :

          • core/src/main/resources/hudson/slaves/SimpleScheduledRetentionStrategy/config.jelly
          • core/src/main/resources/jenkins/model/GlobalQuietPeriodConfiguration/config.groovy
          • core/src/main/resources/hudson/triggers/SCMTrigger/global.jelly
          • core/src/main/resources/hudson/PluginManager/advanced.jelly
          • core/src/main/resources/jenkins/model/MasterBuildConfiguration/config.groovy
          • core/src/main/resources/hudson/slaves/RetentionStrategy/Demand/config.jelly
          • core/src/main/resources/lib/hudson/project/config-quietPeriod.jelly
          • core/src/main/resources/hudson/slaves/DumbSlave/configure-entries.jelly
          • core/src/main/resources/lib/hudson/project/config-retryCount.jelly
          • core/src/main/resources/jenkins/model/GlobalSCMRetryCountConfiguration/config.groovy
          • core/src/main/resources/hudson/tasks/LogRotator/config.jelly

          Kohsuke Kawaguchi : a6af173ff8448b8c61ffe46a6c61a53411b7fe29
          Files :

          • core/src/main/resources/hudson/security/GlobalSecurityConfiguration/config.groovy

          Kohsuke Kawaguchi : 117ed693f1d8bed874e418659848cea5c5b1beac
          Files :

          • changelog.html
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #1271 [FIXED JENKINS-11513] Add f:number for <input type="number /> JENKINS-11513 Change error message from 'number' to 'integer' JENKINS-11513 Change f:textbox to f:number JENKINS-11513 type=number for "TCP port for JNLP slave agents" [FIXED JENKINS-11513] recording the past 5 changes Kohsuke Kawaguchi : fd7b09cf4be5745ce85ed689928b07753cd687da Files : core/src/main/resources/lib/form/number.jelly Kohsuke Kawaguchi : 597a7ddc0f85ea12d842e0ba23ab942ec1312a1a Files : war/src/main/webapp/scripts/hudson-behavior.js Kohsuke Kawaguchi : 8067940aadfe8dc73b5e166b7f4b0fc5be504468 Files : core/src/main/resources/hudson/slaves/SimpleScheduledRetentionStrategy/config.jelly core/src/main/resources/jenkins/model/GlobalQuietPeriodConfiguration/config.groovy core/src/main/resources/hudson/triggers/SCMTrigger/global.jelly core/src/main/resources/hudson/PluginManager/advanced.jelly core/src/main/resources/jenkins/model/MasterBuildConfiguration/config.groovy core/src/main/resources/hudson/slaves/RetentionStrategy/Demand/config.jelly core/src/main/resources/lib/hudson/project/config-quietPeriod.jelly core/src/main/resources/hudson/slaves/DumbSlave/configure-entries.jelly core/src/main/resources/lib/hudson/project/config-retryCount.jelly core/src/main/resources/jenkins/model/GlobalSCMRetryCountConfiguration/config.groovy core/src/main/resources/hudson/tasks/LogRotator/config.jelly Kohsuke Kawaguchi : a6af173ff8448b8c61ffe46a6c61a53411b7fe29 Files : core/src/main/resources/hudson/security/GlobalSecurityConfiguration/config.groovy Kohsuke Kawaguchi : 117ed693f1d8bed874e418659848cea5c5b1beac Files : changelog.html
          ohtake_tomohiro OHTAKE Tomohiro made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          ircbot Jenkins IRC Bot made changes -
          Component/s core [ 15593 ]
          Component/s gui [ 15492 ]
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 141740 ] JNJira + In-Review [ 205426 ]

            People

            Assignee:
            ohtake_tomohiro OHTAKE Tomohiro
            Reporter:
            ohtake_tomohiro OHTAKE Tomohiro
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: