Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-11519

When chosing "Execute concurrent builds if necessary" extra workspaces created should use a different character than '@'

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Not A Defect
    • Icon: Blocker Blocker
    • core
    • None

      *strong text*When choosing in build setting the option Execute concurrent builds if necessary, if a build is executed while another build is running, the second workspace created as workspace@2.
      The use of '@' character is not so good as it is sometimes used as a meta-character in scripts.
      For example, I had a problem when my script was trying to run sqlplus command where @ is used.

      Consider changing '@' character with '_' or simply just using workspace2 with no character in between.

          [JENKINS-11519] When chosing "Execute concurrent builds if necessary" extra workspaces created should use a different character than '@'

          michael d created issue -
          michael d made changes -
          Priority Original: Minor [ 4 ] New: Major [ 3 ]

          michael d added a comment -

          If this is not going to be changed, is there any way to change it manually in a conf file somehow ?

          michael d added a comment - If this is not going to be changed, is there any way to change it manually in a conf file somehow ?

          ejschuiteman added a comment -

          Hopefully this can be solved very quick. Workspace_ or workspace2 would be good.

          ejschuiteman added a comment - Hopefully this can be solved very quick. Workspace_ or workspace2 would be good.
          ejschuiteman made changes -
          Priority Original: Major [ 3 ] New: Critical [ 2 ]
          ejschuiteman made changes -
          Priority Original: Critical [ 2 ] New: Blocker [ 1 ]

          Axel Heider added a comment -

          Yes, please choose a differen char.

          Axel Heider added a comment - Yes, please choose a differen char.

          michael d added a comment - - edited

          I think the change needed to be done in class WorkspaceList : 

           
/**
     * The token that combines the project name and unique number to create unique workspace directory.
     */
    private static final String COMBINATOR = System.getProperty(WorkspaceList.class.getName(),"@");

          michael d added a comment - - edited I think the change needed to be done in class WorkspaceList : /** * The token that combines the project name and unique number to create unique workspace directory. */ private static final String COMBINATOR = System .getProperty(WorkspaceList. class. getName(), "@" );

          Christopher Orr added a comment -

          For reference:
          https://wiki.jenkins-ci.org/display/JENKINS/Features+controlled+by+system+properties

          Christopher Orr added a comment - For reference: https://wiki.jenkins-ci.org/display/JENKINS/Features+controlled+by+system+properties

          michael d added a comment - - edited

          According to darkrift on IRC, the workaround is this :
          You need to add a -D parameter to the startup of jenkins : -Dhudson.slaves.WorkspaceList=! (to change it to ! for example)

          michael d added a comment - - edited According to darkrift on IRC, the workaround is this : You need to add a -D parameter to the startup of jenkins : -Dhudson.slaves.WorkspaceList=! (to change it to ! for example)

            Unassigned Unassigned
            miked michael d
            Votes:
            4 Vote for this issue
            Watchers:
            10 Start watching this issue

              Created:
              Updated:
              Resolved: