-
New Feature
-
Resolution: Unresolved
-
Major
-
None
email-ext looks for getDate getTimestamp and getRevision getCommitId methods using reflection when retrieving changelog information. Currently the perforce plugin does not implement these methods, so the date and change number are not available.
[JENKINS-11600] Implement Entry functions for email-ext support
Integrated in 
plugins_perforce #149
[FIXED JENKINS-11600] added getDate and getRevision implementations to ChangeLogSet.Entry
Rob Petti :
Files :
- src/main/java/hudson/plugins/perforce/PerforceChangeLogEntry.java
Walter Couto
added a comment - Jenkins ver. 1.544, Perforce Plugin 1.3.26
The Following token used in email-ext plugin displays null for revision and invalid date for date:
${CHANGES, format="%r by %a on %d\n%m"}
null by user on Jan 1, 1970 1:59:59 AM
description
This was working fine in a pervious version of the plugin.
Walter Couto
added a comment - Jenkins ver. 1.544, Perforce Plugin 1.3.26
The Following token used in email-ext plugin displays null for revision and invalid date for date:
${CHANGES, format="%r by %a on %d\n%m"}
null by user on Jan 1, 1970 1:59:59 AM
description
This was working fine in a pervious version of the plugin. What version was this last working in? As far as I can tell, this code has not changed.
I have double checked. The functions requested in this ticket are still implemented.
Walter Couto
added a comment - I can't tell the version as it is not reported in the emails, but it stopped working for us on October 30th, 2013. So recently. We keep up to date with the latest Jenkins and plugins. Our P4 server version hasn't changed between those dates.
Walter Couto
added a comment - I can't tell the version as it is not reported in the emails, but it stopped working for us on October 30th, 2013. So recently. We keep up to date with the latest Jenkins and plugins. Our P4 server version hasn't changed between those dates. I'd recommend rolling back to see if it fixes your issue. As I've said, this doesn't appear to be an issue with the Perforce Plugin.
Nik San
added a comment - Any ideas on this or what version of Jenkins we should go back to? I'm a newcomer so unable to have ever seen it working (last two weeks) but am also seeing the null for revision.
Cheers.
Nik San
added a comment - Any ideas on this or what version of Jenkins we should go back to? I'm a newcomer so unable to have ever seen it working (last two weeks) but am also seeing the null for revision.
Cheers. Email-ext has changed something on their end. It seems they are now using Entry.getTimestamp and Entry.getCommitId instead of getDate and getRevision like they were previously... The perforce plugin will need these two new functions implemented.
Nik San
added a comment - Nice one Rob. Also, probably not the place but thanks for a great plugin. Nik San
added a comment - My first time using github and everything in relation to developing jenkins plugins, but I have a pull request for this.
Nik San
added a comment - My first time using github and everything in relation to developing jenkins plugins, but I have a pull request for this.
https://github.com/jenkinsci/perforce-plugin/pull/49 ChangeLogSet.Entry didn't have those methods and I didn't want to use reflection anymore. I missed checking perforce when I looked at the different SCM implementations. Apologies for the issue the change caused.
Code changed in jenkins
User: Paul Tankard
Path:
src/main/java/hudson/plugins/perforce/PerforceChangeLogEntry.java
http://jenkins-ci.org/commit/perforce-plugin/fda9b707c2fcc4afff0a37c6d83aa23451b6d3ca
Log:
Fix for JENKINS-11600, email-ext now queries getTimestamp and getCommitId
Code changed in jenkins
User: Rob Petti
Path:
src/main/java/hudson/plugins/perforce/PerforceChangeLogEntry.java
http://jenkins-ci.org/commit/perforce-plugin/e49e9cb874d9536210aa9c90119c96ce50a1ad82
Log:
Merge pull request #49 from HexTank/master
Fix for JENKINS-11600, email-ext now queries getTimestamp and getCommite...
Compare: https://github.com/jenkinsci/perforce-plugin/compare/2da2bf91851f...e49e9cb874d9
Code changed in jenkins
User: Rob Petti
Path:
src/main/java/hudson/plugins/perforce/PerforceChangeLogEntry.java
http://jenkins-ci.org/commit/perforce-plugin/1face9d522c9886ec0328b24e72bf97a2b782216
Log:
[FIXED JENKINS-11600] added getDate and getRevision implementations to ChangeLogSet.Entry