Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-11600

Implement Entry functions for email-ext support

XMLWordPrintable

    • Icon: New Feature New Feature
    • Resolution: Unresolved
    • Icon: Major Major
    • p4-plugin
    • None

      email-ext looks for getDate getTimestamp and getRevision getCommitId methods using reflection when retrieving changelog information. Currently the perforce plugin does not implement these methods, so the date and change number are not available.

          [JENKINS-11600] Implement Entry functions for email-ext support

          Rob Petti created issue -

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Rob Petti
          Path:
          src/main/java/hudson/plugins/perforce/PerforceChangeLogEntry.java
          http://jenkins-ci.org/commit/perforce-plugin/1face9d522c9886ec0328b24e72bf97a2b782216
          Log:
          [FIXED JENKINS-11600] added getDate and getRevision implementations to ChangeLogSet.Entry

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Rob Petti Path: src/main/java/hudson/plugins/perforce/PerforceChangeLogEntry.java http://jenkins-ci.org/commit/perforce-plugin/1face9d522c9886ec0328b24e72bf97a2b782216 Log: [FIXED JENKINS-11600] added getDate and getRevision implementations to ChangeLogSet.Entry
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]

          dogfood added a comment -

          Integrated in plugins_perforce #149
          [FIXED JENKINS-11600] added getDate and getRevision implementations to ChangeLogSet.Entry

          Rob Petti :
          Files :

          • src/main/java/hudson/plugins/perforce/PerforceChangeLogEntry.java

          dogfood added a comment - Integrated in plugins_perforce #149 [FIXED JENKINS-11600] added getDate and getRevision implementations to ChangeLogSet.Entry Rob Petti : Files : src/main/java/hudson/plugins/perforce/PerforceChangeLogEntry.java

          Walter Couto added a comment -

          Jenkins ver. 1.544, Perforce Plugin 1.3.26

          The Following token used in email-ext plugin displays null for revision and invalid date for date:

          ${CHANGES, format="%r by %a on %d\n%m"}

          null by user on Jan 1, 1970 1:59:59 AM
          description

          This was working fine in a pervious version of the plugin.

          Walter Couto added a comment - Jenkins ver. 1.544, Perforce Plugin 1.3.26 The Following token used in email-ext plugin displays null for revision and invalid date for date: ${CHANGES, format="%r by %a on %d\n%m"} null by user on Jan 1, 1970 1:59:59 AM description This was working fine in a pervious version of the plugin.
          Walter Couto made changes -
          Resolution Original: Fixed [ 1 ]
          Status Original: Resolved [ 5 ] New: Reopened [ 4 ]

          Rob Petti added a comment -

          What version was this last working in? As far as I can tell, this code has not changed.

          Rob Petti added a comment - What version was this last working in? As far as I can tell, this code has not changed.

          Rob Petti added a comment -

          I have double checked. The functions requested in this ticket are still implemented.

          https://github.com/jenkinsci/perforce-plugin/blob/master/src/main/java/hudson/plugins/perforce/PerforceChangeLogEntry.java

          Rob Petti added a comment - I have double checked. The functions requested in this ticket are still implemented. https://github.com/jenkinsci/perforce-plugin/blob/master/src/main/java/hudson/plugins/perforce/PerforceChangeLogEntry.java

          Walter Couto added a comment -

          I can't tell the version as it is not reported in the emails, but it stopped working for us on October 30th, 2013. So recently. We keep up to date with the latest Jenkins and plugins. Our P4 server version hasn't changed between those dates.

          Walter Couto added a comment - I can't tell the version as it is not reported in the emails, but it stopped working for us on October 30th, 2013. So recently. We keep up to date with the latest Jenkins and plugins. Our P4 server version hasn't changed between those dates.

          Rob Petti added a comment -

          I'd recommend rolling back to see if it fixes your issue. As I've said, this doesn't appear to be an issue with the Perforce Plugin.

          Rob Petti added a comment - I'd recommend rolling back to see if it fixes your issue. As I've said, this doesn't appear to be an issue with the Perforce Plugin.

            Unassigned Unassigned
            rpetti Rob Petti
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated: