• Icon: New Feature New Feature
    • Resolution: Fixed
    • Icon: Major Major
    • ircbot-plugin
    • None

      As it was pointed out in https://issues.jenkins-ci.org/browse/JENKINS-5931 there is no option for restricting who can access what command, which can be a problem from the access control POV.
      I would suggest a more simpler solution: having the ability to disable the whole irc command interface, this way the irc notification can still be used without allowing unauthorized access to random people.
      I think this would be really easy to implement, and it would be a good-enough solution for most people.

          [JENKINS-11606] configuration option for disabling the commands

          Ferenc Kovacs created issue -
          kutzi made changes -
          Link New: This issue is related to JENKINS-10827 [ JENKINS-10827 ]
          kutzi made changes -
          Link New: This issue is related to JENKINS-5913 [ JENKINS-5913 ]
          kutzi made changes -
          Link Original: This issue is related to JENKINS-5913 [ JENKINS-5913 ]
          kutzi made changes -
          Link New: This issue is related to JENKINS-5931 [ JENKINS-5931 ]

          kutzi added a comment -

          I like the idea

          kutzi added a comment - I like the idea

          Code changed in jenkins
          User: Christoph Kutzinski
          Path:
          src/main/java/hudson/plugins/im/GroupChatIMMessageTarget.java
          src/main/java/hudson/plugins/im/IMChat.java
          src/main/java/hudson/plugins/im/bot/Bot.java
          http://jenkins-ci.org/commit/instant-messaging-plugin/a531942907f9fd2615a029092b27ebf154b57812
          Log:
          [FIXED JENKINS-11606]: configuration option to disable commands in chat rooms

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: src/main/java/hudson/plugins/im/GroupChatIMMessageTarget.java src/main/java/hudson/plugins/im/IMChat.java src/main/java/hudson/plugins/im/bot/Bot.java http://jenkins-ci.org/commit/instant-messaging-plugin/a531942907f9fd2615a029092b27ebf154b57812 Log: [FIXED JENKINS-11606] : configuration option to disable commands in chat rooms
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]

          Code changed in jenkins
          User: Christoph Kutzinski
          Path:
          src/main/java/hudson/plugins/ircbot/IrcPublisher.java
          src/main/java/hudson/plugins/ircbot/v2/IRCChannel.java
          src/main/java/hudson/plugins/ircbot/v2/IRCConnection.java
          src/main/java/hudson/plugins/ircbot/v2/IRCPrivateChat.java
          src/main/resources/hudson/plugins/ircbot/IrcPublisher/config.jelly
          src/main/resources/hudson/plugins/ircbot/IrcPublisher/global.jelly
          http://jenkins-ci.org/commit/ircbot-plugin/ee5e974566395c01da714bec39e64ce515124b87
          Log:
          [FIXED JENKINS-11606]: configuration option to disable commands in chat rooms

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: src/main/java/hudson/plugins/ircbot/IrcPublisher.java src/main/java/hudson/plugins/ircbot/v2/IRCChannel.java src/main/java/hudson/plugins/ircbot/v2/IRCConnection.java src/main/java/hudson/plugins/ircbot/v2/IRCPrivateChat.java src/main/resources/hudson/plugins/ircbot/IrcPublisher/config.jelly src/main/resources/hudson/plugins/ircbot/IrcPublisher/global.jelly http://jenkins-ci.org/commit/ircbot-plugin/ee5e974566395c01da714bec39e64ce515124b87 Log: [FIXED JENKINS-11606] : configuration option to disable commands in chat rooms

          Code changed in jenkins
          User: Christoph Kutzinski
          Path:
          src/main/java/hudson/plugins/jabber/im/transport/JabberChat.java
          src/main/java/hudson/plugins/jabber/im/transport/JabberIMConnection.java
          src/main/java/hudson/plugins/jabber/im/transport/JabberMultiUserChat.java
          src/main/java/hudson/plugins/jabber/im/transport/JabberPublisherDescriptor.java
          src/main/resources/hudson/plugins/jabber/im/transport/JabberPublisher/global.jelly
          http://jenkins-ci.org/commit/jabber-plugin/f2ec60677324aafe38ca8a1568cf8ff3b297d354
          Log:
          [FIXED JENKINS-11606]: configuration option to disable commands in chat rooms

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: src/main/java/hudson/plugins/jabber/im/transport/JabberChat.java src/main/java/hudson/plugins/jabber/im/transport/JabberIMConnection.java src/main/java/hudson/plugins/jabber/im/transport/JabberMultiUserChat.java src/main/java/hudson/plugins/jabber/im/transport/JabberPublisherDescriptor.java src/main/resources/hudson/plugins/jabber/im/transport/JabberPublisher/global.jelly http://jenkins-ci.org/commit/jabber-plugin/f2ec60677324aafe38ca8a1568cf8ff3b297d354 Log: [FIXED JENKINS-11606] : configuration option to disable commands in chat rooms

            kutzi kutzi
            tyrael Ferenc Kovacs
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: