"Default Recipients" input field remains empty after saving.
      (Jenkins>Manage Jenkins>Configure System)

          [JENKINS-11665] email-ext: cannot save "Default Recipients"

          Bruno Marti added a comment -

          screen shot before saving input

          Bruno Marti added a comment - screen shot before saving input

          Bruno Marti added a comment -

          screenshot after saving

          Bruno Marti added a comment - screenshot after saving

          just for info - reverted back to 2.15 and all is working.

          Spencer Oliver added a comment - just for info - reverted back to 2.15 and all is working.

          kutzi added a comment -

          kutzi added a comment - I guess this has been cause by https://github.com/jenkinsci/email-ext-plugin/commit/e03015739c3161d173dbe48c2842f3d5b3590743

          Alex Earl added a comment -

          No, I don't think that's the cause. That commit is just reverting an earlier feature addition. I'll double check this, but the testing I did did not have this issue. To be honest, 2.16 probably should not have been released without more testing from the community. It was done as part of an overall Jenkins release.

          Alex Earl added a comment - No, I don't think that's the cause. That commit is just reverting an earlier feature addition. I'll double check this, but the testing I did did not have this issue. To be honest, 2.16 probably should not have been released without more testing from the community. It was done as part of an overall Jenkins release.

          Alex Earl added a comment -

          I misunderstood when I first looked at this issue. The global default recipients is no longer supported. Please use an environment variable and the ${ENV} token to do what it did. The global default recipients list caused issues in other places. The global default recipients field should be removed from global config and will be as soon as possible.

          Alex Earl added a comment - I misunderstood when I first looked at this issue. The global default recipients is no longer supported. Please use an environment variable and the ${ENV} token to do what it did. The global default recipients list caused issues in other places. The global default recipients field should be removed from global config and will be as soon as possible.

          Dennis Lundberg added a comment - - edited

          Why is Recipients any different from Subject or Content. This is an extremely important feature to have in a large Jenkins installation with a lot of projects. Having to set the recipients in each project is both tedious and error prone.

          How can using an ENV variable cause less issues than a separate configuration parameter?

          If you are serious about removing this feature, then five things need to happen ASAP:
          1. Remove the "Global Recipient List" documentation from the Wiki page
          2. Document in a very prominent way in the changelog on the Wiki page that this feature has been removed
          3. Document on the Wiki page how to convert from using "Default Recipients" to using an ENV
          4. Remove the "Default Recipients" input field in the Manage Jenkins user interface
          5. Release a new version of the plugin, which include these fixes

          Is there anything we can do to make you change your mind about this, to help creating patches or to help with testing?

          Dennis Lundberg added a comment - - edited Why is Recipients any different from Subject or Content. This is an extremely important feature to have in a large Jenkins installation with a lot of projects. Having to set the recipients in each project is both tedious and error prone. How can using an ENV variable cause less issues than a separate configuration parameter? If you are serious about removing this feature, then five things need to happen ASAP: 1. Remove the "Global Recipient List" documentation from the Wiki page 2. Document in a very prominent way in the changelog on the Wiki page that this feature has been removed 3. Document on the Wiki page how to convert from using "Default Recipients" to using an ENV 4. Remove the "Default Recipients" input field in the Manage Jenkins user interface 5. Release a new version of the plugin, which include these fixes Is there anything we can do to make you change your mind about this, to help creating patches or to help with testing?

          Heleno Valle added a comment -

          I'm totally with Dennis! o/

          Heleno Valle added a comment - I'm totally with Dennis! o/

          Alex Earl added a comment -

          Sure, feel free to submit patches. I think the main issue is with PROJECT_DEFAULT_RECIPIENTS in the triggers. Perhaps not adding it by default would be a good solution. For patches you'd want to start with the 2.15 branch.

          Alex Earl added a comment - Sure, feel free to submit patches. I think the main issue is with PROJECT_DEFAULT_RECIPIENTS in the triggers. Perhaps not adding it by default would be a good solution. For patches you'd want to start with the 2.15 branch.

          Alex Earl added a comment -

          There is still a fairly large interest in this feature. Will revisit.

          Alex Earl added a comment - There is still a fairly large interest in this feature. Will revisit.

          Evan Brodie added a comment -

          I've submitted a very similar issue regarding DEFAULT_RECIPIENTS in the email-ext plugin:
          https://issues.jenkins-ci.org/browse/JENKINS-11940

          Yes, this issue indeed has large interest.

          Evan Brodie added a comment - I've submitted a very similar issue regarding DEFAULT_RECIPIENTS in the email-ext plugin: https://issues.jenkins-ci.org/browse/JENKINS-11940 Yes, this issue indeed has large interest.

          Alex Earl added a comment -

          Please try forking this repo and building, it should revert all removal of the DEFAULT_RECIPIENTS from head. https://github.com/slide/email-ext-plugin

          You can issue pull requests if you see anything amiss.

          Alex Earl added a comment - Please try forking this repo and building, it should revert all removal of the DEFAULT_RECIPIENTS from head. https://github.com/slide/email-ext-plugin You can issue pull requests if you see anything amiss.

          Evan Brodie added a comment -

          Will this remain as a fork of email-ext or will the re-implementation of DEFAULT_RECIPIENTS be added to the next release of the plugin?

          Evan Brodie added a comment - Will this remain as a fork of email-ext or will the re-implementation of DEFAULT_RECIPIENTS be added to the next release of the plugin?

          Alex Earl added a comment -

          The goal of this is to get it tested/fixed prior to merging with mailine and getting a release.

          Alex Earl added a comment - The goal of this is to get it tested/fixed prior to merging with mailine and getting a release.

          Tym Pollack added a comment -

          Any word on if this issue will be fixed in an upcoming release?

          Tym Pollack added a comment - Any word on if this issue will be fixed in an upcoming release?

          Alex Earl added a comment -

          That is the goal, I have a version I am testing currently.

          Alex Earl added a comment - That is the goal, I have a version I am testing currently.

          Tym Pollack added a comment -

          Appreciate the update. Just took over someone else's installation and am new to jenkins administration. Reverted back to 2.15 for now since that seems to work (they were only on 2.16 anyway).

          Tym Pollack added a comment - Appreciate the update. Just took over someone else's installation and am new to jenkins administration. Reverted back to 2.15 for now since that seems to work (they were only on 2.16 anyway).

          How can I find the 2.15 build? All I see is the source on github.

          Walter Kacynski added a comment - How can I find the 2.15 build? All I see is the source on github.

          Alex Earl added a comment -

          Does anyone have a config.xml for a job that was from before the default recipients was added (pre 2.14). I would like to add some tests for upgrading to make sure nothing gets broken.

          Alex Earl added a comment - Does anyone have a config.xml for a job that was from before the default recipients was added (pre 2.14). I would like to add some tests for upgrading to make sure nothing gets broken.

          Code changed in jenkins
          User: slide
          Path:
          src/main/java/hudson/plugins/emailext/EmailExtensionPlugin.java
          src/main/java/hudson/plugins/emailext/EmailRecepientUtils.java
          src/main/java/hudson/plugins/emailext/EmailType.java
          src/main/java/hudson/plugins/emailext/ExtendedEmailPublisher.java
          src/main/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptor.java
          src/main/java/hudson/plugins/emailext/plugins/ContentBuilder.java
          src/main/resources/hudson/plugins/emailext/ExtendedEmailPublisher/config.jelly
          src/test/java/hudson/plugins/emailext/ExtendedEmailPublisherTest.java
          src/test/java/hudson/plugins/emailext/plugins/ContentBuilderTest.java
          http://jenkins-ci.org/commit/email-ext-plugin/09296a6d5e321ea6a553b0ff1de58a6b165d13c7
          Log:
          Merge pull request #27 from slide/master

          Fix JENKINS-11683, JENKINS-1144, JENKINS-11665

          Compare: https://github.com/jenkinsci/email-ext-plugin/compare/3789acf...09296a6

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: slide Path: src/main/java/hudson/plugins/emailext/EmailExtensionPlugin.java src/main/java/hudson/plugins/emailext/EmailRecepientUtils.java src/main/java/hudson/plugins/emailext/EmailType.java src/main/java/hudson/plugins/emailext/ExtendedEmailPublisher.java src/main/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptor.java src/main/java/hudson/plugins/emailext/plugins/ContentBuilder.java src/main/resources/hudson/plugins/emailext/ExtendedEmailPublisher/config.jelly src/test/java/hudson/plugins/emailext/ExtendedEmailPublisherTest.java src/test/java/hudson/plugins/emailext/plugins/ContentBuilderTest.java http://jenkins-ci.org/commit/email-ext-plugin/09296a6d5e321ea6a553b0ff1de58a6b165d13c7 Log: Merge pull request #27 from slide/master Fix JENKINS-11683 , JENKINS-1144 , JENKINS-11665 Compare: https://github.com/jenkinsci/email-ext-plugin/compare/3789acf...09296a6

          Alex Earl added a comment -

          Fixed in 09296a6

          Alex Earl added a comment - Fixed in 09296a6

          Derek E added a comment -

          I'm a bit confused. Did this get released? If so, in what fix version? I'm not seeing any references to this in any of the change logs.

          Derek E added a comment - I'm a bit confused. Did this get released? If so, in what fix version? I'm not seeing any references to this in any of the change logs.

          Alex Earl added a comment -

          Yes, it did get fixed in 2.19. I missed putting it into the changelog.

          Alex Earl added a comment - Yes, it did get fixed in 2.19. I missed putting it into the changelog.

            slide_o_mix Alex Earl
            mbr Bruno Marti
            Votes:
            3 Vote for this issue
            Watchers:
            9 Start watching this issue

              Created:
              Updated:
              Resolved: