Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-11907

scripttrigger doesn't close file

    XMLWordPrintable

Details

    Description

      I've had Jenkins hanging. My current best guess is that scripttrigger doesn't close some files explicitly and the GC doing it isn't run often enough to take care of it.

      • Running lsof on the process shows several times the same files opened, files named scriptTrigger-polling.log in job directory for jobs having a script triggers. The number of files opened increase apparently by one each time the trigger is run.

      I'm running version 1.440.

      If you need more information, don't hesitate to ask.

      — Edit —

      I think my guess is confirmed. I've just had Jenkins hanging again and

      % lsof -p <jenkinspid> | grep "scriptTrigger-polling.log" | wc -l
      769

      Trying to load http://myserver/gc has no effect (the server doesn't answer)

      Thanks.

      Attachments

        Activity

          bourguet Jean-Marc Bourguet created issue -
          bourguet Jean-Marc Bourguet made changes -
          Field Original Value New Value
          Description I've had Jenkins hanging. My current best guess is that scripttrigger doesn't close some files explicitly and the GC doing it isn't run often enough to take care of it.

          - Running lsof on the process shows several times the same files opened, files named scriptTrigger-polling.log in job directory for jobs having a script triggers. The number of files opened increase apparently by one each time the trigger is run.

          - If I load http://myserver/gc, the additional opened files disappear.

          If you need more information, don't hesitate to ask.

          Thanks.
          I've had Jenkins hanging. My current best guess is that scripttrigger doesn't close some files explicitly and the GC doing it isn't run often enough to take care of it.

          - Running lsof on the process shows several times the same files opened, files named scriptTrigger-polling.log in job directory for jobs having a script triggers. The number of files opened increase apparently by one each time the trigger is run.

          - If I load http://myserver/gc, the additional opened files disappear.

          I'm running version 1.440.

          If you need more information, don't hesitate to ask.

          Thanks.
          bourguet Jean-Marc Bourguet made changes -
          Description I've had Jenkins hanging. My current best guess is that scripttrigger doesn't close some files explicitly and the GC doing it isn't run often enough to take care of it.

          - Running lsof on the process shows several times the same files opened, files named scriptTrigger-polling.log in job directory for jobs having a script triggers. The number of files opened increase apparently by one each time the trigger is run.

          - If I load http://myserver/gc, the additional opened files disappear.

          I'm running version 1.440.

          If you need more information, don't hesitate to ask.

          Thanks.
          I've had Jenkins hanging. My current best guess is that scripttrigger doesn't close some files explicitly and the GC doing it isn't run often enough to take care of it.

          - Running lsof on the process shows several times the same files opened, files named scriptTrigger-polling.log in job directory for jobs having a script triggers. The number of files opened increase apparently by one each time the trigger is run.

          - If I load http://myserver/gc, the additional opened files disappear.

          I'm running version 1.440.

          If you need more information, don't hesitate to ask.

          --- Edit ---

          I think my guess is confirmed. I've just had Jenkins hanging again and

          % lsof -p <jenkinspid> | grep "scriptTrigger-polling.log" | wc -l
          769

          Trying to load http://myserver/gc has no effect (the server doesn't answer)

          Thanks.
          msmith Michael Smith added a comment -

          I'm seeing the same with Jenkins 1.439 and scripttrigger 0.11.1: hundreds of open file descriptors for scriptTrigger-polling.log, in write mode. In my case running the garbage collector doesn't help.

          msmith Michael Smith added a comment - I'm seeing the same with Jenkins 1.439 and scripttrigger 0.11.1: hundreds of open file descriptors for scriptTrigger-polling.log, in write mode. In my case running the garbage collector doesn't help.

          Code changed in jenkins
          User: Gregory Boissinot
          Path:
          src/main/java/org/jenkinsci/plugins/scripttrigger/AbstractTrigger.java
          src/main/java/org/jenkinsci/plugins/scripttrigger/ScriptTrigger.java
          src/main/java/org/jenkinsci/plugins/scripttrigger/ScriptTriggerExecutor.java
          src/main/java/org/jenkinsci/plugins/scripttrigger/ScriptTriggerLog.java
          src/main/java/org/jenkinsci/plugins/scripttrigger/groovy/GroovyScriptTrigger.java
          src/main/java/org/jenkinsci/plugins/scripttrigger/groovy/GroovyScriptTriggerExecutor.java
          http://jenkins-ci.org/commit/scripttrigger-plugin/d45a45f69aedbbd729c42d8e21bff8a33c0a7dba
          Log:
          Fixed JENKINS-11907

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Gregory Boissinot Path: src/main/java/org/jenkinsci/plugins/scripttrigger/AbstractTrigger.java src/main/java/org/jenkinsci/plugins/scripttrigger/ScriptTrigger.java src/main/java/org/jenkinsci/plugins/scripttrigger/ScriptTriggerExecutor.java src/main/java/org/jenkinsci/plugins/scripttrigger/ScriptTriggerLog.java src/main/java/org/jenkinsci/plugins/scripttrigger/groovy/GroovyScriptTrigger.java src/main/java/org/jenkinsci/plugins/scripttrigger/groovy/GroovyScriptTriggerExecutor.java http://jenkins-ci.org/commit/scripttrigger-plugin/d45a45f69aedbbd729c42d8e21bff8a33c0a7dba Log: Fixed JENKINS-11907

          Code changed in jenkins
          User: Gregory Boissinot
          Path:
          src/main/java/org/jenkinsci/plugins/scripttrigger/AbstractTrigger.java
          http://jenkins-ci.org/commit/scripttrigger-plugin/588fa0fea6c23fc65ad82ac2ade5065d8eaadfc2
          Log:
          Fix JENKINS-11907

          Compare: https://github.com/jenkinsci/scripttrigger-plugin/compare/dc6ccc2...588fa0f

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Gregory Boissinot Path: src/main/java/org/jenkinsci/plugins/scripttrigger/AbstractTrigger.java http://jenkins-ci.org/commit/scripttrigger-plugin/588fa0fea6c23fc65ad82ac2ade5065d8eaadfc2 Log: Fix JENKINS-11907 Compare: https://github.com/jenkinsci/scripttrigger-plugin/compare/dc6ccc2...588fa0f

          Fix available in release 0.13.
          Thank you very much for raising this issue and all of your inputs.

          gbois Gregory Boissinot added a comment - Fix available in release 0.13. Thank you very much for raising this issue and all of your inputs.
          gbois Gregory Boissinot made changes -
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]

          Thanks. I'm running version 0.13 for some hours now and lsof doesn't currently show any scriptTrigger-polling.log files.

          bourguet Jean-Marc Bourguet added a comment - Thanks. I'm running version 0.13 for some hours now and lsof doesn't currently show any scriptTrigger-polling.log files.
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 142150 ] JNJira + In-Review [ 190002 ]

          People

            gbois Gregory Boissinot
            bourguet Jean-Marc Bourguet
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: