-
Bug
-
Resolution: Fixed
-
Critical
-
None
When you have a parametrised build trigger using a build parameter to select a list of builds to trigger the following happens: 1st build after a jenkins restart works fine, while the 2nd keeps the parameter values from the 1st. (Or at least it seems so: please find details/proofs in the attachments).
Still no clue if this comes directly from this plug-in or from some other related to it or (maybe) it's a core jenkins issue (the jenkins was update really often lately plus I had new plug-ins installed/updated so it's hard identify a reason).
The "test" build I used is following:
- trigger builds from the CCC variable (non-conditional build step)
- trigger another build only if BBB is true (conditional build step)
In the 1st run I select BBB=true, CCC="TEST 2, TEST3"; and the build proceeds as expected triggers builds TEST 2 & TEST 3, and then a conditional build step.
In the 2nd run I select BBB=false, CCC="TEST 1"; and proceeds in a very weird manner it still triggers builds TEST 2 & TEST 3, like before - so I assume it somehow takes the old value for the parameter CCC, but then doesn't trigger the conditional build - so I assume it now takes the current value for the parameter BBB.
I am pretty sure it was working fine before (a few weeks ago) I have no proof for it.
[JENKINS-11922] Parametrised Build Trigger Plugin takes build params from the old build not from the current
Krzesmir Florek
created issue -
Krzesmir Florek
added a comment - Actually it doesn't seem related to the conditional build plug-in but to the Jenkins Parameterized Trigger plug-in, I'll change the component.
The reason I thought it's conditional build plug-in is that before installing it everything was working fine.
I also updated the description.
Note: the description & screen-shots still contain the conditional build plug-in but I've tested it today with out conditions configured and there's the same behaviour, if you want I can attach new/more screen-shots.
Krzesmir Florek
added a comment - Actually it doesn't seem related to the conditional build plug-in but to the Jenkins Parameterized Trigger plug-in, I'll change the component.
The reason I thought it's conditional build plug-in is that before installing it everything was working fine.
I also updated the description.
Note: the description & screen-shots still contain the conditional build plug-in but I've tested it today with out conditions configured and there's the same behaviour, if you want I can attach new/more screen-shots. Krzesmir Florek
made changes -
| Component/s | New: parameterized-trigger [ 15592 ] | |
| Component/s | Original: conditional-buildstep [ 15947 ] | |
| Description |
Original:
When you have a parametrised build using conditional build steps 1st build after a jenkins restart works fine, while the 2nd keeps the parameter values from the 1st. (Or at least it seems so: please find details/proofs in the attachments). No clue if this comes directly from this plug-in or from some other related to it or (maybe) it's a core jenkins issue. The "test" build I used is following: - trigger builds from the CCC variable (non-conditional build step) - trigger another build only if BBB is true (conditional build step) In the 1st run I select BBB=true, CCC="TEST 2, TEST3"; and the build proceeds as expected triggers builds TEST 2 & TEST 3, and then a conditional build step. In the 2nd run I select BBB=false, CCC="TEST 1"; and proceeds in a very weird manner it still triggers builds TEST 2 & TEST 3, like before - so I assume it somehow takes the old value for the parameter CCC, but then doesn't trigger the conditional build - so I assume it now takes the current value for the parameter BBB. I only assume it's coming from this plugin as I haven't seen this behaviour when I was using build triggering with no conditions - only selectable job names from the list(s). |
New:
When you have a parametrised build trigger using a build parameter to select a list of builds to trigger the following happens: 1st build after a jenkins restart works fine, while the 2nd keeps the parameter values from the 1st. (Or at least it seems so: please find details/proofs in the attachments). Still no clue if this comes directly from this plug-in or from some other related to it or (maybe) it's a core jenkins issue (the jenkins was update really often lately plus I had new plug-ins installed/updated so it's hard identify a reason). The "test" build I used is following: - trigger builds from the CCC variable (non-conditional build step) - trigger another build only if BBB is true (conditional build step) In the 1st run I select BBB=true, CCC="TEST 2, TEST3"; and the build proceeds as expected triggers builds TEST 2 & TEST 3, and then a conditional build step. In the 2nd run I select BBB=false, CCC="TEST 1"; and proceeds in a very weird manner it still triggers builds TEST 2 & TEST 3, like before - so I assume it somehow takes the old value for the parameter CCC, but then doesn't trigger the conditional build - so I assume it now takes the current value for the parameter BBB. I am pretty sure it was working fine before (a few weeks ago) I have no proof for it. |
Krzesmir Florek
made changes -
| Summary | Original: Conditional BuildStep Plugin takes build params from the old build not from the current | New: Parametrised Build Trigger Plugin takes build params from the old build not from the current |
| Assignee | Original: Dominik Bartholdi [ domi ] | New: huybrechts [ huybrechts ] |
Krzesmir Florek
added a comment - Any update on this one? it is a real issue for us. 
Ville Ullen
added a comment - Hi,
I believe I have the same issue and it's rather easy to trigger;
Setup a project with one parameter and one build step - "Trigger/call builds on other projects". In the "projects to build" let it expand the parameter.
Now I'm new to the code base, but I would say that the cause lies in BuildTriggerConfig.java and this comment;
// the list of projects to build is computed in getProjectList() ; this method // is actually invoked twice (when in a build step), so let's cache its result private transient List<AbstractProject> projectList;
This implies that the BuildTriggerConfig is cached on some other level, so it may be that it has worked before and broke due to other optimizations.
I haven't had the chance to test it yet though, due to administration issues...
Ville Ullen
added a comment - Hi,
I believe I have the same issue and it's rather easy to trigger;
Setup a project with one parameter and one build step - "Trigger/call builds on other projects". In the "projects to build" let it expand the parameter.
Now I'm new to the code base, but I would say that the cause lies in BuildTriggerConfig.java and this comment;
// the list of projects to build is computed in getProjectList() ; this method
// is actually invoked twice (when in a build step), so let's cache its result
private transient List<AbstractProject> projectList;
This implies that the BuildTriggerConfig is cached on some other level, so it may be that it has worked before and broke due to other optimizations.
I haven't had the chance to test it yet though, due to administration issues... 
Thomas Dingler
added a comment - I have the same problem and would like to see a bug fix soon, because currently we have to start our builds twice.. 
Thomas Dingler
added a comment - I have the same problem and would like to see a bug fix soon, because currently we have to start our builds twice.. 
so far, I'm not able to reproduce this issue, but: