Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-11953

EC2 plugin needs to load regions dynamically (or add Oregon region to list)

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • ec2-plugin
    • None
    • Win/Linux

      EC2 plug-in seems to have regions hard coded. As more regions are added, these will have to be added to the list. Instead, it should retrieve all available regions through one API call, that way there would be no list to maintain.

      The problem code can be seen here:

      https://github.com/jenkinsci/ec2-plugin/blob/master/src/main/java/hudson/plugins/ec2/AwsRegion.java (lines 19-23). It should get all that info with the API calls, not through hard-coded enum kind of thing.

          [JENKINS-11953] EC2 plugin needs to load regions dynamically (or add Oregon region to list)

          Ruben Orduz created issue -
          Ruben Orduz made changes -
          Description Original: EC2 plug-in seems to have regions hard coded. As more regions are added, these will have to be added to the list. Instead, it should retrieve all available regions through one API call, that way there would be no list to maintain. New: EC2 plug-in seems to have regions hard coded. As more regions are added, these will have to be added to the list. Instead, it should retrieve all available regions through one API call, that way there would be no list to maintain.

          The problem code can be seen here:

          https://github.com/jenkinsci/ec2-plugin/blob/master/src/main/java/hudson/plugins/ec2/AwsRegion.java (lines 19-23). It should get all that info with the API calls, not through hard-coded enum kind of thing.
          Priority Original: Minor [ 4 ] New: Major [ 3 ]

          Ruben Orduz added a comment -

          While not fixing the root cause (i.e. dynamic region loading from API call), I added the coded/config changes to add the new Oregon region. You can find these at:
          https://gist.github.com/1423702

          Ruben Orduz added a comment - While not fixing the root cause (i.e. dynamic region loading from API call), I added the coded/config changes to add the new Oregon region. You can find these at: https://gist.github.com/1423702
          Ruben Orduz made changes -
          Summary Original: EC2 plugin needs to load regions dynamically New: EC2 plugin needs to load regions dynamically (or add Oregon region to list)
          Frank Bille made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Frank Bille made changes -
          Assignee Original: Kohsuke Kawaguchi [ kohsuke ] New: Frank Bille [ frankbille ]

          Frank Bille added a comment -

          This has been fixed on master, and will part of the next release

          https://github.com/jenkinsci/ec2-plugin/commit/c26a52ce583e4b5ea1be9fc52933c52c5e5e3dd1

          Frank Bille added a comment - This has been fixed on master, and will part of the next release https://github.com/jenkinsci/ec2-plugin/commit/c26a52ce583e4b5ea1be9fc52933c52c5e5e3dd1

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Francis Upton IV
          Path:
          src/main/java/hudson/plugins/ec2/AmazonEC2Cloud.java
          src/main/java/hudson/plugins/ec2/AwsRegion.java
          src/main/java/hudson/plugins/ec2/EC2Cloud.java
          src/main/java/hudson/plugins/ec2/EC2Computer.java
          src/main/java/hudson/plugins/ec2/EC2Slave.java
          src/main/java/hudson/plugins/ec2/PluginImpl.java
          src/main/java/hudson/plugins/ec2/SlaveTemplate.java
          src/main/resources/hudson/plugins/ec2/AmazonEC2Cloud/config-entries.jelly
          src/main/resources/hudson/plugins/ec2/EC2Computer/configure.jelly
          src/main/resources/hudson/plugins/ec2/EC2Slave/help-zone.html
          src/main/resources/hudson/plugins/ec2/Messages.properties
          src/main/resources/hudson/plugins/ec2/SlaveTemplate/config.jelly
          src/test/java/hudson/plugins/ec2/AmazonEC2CloudTest.java
          src/test/java/hudson/plugins/ec2/SlaveTemplateTest.java
          src/test/java/hudson/plugins/ec2/TemplateLabelsTest.java
          http://jenkins-ci.org/commit/ec2-plugin/f0e542fa9b2c6e4f112294b92145afd4e04eadd9
          Log:
          [FIXED JENKINS-8946] Option to set Zone as well as region for instance creation [FIXED JENKINS-11953] Dynamically local AWS regions

          Compare: https://github.com/jenkinsci/ec2-plugin/compare/19c419b...f0e542f

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Francis Upton IV Path: src/main/java/hudson/plugins/ec2/AmazonEC2Cloud.java src/main/java/hudson/plugins/ec2/AwsRegion.java src/main/java/hudson/plugins/ec2/EC2Cloud.java src/main/java/hudson/plugins/ec2/EC2Computer.java src/main/java/hudson/plugins/ec2/EC2Slave.java src/main/java/hudson/plugins/ec2/PluginImpl.java src/main/java/hudson/plugins/ec2/SlaveTemplate.java src/main/resources/hudson/plugins/ec2/AmazonEC2Cloud/config-entries.jelly src/main/resources/hudson/plugins/ec2/EC2Computer/configure.jelly src/main/resources/hudson/plugins/ec2/EC2Slave/help-zone.html src/main/resources/hudson/plugins/ec2/Messages.properties src/main/resources/hudson/plugins/ec2/SlaveTemplate/config.jelly src/test/java/hudson/plugins/ec2/AmazonEC2CloudTest.java src/test/java/hudson/plugins/ec2/SlaveTemplateTest.java src/test/java/hudson/plugins/ec2/TemplateLabelsTest.java http://jenkins-ci.org/commit/ec2-plugin/f0e542fa9b2c6e4f112294b92145afd4e04eadd9 Log: [FIXED JENKINS-8946] Option to set Zone as well as region for instance creation [FIXED JENKINS-11953] Dynamically local AWS regions Compare: https://github.com/jenkinsci/ec2-plugin/compare/19c419b...f0e542f

          Francis Upton added a comment -

          Fixed in 1.15

          Francis Upton added a comment - Fixed in 1.15
          Francis Upton made changes -
          Assignee Original: Frank Bille [ frankbille ] New: Francis Upton [ francisu ]
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]

            francisu Francis Upton
            rdo_ci Ruben Orduz
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved: