Code changed in jenkins
User: Jørgen P. Tjernø
Path:
src/main/java/hudson/plugins/copyartifact/CopyArtifact.java
http://jenkins-ci.org/commit/copyartifact-plugin/81c6bec56889ccfee9ee626397dbcb8a882457d6
Log:
JENKINS-12134 Automatically fingerprint files.

Integrated in plugins_copyartifact #73
JENKINS-12134 Automatically fingerprint files.

jtjerno : 81c6bec56889ccfee9ee626397dbcb8a882457d6
Files :

• src/main/java/hudson/plugins/copyartifact/CopyArtifact.java

The current implementation of this ticket leads to a serious performance degradation for me. While I have all freestyle projects with fingerprinting disabled, the plugin now starts to fingerprint files.

Setup: I have one specific project with 17000+ archived artifacts. These artifacts are used as a prerequisite for a number of other projects. Fingerprinting all these files adds about 15 minutes to the build time of each of these projects which is unacceptible.

Please make the fingerprinting optional, or follow the fingerprinting setting of the source and/or target projects.

Here's a suggested fix for this: https://github.com/jenkinsci/copyartifact-plugin/pull/8
It requires you to enable "Fingerprint all artifacts" on the source for the destination to fingerprint the files.

In addition, Kohsuke mentioned that he could look into reworking the digesting so that it's done during transfer. This would most likely add a negligible overhead to the copy process, and make the digest process basically free.

How long does your "Copy Artifact" process take if the fingerprinting takes 15 minutes?

Integrated in plugins_copyartifact #78
[FIXED JENKINS-12134] hide the overhead of fingerprinting into I/O.

Kohsuke Kawaguchi : 3cf80e567c8171428be377ddb2ec6855a7570dc3
Files :

• pom.xml
• src/main/java/hudson/plugins/copyartifact/FilePathCopyMethod.java
• src/main/java/hudson/plugins/copyartifact/CopyArtifact.java
• src/main/java/hudson/plugins/copyartifact/FingerprintingCopyMethod.java
• src/main/java/hudson/plugins/copyartifact/Copier.java
• src/main/java/hudson/plugins/copyartifact/CopyMethod.java

Ringo, would you mind testing the performance of 0.21? It has something that should hopefully be a great performance improvement from 0.20, but still fingerprints. Let us know if you're still seeing unacceptable performance levels.

Did this new change introduce JENKINS-12412 ?

Hi there,

I personally don't have the need for fingerprinting for some of my builds, and since they generate a large number of small files, fingerprinting is actually slower than the copy itself. With the latest release that hides the overhead of fingerprinting, it is much better, but the fingerprinting still takes longer than the actual IO of the copy. Could we please make the fingerprinting optional rather than automatic? I wouldn't mind if the option defaulted to being "on"

Thanks,
Mandeep

Agree with Mandeep, Currently, don't use the fingerprinting. I use the copy artifact plugin to deploy to different dev environment (as a self service for the dev teams). The same artifact will then be fingerprinted several times (at least once for every environment). So the optional fingerprinting would be a great feature.

Looking at priorities, I don't understand why work is being done on a feature that results in a regression to a number of us, while JENKINS-9741 has more votes and more followers. Wouldn't that ticket be more important then?

Actually, 0.21 should have fixed JENKINS-9741 - please test it. The new code Kohsuke wrote to do better copies also preserves permissions.

I can confirm mandeepr's observations. I upgraded from Copy Artifact 1.18 to 1.21. Here are some time differences for projects that all copy the archived artifacts of a common upstream project (18k+ files):

• project 1: 36 min to 1 hr 1 min
• project 2: 40 min to 1 hr 13 min

So again the request to not fingerprint if the source and/or target project has fingerprinting disabled. I am going to downgrade the plugin again as the above numbers are not acceptable for us.

And Jørgen, you refer version numbers of the plugin starting with zero (0.19, 0.21). Shouldn't this be 1.19 and 1.21?

Please let us turn this behaviour off. I'm having a really weird problem where I have two "see fingerprints" links in each build of project A, and when I click on either one all I see is the artifacts this plugin copied in. I want to fingerprint those along with other things I have set to fingerprint from project B, which are copied in via a separate dependency tool rather than this plugin.

If I look at the target file in project B's build fingerprints I can see the link was made successfully, but in project A's build entry there is no way to find that link (and thus it does not show up as a change in dependency in the build changes list).

I've got two "see fingerprints" too. If I look into build.xml I can see two <hudson.tasks.Fingerprinter_-FingerprintAction> tag with different content.

I've created a pull request to add a checkbox to control the fingerprinting of artifacts: https://github.com/jenkinsci/copyartifact-plugin/pull/10

Is there going to be any movement on that pull request? Or do I have to make a custom build of the plugin?

+1. This issue also appears to break aggregated test results, presumably because of the duplicate "<hudson.tasks.Fingerprinter_-FingerprintAction>" XML elements.

Code changed in jenkins
User: Kelsey Prantis
Path:
src/main/java/hudson/plugins/copyartifact/Copier.java
src/main/java/hudson/plugins/copyartifact/CopyArtifact.java
src/main/java/hudson/plugins/copyartifact/FilePathCopyMethod.java
src/main/java/hudson/plugins/copyartifact/FingerprintingCopyMethod.java
src/main/resources/hudson/plugins/copyartifact/CopyArtifact/config.jelly
src/main/webapp/help-flatten-optional.html
src/test/java/hudson/plugins/copyartifact/CopyArtifactTest.java
http://jenkins-ci.org/commit/copyartifact-plugin/d10dad4341bc2495f469dc5cd4534bbe5e58b13c
Log:
JENKINS-12134 - Make fingerprinting artifacts optional.

In v1.29 of the Copy Artifact Plugin, fingerprinting was made optional.