Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-12298

MultiSCMRevisionState.revisionStates cannot differentiate multiple instances of a single SCM type

      public void add(String scmClass, SCMRevisionState scmState) {
        revisionStates.put(scmClass, scmState);
      }
      ...
      revisionStates.add(scm.getClass().getName(), scmState);
      

      cannot work when you want to use more than one copy of a given SCM plugin in a single job. First of all you should use scm.getType() rather than hardcoding the class name. Second you should include the result of getModuleRoots in the hash key.

          [JENKINS-12298] MultiSCMRevisionState.revisionStates cannot differentiate multiple instances of a single SCM type

          Jesse Glick created issue -
          Jesse Glick made changes -
          Link New: This issue is blocking JENKINS-12162 [ JENKINS-12162 ]
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Kevin Bell made changes -
          Fix Version/s New: current [ 10162 ]
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]
          Jesse Glick made changes -
          Link New: This issue is related to JENKINS-23365 [ JENKINS-23365 ]
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 142620 ] New: JNJira + In-Review [ 190203 ]

            kbell Kevin Bell
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: