Details
-
Improvement
-
Status: Resolved (View Workflow)
-
Minor
-
Resolution: Fixed
-
None
Description
I got this in my jobs console.
[WARNINGS] Setting build status to FAILURE since total number of annotations exceeds the threshold 200: [HIGH, NORMAL, LOW]
Two issues.
1. text says total, but this was actually a "compute status since reference build (new) gate.
2. text should say which specific criteria was exceeded
3. it doesn't tell you what the actual number/difference was
E.g.
[WARNINGS] Setting build status to FAILURE since number, 234, of new HIGH annotations exceeds the threshold of 200 by 34 or 17%.
Attachments
Activity
I think that would be excellent!
Currently I have to scroll, typically to the bottom, of the build console to see what threshold got triggered.
That is still a good place for the info, since it has the counts of all the issues found by all the plugins and parsers..
I do agree that i this was also on the "build status"? page then I think it would be much more convenient!
E.g.
Build # 10
Compiler/Static Analysis/Duplicate Code/etc Warnings: #### [this decoration probably applies to many plugins!]
Total All threshold exceeded
Total Low threshold exceeded {details}
[only if exceeded]
Total Normal threshold exceeded
Total High threshold exceeded {details}
[only if exceeded]
-
-
- New Warnings
New All threshold exceeded {details} [only if exceeded]
New Low threshold exceeded {details}[only if exceeded]
{details} [only if exceeded]
New Normal threshold exceeded
New High threshold exceeded {details}[only if exceeded]
- New Warnings
-
Ok, I added the message to the build summary:
BuildResultEvaluator.failure.new.priority={0} new warnings of priority {3} exceed the threshold of {1} by {2} BuildResultEvaluator.failure.all.priority={0} warnings of priority {3} exceed the threshold of {1} by {2} BuildResultEvaluator.failure.new={0} new warnings exceed the threshold of {1} by {2} BuildResultEvaluator.failure.all={0} warnings exceed the threshold of {1} by {2}
Can you please check if these messages are ok (and correct English)? The numbers in the brackets are replaced by values. There is one message for new and totals and one for single priorty and all priorities.
Integrated in Jenkins Analysis Plug-ins (Compile) #381
[FIXED JENKINS-12424] Show build status evaluation result in build (Revision 9ed020307e45caf233645a135485e4e53d33db02)
Result = SUCCESS
Integrated in plugins_analysis-core #10407
[FIXED JENKINS-12424] Show build status evaluation result in build (Revision 9ed020307e45caf233645a135485e4e53d33db02)
Result = SUCCESS
Ulli Hafner :
Files :
- src/main/java/hudson/plugins/analysis/core/BuildResult.java
- src/main/java/hudson/plugins/analysis/core/BuildResultEvaluator.java
- src/test/java/hudson/plugins/analysis/core/BuildResultEvaluatorTest.java
- src/main/resources/hudson/plugins/analysis/Messages_de.properties
- src/main/resources/hudson/plugins/analysis/Messages.properties
First job that had a build that violated the thresholds had this in the build splash page:
Compiler Warnings: 392 warnings.
174 new warnings
139 fixed warnings
Plug-in Result:Failed - 117 new warnings of priority Normal Priority exceed the threshold of 80 by 37 (Reference build: #21)
build # 21 has
Compiler Warnings: 359 warnings.
I then remembered that this is not a total, but a priority check, and also that I have 'delta' checked for configuration of the check.
build # 21 had 47 normals
build # 24 has 164 normals
164 - 47 = 117 > 80 (the threshold) => Answer is OK. It just takes some getting used to.
Regardless, Thank You so much for making this change!!!
---------------------
Is it possible to do something like highlight some text in the justification and link it to the data grids?
e.g. (slightly rewording it)
117 <ul>New Normal Priority</ul> Warnings exceed the threshold of 80 by 37 (Reference build: #21)
where the link navigates you to
build # >> Compiler Warnings » New Warnings
and selects the Normal priority tab?
Yes, that would improve that usability even more.
Since this feature needs the HTML links from the individual plug-ins, changes to all plug-ins are required (and not only to analysis-core). So this will take some time...
Code changed in jenkins
User: Ulli Hafner
Path:
src/main/java/hudson/plugins/analysis/core/BuildResult.java
src/main/java/hudson/plugins/analysis/util/HtmlPrinter.java
src/main/resources/hudson/plugins/analysis/Messages.properties
src/main/resources/hudson/plugins/analysis/Messages_de.properties
src/main/resources/hudson/plugins/analysis/Messages_fr.properties
src/main/resources/hudson/plugins/analysis/Messages_ja.properties
src/test/java/hudson/plugins/analysis/core/BuildResultTest.java
http://jenkins-ci.org/commit/analysis-core-plugin/882d0579575d069b2e45e4528dd70bb2ccc68020
Log:
JENKINS-12424 Pulled up build result summary message to BuildResult.
Code changed in jenkins
User: Ulli Hafner
Path:
pom.xml
src/main/java/hudson/plugins/dry/DryResult.java
src/main/java/hudson/plugins/dry/ResultSummary.java
src/main/resources/hudson/plugins/dry/Messages.properties
src/main/resources/hudson/plugins/dry/Messages_de.properties
src/main/resources/hudson/plugins/dry/Messages_ja.properties
src/test/java/hudson/plugins/dry/ResultSummaryTest.java
http://jenkins-ci.org/commit/dry-plugin/3b34bf609768117b4aa419de8b91bb7af8923ac9
Log:
JENKINS-12424 Use messages from base class.
Code changed in jenkins
User: Ulli Hafner
Path:
pom.xml
src/main/java/hudson/plugins/checkstyle/CheckStyleResult.java
src/main/java/hudson/plugins/checkstyle/ResultSummary.java
src/main/resources/hudson/plugins/checkstyle/Messages.properties
src/main/resources/hudson/plugins/checkstyle/Messages_de.properties
src/main/resources/hudson/plugins/checkstyle/Messages_fr.properties
src/main/resources/hudson/plugins/checkstyle/Messages_ja.properties
src/test/java/hudson/plugins/checkstyle/ResultSummaryTest.java
http://jenkins-ci.org/commit/checkstyle-plugin/c9863ac5e7a939f58897200225a724063555f08f
Log:
JENKINS-12424 Use messages from base class.
Code changed in jenkins
User: Ulli Hafner
Path:
plugin/pom.xml
plugin/src/main/java/hudson/plugins/findbugs/FindBugsResult.java
plugin/src/main/java/hudson/plugins/findbugs/ResultSummary.java
plugin/src/main/resources/hudson/plugins/findbugs/Messages.properties
plugin/src/main/resources/hudson/plugins/findbugs/Messages_de.properties
plugin/src/main/resources/hudson/plugins/findbugs/Messages_ja.properties
plugin/src/test/java/hudson/plugins/findbugs/ResultSummaryTest.java
http://jenkins-ci.org/commit/findbugs-plugin/fbbb1fef2619c783f0ee49a652234cb127b737f4
Log:
JENKINS-12424 Use messages from base class.
Code changed in jenkins
User: Ulli Hafner
Path:
pom.xml
src/main/java/hudson/plugins/pmd/PmdResult.java
src/main/java/hudson/plugins/pmd/ResultSummary.java
src/main/resources/hudson/plugins/pmd/Messages.properties
src/main/resources/hudson/plugins/pmd/Messages_de.properties
src/main/resources/hudson/plugins/pmd/Messages_fr.properties
src/main/resources/hudson/plugins/pmd/Messages_ja.properties
src/test/java/hudson/plugins/pmd/ResultSummaryTest.java
http://jenkins-ci.org/commit/pmd-plugin/933785d4f694c9bbbd07f18b17e8badf0dff4953
Log:
JENKINS-12424 Use messages from base class.
Code changed in jenkins
User: Ulli Hafner
Path:
pom.xml
src/main/java/hudson/plugins/analysis/collector/AnalysisResult.java
src/main/java/hudson/plugins/analysis/collector/AnalysisResultSummary.java
src/main/resources/hudson/plugins/analysis/collector/Messages.properties
src/main/resources/hudson/plugins/analysis/collector/Messages_de.properties
src/main/resources/hudson/plugins/analysis/collector/Messages_ja.properties
src/test/java/hudson/plugins/analysis/collector/ResultSummaryTest.java
http://jenkins-ci.org/commit/analysis-collector-plugin/5743c8c7b9035e3c4e0a1d0543f8307f6469029c
Log:
JENKINS-12424 Use messages from base class.
Code changed in jenkins
User: Ulli Hafner
Path:
src/main/java/hudson/plugins/warnings/WarningsResult.java
src/main/resources/hudson/plugins/warnings/Messages.properties
src/main/resources/hudson/plugins/warnings/Messages_de.properties
src/main/resources/hudson/plugins/warnings/Messages_fr.properties
src/main/resources/hudson/plugins/warnings/Messages_ja.properties
http://jenkins-ci.org/commit/warnings-plugin/a530b8e715536d3b5c3b040e0de569a303d0291f
Log:
JENKINS-12424 Use messages from base class.
Code changed in jenkins
User: Ulli Hafner
Path:
src/main/java/hudson/plugins/analysis/core/AbstractResultAction.java
http://jenkins-ci.org/commit/analysis-core-plugin/fde91c34942a51e50d8be0d2eba7df08ed52534b
Log:
JENKINS-12424 Pulled up tool tips.
Code changed in jenkins
User: Ulli Hafner
Path:
src/main/java/hudson/plugins/checkstyle/CheckStyleResultAction.java
http://jenkins-ci.org/commit/checkstyle-plugin/f0fab6a73c1197d5f78b2493789c3e4ae9692f5b
Log:
JENKINS-12424 Pulled up tool tips.
Code changed in jenkins
User: Ulli Hafner
Path:
src/main/java/hudson/plugins/dry/DryResultAction.java
http://jenkins-ci.org/commit/dry-plugin/e0c7b51ab19fe8749a0be2b8d105d0c2f820d210
Log:
JENKINS-12424 Pulled up tool tips.
Code changed in jenkins
User: Ulli Hafner
Path:
src/main/java/hudson/plugins/pmd/PmdResultAction.java
http://jenkins-ci.org/commit/pmd-plugin/4c0aed391e7f175bad887c3f2f35171b5802fc89
Log:
JENKINS-12424 Pulled up tool tips.
Code changed in jenkins
User: Ulli Hafner
Path:
plugin/src/main/java/hudson/plugins/findbugs/FindBugsResultAction.java
http://jenkins-ci.org/commit/findbugs-plugin/09423284d787f23cd1397070c43303967a3451ce
Log:
JENKINS-12424 Pulled up tool tips.
Code changed in jenkins
User: Ulli Hafner
Path:
src/main/java/hudson/plugins/warnings/WarningsResultAction.java
http://jenkins-ci.org/commit/warnings-plugin/27ced4879f77753a48b4ab60a7a0e09426758ef8
Log:
JENKINS-12424 Pulled up tool tips.
Code changed in jenkins
User: Ulli Hafner
Path:
src/main/java/hudson/plugins/analysis/collector/AnalysisResultAction.java
http://jenkins-ci.org/commit/analysis-collector-plugin/6d57f9725542884510355622b84692b0ede612ea
Log:
JENKINS-12424 Pulled up tool tips.
Integrated in plugins_analysis-core #10448
JENKINS-12424 Pulled up build result summary message to BuildResult. (Revision 882d0579575d069b2e45e4528dd70bb2ccc68020)
Result = SUCCESS
Ulli Hafner :
Files :
- src/main/resources/hudson/plugins/analysis/Messages_fr.properties
- src/main/resources/hudson/plugins/analysis/Messages_de.properties
- src/test/java/hudson/plugins/analysis/core/BuildResultTest.java
- src/main/resources/hudson/plugins/analysis/Messages_ja.properties
- src/main/resources/hudson/plugins/analysis/Messages.properties
- src/main/java/hudson/plugins/analysis/util/HtmlPrinter.java
- src/main/java/hudson/plugins/analysis/core/BuildResult.java
Integrated in Jenkins Analysis Plug-ins (Compile) #495
JENKINS-12424 Pulled up tool tips. (Revision fde91c34942a51e50d8be0d2eba7df08ed52534b)
Result = SUCCESS
Integrated in plugins_analysis-core #10449
JENKINS-12424 Pulled up tool tips. (Revision fde91c34942a51e50d8be0d2eba7df08ed52534b)
Result = SUCCESS
Ulli Hafner :
Files :
- src/main/java/hudson/plugins/analysis/core/AbstractResultAction.java
Code changed in jenkins
User: Ulli Hafner
Path:
src/main/java/hudson/plugins/analysis/core/AbstractResultAction.java
src/main/java/hudson/plugins/analysis/core/BuildResult.java
src/main/java/hudson/plugins/analysis/core/BuildResultEvaluator.java
src/main/java/hudson/plugins/analysis/core/HealthAwarePublisher.java
src/main/java/hudson/plugins/analysis/core/HealthAwareReporter.java
src/main/java/hudson/plugins/analysis/core/MavenResultAction.java
src/main/java/hudson/plugins/analysis/core/ReporterDescriptor.java
src/main/resources/hudson/plugins/analysis/Messages.properties
src/main/resources/hudson/plugins/analysis/Messages_de.properties
src/test/java/hudson/plugins/analysis/core/BuildResultEvaluatorTest.java
http://jenkins-ci.org/commit/analysis-core-plugin/b72cda9a98a5d11b5b4be355bf87d9aa30f55e86
Log:
JENKINS-12424 Added links to new and priority warnings.
Integrated in Jenkins Analysis Plug-ins (Compile) #502
JENKINS-12424 Added links to new and priority warnings. (Revision b72cda9a98a5d11b5b4be355bf87d9aa30f55e86)
Result = SUCCESS
Code changed in jenkins
User: Ulli Hafner
Path:
src/main/java/hudson/plugins/analysis/core/BuildResultEvaluator.java
src/main/resources/hudson/plugins/analysis/Messages.properties
src/main/resources/hudson/plugins/analysis/Messages_de.properties
http://jenkins-ci.org/commit/analysis-core-plugin/5c21e8054698196040a75cf4f18944b8bef94d51
Log:
[Fixed JENKINS-12424] Added messages for one warning.
Integrated in Jenkins Analysis Plug-ins (Compile) #505
[Fixed JENKINS-12424] Added messages for one warning. (Revision 5c21e8054698196040a75cf4f18944b8bef94d51)
Result = SUCCESS
Integrated in plugins_analysis-core #10451
JENKINS-12424 Added links to new and priority warnings. (Revision b72cda9a98a5d11b5b4be355bf87d9aa30f55e86)
[Fixed JENKINS-12424] Added messages for one warning. (Revision 5c21e8054698196040a75cf4f18944b8bef94d51)
Result = SUCCESS
Ulli Hafner :
Files :
- src/main/java/hudson/plugins/analysis/core/ReporterDescriptor.java
- src/main/java/hudson/plugins/analysis/core/HealthAwarePublisher.java
- src/test/java/hudson/plugins/analysis/core/BuildResultEvaluatorTest.java
- src/main/java/hudson/plugins/analysis/core/MavenResultAction.java
- src/main/java/hudson/plugins/analysis/core/BuildResult.java
- src/main/resources/hudson/plugins/analysis/Messages_de.properties
- src/main/java/hudson/plugins/analysis/core/BuildResultEvaluator.java
- src/main/java/hudson/plugins/analysis/core/HealthAwareReporter.java
- src/main/resources/hudson/plugins/analysis/Messages.properties
- src/main/java/hudson/plugins/analysis/core/AbstractResultAction.java
Ulli Hafner :
Files :
- src/main/resources/hudson/plugins/analysis/Messages_de.properties
- src/main/java/hudson/plugins/analysis/core/BuildResultEvaluator.java
- src/main/resources/hudson/plugins/analysis/Messages.properties
Do you think it makes sense that this text would be shown more prominent, e.g. in one of the views instead of in the log? Currently this is just a logging statement (which is also not localizable).