Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-12738

Dry Plugin reports code duplicates twice

    XMLWordPrintable

Details

    Description

      I have used CPD to detect duplicate codes in my project and Dry plugin is used. The plugin is reporting the duplicate codes , but it reports twice for a duplicate code-snippet. I have attached the screenshot of our files reported. Please let me know is this the expected behaviour or it needs any correction. But I feel this is somewhat not an expected behavior and needs your attention.

      Thanks,
      Santosh

      Attachments

        Issue Links

          duplicates

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-11376 Don't output multiple warnings for duplicated code

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-16688 Duplications in different files shown only in one file

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            Ascending order - Click to sort in descending order
            kumar0112 Kumar n created issue -
            drulli Ulli Hafner made changes -
            Field Original Value New Value
            Link This issue duplicates JENKINS-11376 [ JENKINS-11376 ]
            drulli Ulli Hafner added a comment - - edited

            Please attach as watchee JENKINS-11376.

            drulli Ulli Hafner added a comment - - edited Please attach as watchee JENKINS-11376 .
            drulli Ulli Hafner made changes -
            Resolution Duplicate [ 3 ]
            Status Open [ 1 ] Resolved [ 5 ]
            kumar0112 Kumar n added a comment -

            Thanks for the comments. I have attached extracted xml for your reference, where it shows the lines for duplicate code and which are not repeated. that is, there are no multiple warnings. the lines in the attached xml show the duplicated code for the warnings attached in my previous message(for the file job.cpp).

            Please have a look.

            Thanks,
            Santosh.

            kumar0112 Kumar n added a comment - Thanks for the comments. I have attached extracted xml for your reference, where it shows the lines for duplicate code and which are not repeated. that is, there are no multiple warnings. the lines in the attached xml show the duplicated code for the warnings attached in my previous message(for the file job.cpp). Please have a look. Thanks, Santosh.
            kumar0112 Kumar n added a comment -

            here are the lines from cpd.xml: they show there are no multiple warnings:

            ..............
            .............
            <duplication lines="155" tokens="1205">
            <file line="2995" path="C:\Program Files (x86)\Jenkins\jobs\RasterLib\workspace\hpldrlgl\library\Src\job.cpp"/>
            <file line="3612" path="C:\Program Files (x86)\Jenkins\jobs\RasterLib\workspace\hpldrlgl\library\Src\job.cpp"/>
            <codefragment>
            ....
            ...
            </codefragment>

            <duplication lines="99" tokens="468">
            <file line="3166" path="C:\Program Files (x86)\Jenkins\jobs\RasterLib\workspace\hpldrlgl\library\Src\job.cpp"/>
            <file line="3836" path="C:\Program Files (x86)\Jenkins\jobs\RasterLib\workspace\hpldrlgl\library\Src\job.cpp"/>
            <codefragment>
            ....
            ....
            </codefragment>

            kumar0112 Kumar n added a comment - here are the lines from cpd.xml: they show there are no multiple warnings: .............. ............. <duplication lines="155" tokens="1205"> <file line="2995" path="C:\Program Files (x86)\Jenkins\jobs\RasterLib\workspace\hpldrlgl\library\Src\job.cpp"/> <file line="3612" path="C:\Program Files (x86)\Jenkins\jobs\RasterLib\workspace\hpldrlgl\library\Src\job.cpp"/> <codefragment> .... ... </codefragment> <duplication lines="99" tokens="468"> <file line="3166" path="C:\Program Files (x86)\Jenkins\jobs\RasterLib\workspace\hpldrlgl\library\Src\job.cpp"/> <file line="3836" path="C:\Program Files (x86)\Jenkins\jobs\RasterLib\workspace\hpldrlgl\library\Src\job.cpp"/> <codefragment> .... .... </codefragment>
            drulli Ulli Hafner made changes -
            Link This issue is related to JENKINS-16688 [ JENKINS-16688 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 143195 ] JNJira + In-Review [ 190432 ]

            People

              drulli Ulli Hafner
              kumar0112 Kumar n
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: