-
Bug
-
Resolution: Fixed
-
Blocker
-
None
-
OS: Linux 64-bit
Jenkins Version: 1.447
Parameterized Trigger Plugin Version 2.13
The "Trigger/call builds on other projects" build step locks the job if one of the "Projects to build" is deactivated.
To reproduce:
1. Add the "Trigger/call builds on other projects" to the build steps.
2. Define some "Projects to build"
3. Activate the check box "Block until the triggered projects finish their builds"
4. Set "Mark this build as unstable if the triggered build is worse or equal to" to "UNSTABLE"
5. Deactivate one of the projects configured in "Projects to build"
6. Run the job
Expected behaviour:
The deactivated project will be ignored and the job continues with the next active project.
[JENKINS-12923] Deadlock if one of the triggered projects is deactivated
Hansgeorg Schwibbe
created issue -
Hansgeorg Schwibbe
made changes -
| Assignee | Original: Hansgeorg Schwibbe [ haschwib ] | New: Kohsuke Kawaguchi [ kohsuke ] |
Hansgeorg Schwibbe
made changes -
| Description |
Original:
The "Trigger/call builds on other projects" build step locks the job if one of the "Projects to build" is deactivated. To reproduce: 1. Add the "Trigger/call builds on other projects" to the build steps. 2. Define some "Projects to build" 3. Activate the check box "Block until the triggered projects finish their builds" 4. Set "Mark this build as unstable if the triggered build is worse or equal to" to "UNSTABLE" 5. Deactivate one of the projects configured in "Projects to build" 6. Run the job Expected behaviour: The deactivated project will be ignored and the Job continues with the next active project |
New:
The "Trigger/call builds on other projects" build step locks the job if one of the "Projects to build" is deactivated. To reproduce: 1. Add the "Trigger/call builds on other projects" to the build steps. 2. Define some "Projects to build" 3. Activate the check box "Block until the triggered projects finish their builds" 4. Set "Mark this build as unstable if the triggered build is worse or equal to" to "UNSTABLE" 5. Deactivate one of the projects configured in "Projects to build" 6. Run the job Expected behaviour: The deactivated project will be ignored and the job continues with the next active project. |
Hansgeorg Schwibbe
made changes -
| Attachment | New: screenshot-1.jpg [ 21570 ] |
Hansgeorg Schwibbe
added a comment - Another deadlock comes up with the Jenkins shutdown mode:
1. The main job has started
2. Jenkins is going into shutdown mode
3. The main job triggers another job
4. The triggered job does not start until shutdown was successful
5. Jenkins does not shutdown until the main job has been finished
6. The main job does not finish until the triggered job has been finished
7. Deadlock (continues with step 4.)
Hansgeorg Schwibbe
added a comment - Another deadlock comes up with the Jenkins shutdown mode:
1. The main job has started
2. Jenkins is going into shutdown mode
3. The main job triggers another job
4. The triggered job does not start until shutdown was successful
5. Jenkins does not shutdown until the main job has been finished
6. The main job does not finish until the triggered job has been finished
7. Deadlock (continues with step 4.) Hansgeorg Schwibbe
made changes -
| Summary | Original: Job is locked if one of the triggered projects is deactivated | New: Deadlock if one of the triggered projects is deactivated |
Code changed in jenkins
User: Fred G
Path:
src/main/java/hudson/plugins/parameterizedtrigger/BlockableBuildTriggerConfig.java
src/main/java/hudson/plugins/parameterizedtrigger/TriggerBuilder.java
src/test/java/hudson/plugins/parameterizedtrigger/test/TriggerBuilderTest.java
http://jenkins-ci.org/commit/parameterized-trigger-plugin/0a24f077f98975f818e1d1fe8eb6b8c3e3763173
Log:
[FIXED JENKINS-12923] Fixed infinite loop, when
"Block until the triggered projects finish their builds" option is used and
triggered projects are disabled. Also added test cases.
| Resolution | New: Fixed [ 1 ] | |
| Status | Original: Open [ 1 ] | New: Resolved [ 5 ] |
Code changed in jenkins
User: Fred G
Path:
src/main/java/hudson/plugins/parameterizedtrigger/BlockableBuildTriggerConfig.java
src/main/java/hudson/plugins/parameterizedtrigger/TriggerBuilder.java
src/test/java/hudson/plugins/parameterizedtrigger/test/TriggerBuilderTest.java
http://jenkins-ci.org/commit/parameterized-trigger-plugin/50e11307835f62d8ccf9479cb798b7c0400cb1c3
Log:
Merge pull request #18 from fredg02/master
[FIXED JENKINS-12923] Fixed infinite loop, when
Compare: https://github.com/jenkinsci/parameterized-trigger-plugin/compare/207c7b7...50e1130
According to the screenshot:
The job is running in idle mode until "deployMocks" is deactivated.