Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-13129

Updating built-in plugins doesn't work, the file doesn't get pinned and is overwritten on the next startup

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Critical Critical
    • core
    • None
    • jenkins 1.456, tomcat 7.0.25, java 1.6.0-31 running on windows vista

      I still cannot update cvs or subversion plugins without manually creating a .pinned file.

      When e.g. updating cvs plugin 1.6 (shipped with jenkins.war) to 2.1, the file is installed into the plugin dir, but no cvs.jpi.pinned file is created. When restarting the tomcat server, the file is replaced by the 1.6 version from the war directory.

          [JENKINS-13129] Updating built-in plugins doesn't work, the file doesn't get pinned and is overwritten on the next startup

          Alex Lehmann created issue -

          sogabe added a comment -

          JENKINS-12514 will be fixed in 1.456. See http://jenkins-ci.org/changelog.

          sogabe added a comment - JENKINS-12514 will be fixed in 1.456. See http://jenkins-ci.org/changelog .

          Alex Lehmann added a comment -

          issue is still present in 1.456

          Alex Lehmann added a comment - issue is still present in 1.456
          Alex Lehmann made changes -
          Description Original: I still cannot update cvs or subversion plugins without manually creating a .pinned file.

          When e.g. updating cvs plugin 1.6 (shipped with jenkins.war) to 2.1, the file is installed into the plugin dir, but no cvs.jpi.pinned file is created. When restarting the tomcat server, the file is replaced by the 1.6 version from the war directory.

          This is probably related to JENKINS-12514, but wasn't fixed then
          		 New: I still cannot update cvs or subversion plugins without manually creating a .pinned file.

          When e.g. updating cvs plugin 1.6 (shipped with jenkins.war) to 2.1, the file is installed into the plugin dir, but no cvs.jpi.pinned file is created. When restarting the tomcat server, the file is replaced by the 1.6 version from the war directory.
          Environment Original: jenkins 1.457-snapshot, tomcat 7.0.25, java 1.6.0-31 running on windows vista
          jenkins 1.455, tomcat 7.0.26, java 1.6.0-31 running on ubuntu 11.10
          		 New: jenkins 1.456, tomcat 7.0.25, java 1.6.0-31 running on windows vista

          Alex Lehmann added a comment -

          i think i found the cause, there is problem with the isBundled property in plugins, I will write a patch tomorrow.

          Alex Lehmann added a comment - i think i found the cause, there is problem with the isBundled property in plugins, I will write a patch tomorrow.

          Alex Lehmann added a comment -

          https://github.com/alexlehm/jenkins/commit/2453985ca5f4cb2c824466d132fe3658020b72fe

          [Fixed JENKINS-13129] Updating built-in plugins doesn't work, the file doesn't get pinned and is overwritten on the next startup

          changed bundled plugin detection, added unit test

          Alex Lehmann added a comment - https://github.com/alexlehm/jenkins/commit/2453985ca5f4cb2c824466d132fe3658020b72fe [Fixed JENKINS-13129] Updating built-in plugins doesn't work, the file doesn't get pinned and is overwritten on the next startup changed bundled plugin detection, added unit test

          Alex Lehmann added a comment -

          I should note that this is not a specific Windows issue, I have had the same problem with 1.456 on linux as well

          Alex Lehmann added a comment - I should note that this is not a specific Windows issue, I have had the same problem with 1.456 on linux as well
          Alex Lehmann made changes -
          Assignee New: Alex Lehmann [ alexlehm ]
          Alex Lehmann made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Andrew Bayer
          Path:
          core/src/main/java/hudson/PluginManager.java
          test/src/test/java/hudson/PluginManagerTest2.java
          http://jenkins-ci.org/commit/jenkins/860cc9eb61a6a3212e4b8589ac11a74b59b1fcf7
          Log:
          Merge pull request #418 from alexlehm/master

          Fixed JENKINS-13129: Updating built-in plugins doesn't work, the file doesn't get pinned and is overwritten on the next startup

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: core/src/main/java/hudson/PluginManager.java test/src/test/java/hudson/PluginManagerTest2.java http://jenkins-ci.org/commit/jenkins/860cc9eb61a6a3212e4b8589ac11a74b59b1fcf7 Log: Merge pull request #418 from alexlehm/master Fixed JENKINS-13129 : Updating built-in plugins doesn't work, the file doesn't get pinned and is overwritten on the next startup

            alexlehm Alex Lehmann
            alexlehm Alex Lehmann
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: