Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-13416

On demand slave provisioning is starting all available slaves

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • slave-setup-plugin
    • None

      I'm using on demand slaves (on amazon) started by a shell script. When starting a job with all slaves disconnected, all my slaves are started together.
      When in debug, I'd noticed that "RetentionStrategy" "Demand" is testing "Computer.getDemandStartMilliseconds()" to connect the slave, but all slaves (that 'll take some time to wake up) pass in test.
      Shouldn't this strategy take in account if there are executor enough and nodes starting?

      I,ve made a change in RetentionStrategy that solves the problem. Anyone see any problem with this solution?

        1. jenkins-1.459.diff
          3 kB

          [JENKINS-13416] On demand slave provisioning is starting all available slaves

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Bruno Meneguello
          Path:
          core/src/main/java/hudson/slaves/RetentionStrategy.java
          http://jenkins-ci.org/commit/jenkins/5a32eca331bf1d5652ab908c356f0ed64de82c6f
          Log:
          [FIXED JENKINS-13416] On demand slave provisioning is starting all available slaves

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Bruno Meneguello Path: core/src/main/java/hudson/slaves/RetentionStrategy.java http://jenkins-ci.org/commit/jenkins/5a32eca331bf1d5652ab908c356f0ed64de82c6f Log: [FIXED JENKINS-13416] On demand slave provisioning is starting all available slaves

          dogfood added a comment -

          Integrated in jenkins_main_trunk #1659
          [FIXED JENKINS-13416] On demand slave provisioning is starting all available slaves (Revision 5a32eca331bf1d5652ab908c356f0ed64de82c6f)

          Result = SUCCESS
          Kohsuke Kawaguchi : 5a32eca331bf1d5652ab908c356f0ed64de82c6f
          Files :

          • core/src/main/java/hudson/slaves/RetentionStrategy.java

          dogfood added a comment - Integrated in jenkins_main_trunk #1659 [FIXED JENKINS-13416] On demand slave provisioning is starting all available slaves (Revision 5a32eca331bf1d5652ab908c356f0ed64de82c6f) Result = SUCCESS Kohsuke Kawaguchi : 5a32eca331bf1d5652ab908c356f0ed64de82c6f Files : core/src/main/java/hudson/slaves/RetentionStrategy.java

          dogfood added a comment -

          Integrated in jenkins_ui-changes_branch #21
          [FIXED JENKINS-13416] On demand slave provisioning is starting all available slaves (Revision 5a32eca331bf1d5652ab908c356f0ed64de82c6f)

          Result = SUCCESS
          Kohsuke Kawaguchi : 5a32eca331bf1d5652ab908c356f0ed64de82c6f
          Files :

          • core/src/main/java/hudson/slaves/RetentionStrategy.java

          dogfood added a comment - Integrated in jenkins_ui-changes_branch #21 [FIXED JENKINS-13416] On demand slave provisioning is starting all available slaves (Revision 5a32eca331bf1d5652ab908c356f0ed64de82c6f) Result = SUCCESS Kohsuke Kawaguchi : 5a32eca331bf1d5652ab908c356f0ed64de82c6f Files : core/src/main/java/hudson/slaves/RetentionStrategy.java

          Nathan Sharp added a comment -

          I need this fix. What version is it in? Thanks!

          Nathan Sharp added a comment - I need this fix. What version is it in? Thanks!

            kohsuke Kohsuke Kawaguchi
            bkmeneguello Bruno Meneguello
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: