-
Bug
-
Resolution: Fixed
-
Minor
-
None
I'm using on demand slaves (on amazon) started by a shell script. When starting a job with all slaves disconnected, all my slaves are started together.
When in debug, I'd noticed that "RetentionStrategy" "Demand" is testing "Computer.getDemandStartMilliseconds()" to connect the slave, but all slaves (that 'll take some time to wake up) pass in test.
Shouldn't this strategy take in account if there are executor enough and nodes starting?
I,ve made a change in RetentionStrategy that solves the problem. Anyone see any problem with this solution?
[JENKINS-13416] On demand slave provisioning is starting all available slaves
Attachment | New: jenkins-1.459.diff [ 21732 ] | |
Description |
Original:
I'm using on demand slaves (on amazon) started by a shell script. When starting a job with all slaves disconnected, all my slaves are started together. When in debug, I'd noticed that "RetentionStrategy" "Demand" is testing "Computer.getDemandStartMilliseconds()" to connect the slave, but all slaves (that 'll take some time to wake up) pass in test. Shouldn't this strategy take in account if there are executor enough and nodes starting? |
New:
I'm using on demand slaves (on amazon) started by a shell script. When starting a job with all slaves disconnected, all my slaves are started together. When in debug, I'd noticed that "RetentionStrategy" "Demand" is testing "Computer.getDemandStartMilliseconds()" to connect the slave, but all slaves (that 'll take some time to wake up) pass in test. Shouldn't this strategy take in account if there are executor enough and nodes starting? I,ve made a change in RetentionStrategy that solves the problem. Anyone see any problem with this solution? |
Resolution | New: Fixed [ 1 ] | |
Status | Original: Open [ 1 ] | New: Resolved [ 5 ] |
Workflow | Original: JNJira [ 143882 ] | New: JNJira + In-Review [ 190798 ] |