Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-13646

Automatically Created Clients missing Owner: in clientspec

XMLWordPrintable

    • Icon: New Feature New Feature
    • Resolution: Unresolved
    • Icon: Major Major
    • p4-plugin
    • None
    • Linux

      My Perforce environment has a requirement that Owner: is defined in the clientspec when creating or modifying a cleint. I don't really understand how this requirement is enforced, just that now, 'p4 client' throws an error if the Owner field is missing from the clientspec. I see a problem with the Perforce plugin is managing the cleint:

      /usr/bin/p4 -s client -i
      Caught exception communicating with perforce. Error in client specification. Missing required field 'Owner'.
      For Command: /usr/bin/p4 -s client -i
      With Data:
      ===================
      Client: XXXXXXXX
      Description:
      Root: /var/lib/jenkins/jobs/XXXXXXXX/workspace
      Options: noallwrite clobber nocompress unlocked nomodtime rmdir
      LineEnd: local
      View:
      //depot/XXXXXXXX/... //XXXXXXXX/...

          [JENKINS-13646] Automatically Created Clients missing Owner: in clientspec

          David Baird created issue -

          Rob Petti added a comment -

          It should default to the current user (which would be the one configured for use with the plugin) so I'm not sure how you managed to get that either...

          What perforce server, client, jenkins and perforce plugin versions are you running?

          Rob Petti added a comment - It should default to the current user (which would be the one configured for use with the plugin) so I'm not sure how you managed to get that either... What perforce server, client, jenkins and perforce plugin versions are you running?
          Rob Petti made changes -
          Assignee New: Rob Petti [ rpetti ]

          David Baird added a comment -

          Jenkins: 1.460
          Perforce Plugin: 1.3.12
          Perforce: P4/LINUX26X86_64/2009.2/238357 (2010/03/15)

          I realize that Perforce will fill in Owner: if it is missing. In our system, however, the Perforce admins have something behind the scenes enforcing that any p4 client -i command supplies the Owner: or it fails. It has something to do with our site security policies.

          Please note also, this only fails when I select "Let Jenkins Create Workspace", so I do have a workaround, to create the client outside of Jenkins. I'd rather that Jenkins create the client spec, since I don't let just any user to login as the account running the Jenkins server, again, a security policy.

          Thanks.

          David Baird added a comment - Jenkins: 1.460 Perforce Plugin: 1.3.12 Perforce: P4/LINUX26X86_64/2009.2/238357 (2010/03/15) I realize that Perforce will fill in Owner: if it is missing. In our system, however, the Perforce admins have something behind the scenes enforcing that any p4 client -i command supplies the Owner: or it fails. It has something to do with our site security policies. Please note also, this only fails when I select "Let Jenkins Create Workspace", so I do have a workaround, to create the client outside of Jenkins. I'd rather that Jenkins create the client spec, since I don't let just any user to login as the account running the Jenkins server, again, a security policy. Thanks.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Rob Petti
          Path:
          src/main/java/hudson/plugins/perforce/PerforceSCM.java
          src/main/resources/hudson/plugins/perforce/PerforceSCM/config.jelly
          src/main/webapp/help/clientOwner.html
          src/test/java/hudson/plugins/perforce/PerforceSCMTest.java
          http://jenkins-ci.org/commit/perforce-plugin/7eab18d8e4256aa8582d1d6cee898b3f7370e328
          Log:
          JENKINS-13646 added 'owner' field to advanced options

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Rob Petti Path: src/main/java/hudson/plugins/perforce/PerforceSCM.java src/main/resources/hudson/plugins/perforce/PerforceSCM/config.jelly src/main/webapp/help/clientOwner.html src/test/java/hudson/plugins/perforce/PerforceSCMTest.java http://jenkins-ci.org/commit/perforce-plugin/7eab18d8e4256aa8582d1d6cee898b3f7370e328 Log: JENKINS-13646 added 'owner' field to advanced options

          dogfood added a comment -

          Integrated in plugins_perforce #222
          JENKINS-13646 added 'owner' field to advanced options (Revision 7eab18d8e4256aa8582d1d6cee898b3f7370e328)

          Result = SUCCESS
          Rob Petti :
          Files :

          • src/main/resources/hudson/plugins/perforce/PerforceSCM/config.jelly
          • src/test/java/hudson/plugins/perforce/PerforceSCMTest.java
          • src/main/webapp/help/clientOwner.html
          • src/main/java/hudson/plugins/perforce/PerforceSCM.java

          dogfood added a comment - Integrated in plugins_perforce #222 JENKINS-13646 added 'owner' field to advanced options (Revision 7eab18d8e4256aa8582d1d6cee898b3f7370e328) Result = SUCCESS Rob Petti : Files : src/main/resources/hudson/plugins/perforce/PerforceSCM/config.jelly src/test/java/hudson/plugins/perforce/PerforceSCMTest.java src/main/webapp/help/clientOwner.html src/main/java/hudson/plugins/perforce/PerforceSCM.java

          Rob Petti added a comment -

          I've just added an option for the owner field to the build here: http://ci.jenkins-ci.org/job/plugins_perforce/222/artifact/target/perforce.hpi

          I haven't had a chance to test it yet, though.

          Rob Petti added a comment - I've just added an option for the owner field to the build here: http://ci.jenkins-ci.org/job/plugins_perforce/222/artifact/target/perforce.hpi I haven't had a chance to test it yet, though.
          Rob Petti made changes -
          Assignee Original: Rob Petti [ rpetti ]
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 144113 ] New: JNJira + In-Review [ 176077 ]
          Jenkins IRC Bot made changes -
          Component/s New: p4-plugin [ 19224 ]
          Component/s Original: perforce-plugin [ 15506 ]

            Unassigned Unassigned
            davidlbaird David Baird
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated: