Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-13902

Default slave should always start out as 'master'

    XMLWordPrintable

Details

    Description

      When adding a node select parameter to a build, the "Select a default slave" dropdown always starts out set to the first alphabetical choice in the list. I think it should always default to "master." At least in my case, the first alphabetical choice is a special slave node that only one job is ever supposed to use, so I have to change this every time I use this feature.

      Attachments

        Activity

          Descending order - Click to sort in ascending order
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: imod
          Path:
          src/main/java/org/jvnet/jenkins/plugins/nodelabelparameter/NodeParameterDefinition.java
          http://jenkins-ci.org/commit/nodelabelparameter-plugin/01b0a3cfeb6c76a89749b879d0918158f51b9473
          Log:
          [FIXED JENKINS-13902] move master up in selection list

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: imod Path: src/main/java/org/jvnet/jenkins/plugins/nodelabelparameter/NodeParameterDefinition.java http://jenkins-ci.org/commit/nodelabelparameter-plugin/01b0a3cfeb6c76a89749b879d0918158f51b9473 Log: [FIXED JENKINS-13902] move master up in selection list
          domi Dominik Bartholdi added a comment -

          Ok, I see what you mean, makes sense
          ...done

          domi Dominik Bartholdi added a comment - Ok, I see what you mean, makes sense ...done
          owenmehegan Owen Mehegan added a comment -

          I'm referring to the menu setting as it appears when you configure the parameter. I think the "Select a default slave" dropdown in the parameter configuration should always start out set to master - it seems logical to me that in most cases you would want to use your master node by default, and then add some other nodes as well. What I'm suggesting will reduce the number of things you need to change every time you add a node parameter to a job.

          owenmehegan Owen Mehegan added a comment - I'm referring to the menu setting as it appears when you configure the parameter. I think the "Select a default slave" dropdown in the parameter configuration should always start out set to master - it seems logical to me that in most cases you would want to use your master node by default, and then add some other nodes as well. What I'm suggesting will reduce the number of things you need to change every time you add a node parameter to a job.
          domi Dominik Bartholdi added a comment -

          The first in the dropdown is allways the one you have defined as the default slave in your parameter definition - so if you have defined your special node as the default, then this is the reason why.
          Just set 'master' as the default and you should be fine...

          domi Dominik Bartholdi added a comment - The first in the dropdown is allways the one you have defined as the default slave in your parameter definition - so if you have defined your special node as the default, then this is the reason why. Just set 'master' as the default and you should be fine...

          People

            domi Dominik Bartholdi
            owenmehegan Owen Mehegan
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: