[JENKINS-14164] slave-setup tries to execute empty script

Since slave-setup plugin has "prepare script" and "setup script after copy", it fails on windows under these circumstances:

Neither master nor slaves have sh shell (path or jenkins configured).
"prepare script" and "setup script after copy" are empty.
Plugin try to find sh in path to execute the empty script (thus fails).
[I don't need any script execution, but just a directory copy]

Fix proposal:
Don't try to execute empty scripts:
125c125
< if (cmdLine != null) {
—
> if (cmdLine != null && !cmdLine.isEmpty()) {

j_v created issue - 2012-06-20 16:26

Frederik Fromm made changes - 2012-07-09 08:42

Assignee

Original: Kohsuke Kawaguchi [ kohsuke ]

New: Frederik Fromm [ ffromm ]

fixed with version 1.6

Frederik Fromm added a comment - 2012-07-09 08:43 fixed with version 1.6

Frederik Fromm made changes - 2012-07-09 08:43

R. Tyler Croy made changes - 2016-07-25 23:54

Workflow

Original: JNJira [ 144795 ]

New: JNJira + In-Review [ 191186 ]

Jenkins