• Icon: New Feature New Feature
    • Resolution: Won't Fix
    • Icon: Minor Minor
    • analysis-core-plugin
    • None

      My actual requirements are pretty simple:

      • All jobs on Continuous Integration can be easily configured to use the same trending settings
      • All jobs on Public Dashboard can be easily configured to use the same trending settings (we use the build-publisher plugin to push some of our jobs from CI to the dashboard)
      • Make this possible for PMD and my own custom (AppScan) subclass of the hudson.plugins.analysis.core.PluginDescriptor (these are the only two analysis-core plugins we use at this time)
      • Possible (lower priority) requirement - in some cases we may want to have custom settings for some jobs

      Your suggestion to have a global configuration would be perfect for what I really need at this time. If the "*.txt" file doesn't exist, it could fall back on the global configuration. Because I have created my own PluginDescriptor, it would be nice if the global configuration could apply across all extensions, or else make it very easy for me to hook into that global config.

      This feature makes not only sense for graphs but also for all other aspects of the plug-ins.

          [JENKINS-14185] Provide global configuration of settings

          Ulli Hafner added a comment -

          Hmm, I don't think that there is an extension point available for that action which I can overwrite...

          Ulli Hafner added a comment - Hmm, I don't think that there is an extension point available for that action which I can overwrite...

          I notice this other issue which is related, because the pmd.txt is not being published when I publish these jobs to our public dashboard, which we also want to have configured correctly with the right trending settings.

          https://issues.jenkins-ci.org/browse/JENKINS-4555

          More generally - why do these plugins persist their settings to a text file instead of config.xml? If this behavior was changed it would fix these behaviors completely, because then these settings would be part of the object model instead of being "special". I have the same problem for an in-house extension to analysis-core that we use. It creates a ".txt" file that we want copied and published, but it doesn't do that.

          Jacob Robertson added a comment - I notice this other issue which is related, because the pmd.txt is not being published when I publish these jobs to our public dashboard, which we also want to have configured correctly with the right trending settings. https://issues.jenkins-ci.org/browse/JENKINS-4555 More generally - why do these plugins persist their settings to a text file instead of config.xml? If this behavior was changed it would fix these behaviors completely, because then these settings would be part of the object model instead of being "special". I have the same problem for an in-house extension to analysis-core that we use. It creates a ".txt" file that we want copied and published, but it doesn't do that.

          Ulli Hafner added a comment -

          Well, the reason is that I can't access the global config.xml file when I'm not in the job configuration transaction. Since the graphs are configured in a separate view, I need to persist them manually.

          What is your actual requirement? Would it help if we have a global (system wide) configuration of the graphs?

          Ulli Hafner added a comment - Well, the reason is that I can't access the global config.xml file when I'm not in the job configuration transaction. Since the graphs are configured in a separate view, I need to persist them manually. What is your actual requirement? Would it help if we have a global (system wide) configuration of the graphs?

          My actual requirements are pretty simple

          • All jobs on Continuous Integration can be easily configured to use the same trending settings
          • All jobs on Public Dashboard can be easily configured to use the same trending settings (we use the build-publisher plugin to push some of our jobs from CI to the dashboard)
          • Make this possible for PMD and my own custom (AppScan) subclass of the hudson.plugins.analysis.core.PluginDescriptor (these are the only two analysis-core plugins we use at this time)
          • Possible (lower priority) requirement - in some cases we may want to have custom settings for some jobs

          Your suggestion to have a global configuration would be perfect for what I really need at this time. If the "*.txt" file doesn't exist, it could fall back on the global configuration. Because I have created my own PluginDescriptor, it would be nice if the global configuration could apply across all extensions, or else make it very easy for me to hook into that global config.

          Jacob Robertson added a comment - My actual requirements are pretty simple All jobs on Continuous Integration can be easily configured to use the same trending settings All jobs on Public Dashboard can be easily configured to use the same trending settings (we use the build-publisher plugin to push some of our jobs from CI to the dashboard) Make this possible for PMD and my own custom (AppScan) subclass of the hudson.plugins.analysis.core.PluginDescriptor (these are the only two analysis-core plugins we use at this time) Possible (lower priority) requirement - in some cases we may want to have custom settings for some jobs Your suggestion to have a global configuration would be perfect for what I really need at this time. If the "*.txt" file doesn't exist, it could fall back on the global configuration. Because I have created my own PluginDescriptor, it would be nice if the global configuration could apply across all extensions, or else make it very easy for me to hook into that global config.

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          src/main/java/hudson/plugins/analysis/core/AnalysisConfiguration.java
          src/main/java/hudson/plugins/analysis/core/ConfigurationReference.java
          src/main/java/hudson/plugins/analysis/core/GlobalSettings.java
          src/main/java/hudson/plugins/analysis/core/HealthAwareRecorder.java
          src/main/java/hudson/plugins/analysis/core/PluginDescriptor.java
          src/main/java/hudson/plugins/analysis/core/SerializableSettings.java
          src/main/java/hudson/plugins/analysis/core/Settings.java
          src/main/resources/hudson/plugins/analysis/Messages.properties
          src/main/resources/hudson/plugins/analysis/core/AnalysisConfiguration/config.jelly
          src/main/resources/hudson/plugins/analysis/core/ConfigurationReference/GlobalConfigurationReference/config.jelly
          src/main/resources/hudson/plugins/analysis/core/ConfigurationReference/LocalConfigurationReference/config.jelly
          src/main/resources/hudson/plugins/analysis/core/GlobalSettings/global.jelly
          src/main/resources/util/configselect.jelly
          src/main/resources/util/defaultEncoding.jelly
          src/main/resources/util/globalconfig.jelly
          src/main/resources/util/health.jelly
          src/main/resources/util/thresholds.jelly
          src/test/java/hudson/plugins/analysis/core/GlobalSettingsTest.java
          src/test/java/hudson/plugins/analysis/core/SerializableSettingsTest.java
          http://jenkins-ci.org/commit/analysis-core-plugin/2840c1a3db6a57e6a2e34daa1d38fc561819c0a5
          Log:
          JENKINS-14185 Added basic implementation of global configuration.

          In Jenkins global settings new treshold configurations can be added.
          In a job configuration either a global configuration or a job local
          configuration can be selected.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: src/main/java/hudson/plugins/analysis/core/AnalysisConfiguration.java src/main/java/hudson/plugins/analysis/core/ConfigurationReference.java src/main/java/hudson/plugins/analysis/core/GlobalSettings.java src/main/java/hudson/plugins/analysis/core/HealthAwareRecorder.java src/main/java/hudson/plugins/analysis/core/PluginDescriptor.java src/main/java/hudson/plugins/analysis/core/SerializableSettings.java src/main/java/hudson/plugins/analysis/core/Settings.java src/main/resources/hudson/plugins/analysis/Messages.properties src/main/resources/hudson/plugins/analysis/core/AnalysisConfiguration/config.jelly src/main/resources/hudson/plugins/analysis/core/ConfigurationReference/GlobalConfigurationReference/config.jelly src/main/resources/hudson/plugins/analysis/core/ConfigurationReference/LocalConfigurationReference/config.jelly src/main/resources/hudson/plugins/analysis/core/GlobalSettings/global.jelly src/main/resources/util/configselect.jelly src/main/resources/util/defaultEncoding.jelly src/main/resources/util/globalconfig.jelly src/main/resources/util/health.jelly src/main/resources/util/thresholds.jelly src/test/java/hudson/plugins/analysis/core/GlobalSettingsTest.java src/test/java/hudson/plugins/analysis/core/SerializableSettingsTest.java http://jenkins-ci.org/commit/analysis-core-plugin/2840c1a3db6a57e6a2e34daa1d38fc561819c0a5 Log: JENKINS-14185 Added basic implementation of global configuration. In Jenkins global settings new treshold configurations can be added. In a job configuration either a global configuration or a job local configuration can be selected.

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          pom.xml
          src/main/java/hudson/plugins/warnings/WarningsPublisher.java
          src/main/resources/hudson/plugins/warnings/WarningsPublisher/config.jelly
          src/test/java/hudson/plugins/warnings/WarningsPublisherTest.java
          http://jenkins-ci.org/commit/warnings-plugin/81686de00a802ee6134126178316ab8036ffdb50
          Log:
          JENKINS-14185 Use new API to select global or local configuration.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: pom.xml src/main/java/hudson/plugins/warnings/WarningsPublisher.java src/main/resources/hudson/plugins/warnings/WarningsPublisher/config.jelly src/test/java/hudson/plugins/warnings/WarningsPublisherTest.java http://jenkins-ci.org/commit/warnings-plugin/81686de00a802ee6134126178316ab8036ffdb50 Log: JENKINS-14185 Use new API to select global or local configuration.

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          src/main/resources/hudson/plugins/analysis/core/AnalysisConfiguration/config.properties
          src/main/resources/hudson/plugins/analysis/core/AnalysisConfiguration/config_de.properties
          src/main/resources/hudson/plugins/analysis/core/GlobalSettings/global.jelly
          src/main/resources/hudson/plugins/analysis/core/GlobalSettings/global.properties
          src/main/resources/hudson/plugins/analysis/core/GlobalSettings/global_de.properties
          src/main/resources/util/configselect.jelly
          src/main/resources/util/configselect.properties
          src/main/resources/util/configselect_de.properties
          src/main/resources/util/globalconfig.properties
          src/main/resources/util/globalconfig_de.properties
          src/main/resources/util/thresholds.properties
          http://jenkins-ci.org/commit/analysis-core-plugin/e8bf357f3788b78085f863000627dfaea08c6c6a
          Log:
          JENKINS-14185 Added descriptions.

          Compare: https://github.com/jenkinsci/analysis-core-plugin/compare/2840c1a3db6a...e8bf357f3788

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: src/main/resources/hudson/plugins/analysis/core/AnalysisConfiguration/config.properties src/main/resources/hudson/plugins/analysis/core/AnalysisConfiguration/config_de.properties src/main/resources/hudson/plugins/analysis/core/GlobalSettings/global.jelly src/main/resources/hudson/plugins/analysis/core/GlobalSettings/global.properties src/main/resources/hudson/plugins/analysis/core/GlobalSettings/global_de.properties src/main/resources/util/configselect.jelly src/main/resources/util/configselect.properties src/main/resources/util/configselect_de.properties src/main/resources/util/globalconfig.properties src/main/resources/util/globalconfig_de.properties src/main/resources/util/thresholds.properties http://jenkins-ci.org/commit/analysis-core-plugin/e8bf357f3788b78085f863000627dfaea08c6c6a Log: JENKINS-14185 Added descriptions. Compare: https://github.com/jenkinsci/analysis-core-plugin/compare/2840c1a3db6a...e8bf357f3788

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          src/main/resources/hudson/plugins/warnings/ParserConfiguration/config.jelly
          src/main/resources/hudson/plugins/warnings/ParserConfiguration/config.properties
          src/main/resources/hudson/plugins/warnings/ParserConfiguration/config_de.properties
          src/main/resources/hudson/plugins/warnings/ParserConfiguration/config_ja.properties
          src/main/resources/hudson/plugins/warnings/WarningsPublisher/config.jelly
          src/main/resources/hudson/plugins/warnings/WarningsPublisher/config.properties
          src/main/resources/hudson/plugins/warnings/WarningsPublisher/config_de.properties
          src/main/resources/hudson/plugins/warnings/WarningsPublisher/config_ja.properties
          src/main/resources/parser/parser.jelly
          http://jenkins-ci.org/commit/warnings-plugin/2415687ef61fb5a73adfcffe9879aac562e2e435
          Log:
          JENKINS-14185 Added descriptions.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: src/main/resources/hudson/plugins/warnings/ParserConfiguration/config.jelly src/main/resources/hudson/plugins/warnings/ParserConfiguration/config.properties src/main/resources/hudson/plugins/warnings/ParserConfiguration/config_de.properties src/main/resources/hudson/plugins/warnings/ParserConfiguration/config_ja.properties src/main/resources/hudson/plugins/warnings/WarningsPublisher/config.jelly src/main/resources/hudson/plugins/warnings/WarningsPublisher/config.properties src/main/resources/hudson/plugins/warnings/WarningsPublisher/config_de.properties src/main/resources/hudson/plugins/warnings/WarningsPublisher/config_ja.properties src/main/resources/parser/parser.jelly http://jenkins-ci.org/commit/warnings-plugin/2415687ef61fb5a73adfcffe9879aac562e2e435 Log: JENKINS-14185 Added descriptions.

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          src/main/java/hudson/plugins/analysis/core/AnalysisConfiguration.java
          src/main/java/hudson/plugins/analysis/core/ConfigurationReference.java
          src/main/java/hudson/plugins/analysis/core/GlobalSettings.java
          src/main/java/hudson/plugins/analysis/core/HealthAwareRecorder.java
          src/main/java/hudson/plugins/analysis/core/PluginDescriptor.java
          src/main/java/hudson/plugins/analysis/core/SerializableSettings.java
          src/main/java/hudson/plugins/analysis/core/Settings.java
          src/main/resources/hudson/plugins/analysis/Messages.properties
          src/main/resources/hudson/plugins/analysis/core/AnalysisConfiguration/config.jelly
          src/main/resources/hudson/plugins/analysis/core/ConfigurationReference/GlobalConfigurationReference/config.jelly
          src/main/resources/hudson/plugins/analysis/core/ConfigurationReference/LocalConfigurationReference/config.jelly
          src/main/resources/hudson/plugins/analysis/core/GlobalSettings/global.jelly
          src/main/resources/util/configselect.jelly
          src/main/resources/util/globalconfig.jelly
          src/test/java/hudson/plugins/analysis/core/GlobalSettingsTest.java
          src/test/java/hudson/plugins/analysis/core/SerializableSettingsTest.java
          http://jenkins-ci.org/commit/analysis-core-plugin/4aa81751a009feedf146486ae14f752abf5f140b
          Log:
          JENKINS-14185 Added basic implementation of global configuration.

          In Jenkins global settings new treshold configurations can be added.
          In a job configuration either a global configuration or a job local
          configuration can be selected.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: src/main/java/hudson/plugins/analysis/core/AnalysisConfiguration.java src/main/java/hudson/plugins/analysis/core/ConfigurationReference.java src/main/java/hudson/plugins/analysis/core/GlobalSettings.java src/main/java/hudson/plugins/analysis/core/HealthAwareRecorder.java src/main/java/hudson/plugins/analysis/core/PluginDescriptor.java src/main/java/hudson/plugins/analysis/core/SerializableSettings.java src/main/java/hudson/plugins/analysis/core/Settings.java src/main/resources/hudson/plugins/analysis/Messages.properties src/main/resources/hudson/plugins/analysis/core/AnalysisConfiguration/config.jelly src/main/resources/hudson/plugins/analysis/core/ConfigurationReference/GlobalConfigurationReference/config.jelly src/main/resources/hudson/plugins/analysis/core/ConfigurationReference/LocalConfigurationReference/config.jelly src/main/resources/hudson/plugins/analysis/core/GlobalSettings/global.jelly src/main/resources/util/configselect.jelly src/main/resources/util/globalconfig.jelly src/test/java/hudson/plugins/analysis/core/GlobalSettingsTest.java src/test/java/hudson/plugins/analysis/core/SerializableSettingsTest.java http://jenkins-ci.org/commit/analysis-core-plugin/4aa81751a009feedf146486ae14f752abf5f140b Log: JENKINS-14185 Added basic implementation of global configuration. In Jenkins global settings new treshold configurations can be added. In a job configuration either a global configuration or a job local configuration can be selected.

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          src/main/resources/hudson/plugins/analysis/core/AnalysisConfiguration/config.properties
          src/main/resources/hudson/plugins/analysis/core/AnalysisConfiguration/config_de.properties
          src/main/resources/hudson/plugins/analysis/core/GlobalSettings/global.jelly
          src/main/resources/hudson/plugins/analysis/core/GlobalSettings/global.properties
          src/main/resources/hudson/plugins/analysis/core/GlobalSettings/global_de.properties
          src/main/resources/util/configselect.jelly
          src/main/resources/util/configselect.properties
          src/main/resources/util/configselect_de.properties
          src/main/resources/util/globalconfig.properties
          src/main/resources/util/globalconfig_de.properties
          src/main/resources/util/thresholds.properties
          http://jenkins-ci.org/commit/analysis-core-plugin/c2fd411abd76d2022be4dd47142a23415b3442f9
          Log:
          JENKINS-14185 Added descriptions.

          Compare: https://github.com/jenkinsci/analysis-core-plugin/compare/4aa81751a009^...c2fd411abd76

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: src/main/resources/hudson/plugins/analysis/core/AnalysisConfiguration/config.properties src/main/resources/hudson/plugins/analysis/core/AnalysisConfiguration/config_de.properties src/main/resources/hudson/plugins/analysis/core/GlobalSettings/global.jelly src/main/resources/hudson/plugins/analysis/core/GlobalSettings/global.properties src/main/resources/hudson/plugins/analysis/core/GlobalSettings/global_de.properties src/main/resources/util/configselect.jelly src/main/resources/util/configselect.properties src/main/resources/util/configselect_de.properties src/main/resources/util/globalconfig.properties src/main/resources/util/globalconfig_de.properties src/main/resources/util/thresholds.properties http://jenkins-ci.org/commit/analysis-core-plugin/c2fd411abd76d2022be4dd47142a23415b3442f9 Log: JENKINS-14185 Added descriptions. Compare: https://github.com/jenkinsci/analysis-core-plugin/compare/4aa81751a009 ^...c2fd411abd76

          Am I right that this feature will be available on 2.0?
          Really looking forward!
          If I could help with some testing or something else let me know.

          Benjamin Fuchs added a comment - Am I right that this feature will be available on 2.0? Really looking forward! If I could help with some testing or something else let me know.

          Benjamin Fuchs added a comment - - edited

          Could this also be extended to globally configure the default Trend Graph settings?
          My main requirement would be just to change the default graph so it can be set to "NONE".

          Benjamin Fuchs added a comment - - edited Could this also be extended to globally configure the default Trend Graph settings? My main requirement would be just to change the default graph so it can be set to "NONE".

          Maybe this can be included to the global settings:

          https://github.com/jenkinsci/analysis-core-plugin/pull/46

          Benjamin Fuchs added a comment - Maybe this can be included to the global settings: https://github.com/jenkinsci/analysis-core-plugin/pull/46

          Ulli Hafner added a comment -

          Partially implemented for pipelines. No support for freestyle and maven builds so far.

          Ulli Hafner added a comment - Partially implemented for pipelines. No support for freestyle and maven builds so far.

          Ulli Hafner added a comment -

          The use case basically is supported by using a shared pipeline script.

          Ulli Hafner added a comment - The use case basically is supported by using a shared pipeline script.

            drulli Ulli Hafner
            jacob_robertson Jacob Robertson
            Votes:
            3 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved: