Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-14303

Config changes are logged even when job saved with no changes

    XMLWordPrintable

Details

    Description

      Wasn't sure whether this was a bug or by design, but would it not make more sense to only log changes when the config files has actually been altered (as opposed to simply saved)?

      Not such a large concern when all changes are made by people, but when using a plugin that alters config.xml programmatically, lots of noise can accumulate in the change log. In particular, the build description setter plugin saves the job configs on each run.

      Thanks!

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          patcon Patrick Connolly created issue -
          mfriedenhagen Mirko Friedenhagen added a comment -

          I think we had a good reason but I do not remember it anymore :-D

          mfriedenhagen Mirko Friedenhagen added a comment - I think we had a good reason but I do not remember it anymore :-D
          mfriedenhagen Mirko Friedenhagen made changes -
          Field Original Value New Value
          Assignee Mirko Friedenhagen [ mfriedenhagen ] Stefan Brausch [ stefanbrausch ]
          stefanbrausch Stefan Brausch added a comment -

          You should configure the plugin that it not save duplicate configuration files.
          This could help you.

          Description: Do not save the history if there is no change from the previous saved configuration. Duplicate history is often saved if the save option is selected after viewing a configuration without making any adjustments.
          It is also common for system-level settings, as all system settings are saved again when the main configuration page is saved.

          stefanbrausch Stefan Brausch added a comment - You should configure the plugin that it not save duplicate configuration files. This could help you. Description: Do not save the history if there is no change from the previous saved configuration. Duplicate history is often saved if the save option is selected after viewing a configuration without making any adjustments. It is also common for system-level settings, as all system settings are saved again when the main configuration page is saved.
          marc_guenther Marc Günther added a comment -

          Why isn't that setting enabled by default? Why would we ever want to save duplicate history configs?

          marc_guenther Marc Günther added a comment - Why isn't that setting enabled by default? Why would we ever want to save duplicate history configs?
          kstutz Kathi Stutz added a comment -

          "Skip duplicate history" will be enabled by default in the next version of the plugin (2.3), which will be released sometime in February.

          kstutz Kathi Stutz added a comment - "Skip duplicate history" will be enabled by default in the next version of the plugin (2.3), which will be released sometime in February.
          kstutz Kathi Stutz added a comment -

          Version 2.3 has been relased two days ago.

          kstutz Kathi Stutz added a comment - Version 2.3 has been relased two days ago.
          kstutz Kathi Stutz made changes -
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]
          kstutz Kathi Stutz made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 144935 ] JNJira + In-Review [ 205973 ]

          People

            stefanbrausch Stefan Brausch
            patcon Patrick Connolly
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: