Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-14500

Do not send "improvement" email if build is fixed

    XMLWordPrintable

Details

    Description

      Currently, the email-ext plugin sends emails as follows:

      Improvement - An email will be sent any time there is an improvement. A build is considered to have improved whenever it has fewer failures than the previous build.
      Fixed - An email will be sent when the build status changes from "Failure" or "Unstable" to "Successful".

      However, there is an ovelap between these two conditions. If both triggers are configured, and a build changes from "failing tests" to "no failing tests", then two emails are sent.

      Improvement should mean that the number of failing tests decreased, but some were still failing. "Fixed" should mean all tests were fixed.

      Thanks

      Attachments

        Activity

          mwebber Matthew Webber created issue -
          slide_o_mix Alex Earl added a comment - - edited

          The only problem with this is that the improvement trigger has no idea that the success trigger is configured.

          Was really tired, it doesn't need to know if the fixed trigger is configured.

          slide_o_mix Alex Earl added a comment - - edited The only problem with this is that the improvement trigger has no idea that the success trigger is configured. Was really tired, it doesn't need to know if the fixed trigger is configured.

          Code changed in jenkins
          User: slide
          Path:
          src/main/java/hudson/plugins/emailext/plugins/trigger/ImprovementTrigger.java
          http://jenkins-ci.org/commit/email-ext-plugin/a82a1c9b2bbd9edd4fba78f95f012d8efe494a04
          Log:
          Fix JENKINS-14500

          • Added a check to see if there are ANY failures, if not then don't send an improvement email.
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: slide Path: src/main/java/hudson/plugins/emailext/plugins/trigger/ImprovementTrigger.java http://jenkins-ci.org/commit/email-ext-plugin/a82a1c9b2bbd9edd4fba78f95f012d8efe494a04 Log: Fix JENKINS-14500 Added a check to see if there are ANY failures, if not then don't send an improvement email.
          slide_o_mix Alex Earl made changes -
          Field Original Value New Value
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]

          That's exactly what I was after. Thanks for your quick response, I'll try it as soon as it's released.

          mwebber Matthew Webber added a comment - That's exactly what I was after. Thanks for your quick response, I'll try it as soon as it's released.
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 145136 ] JNJira + In-Review [ 191370 ]

          People

            slide_o_mix Alex Earl
            mwebber Matthew Webber
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: