• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core

      war/src/main/webapp/css/style.css has various CSS errors as reported by HtmlUnit, such as

      filter: alpha(opacity=40); /* msie */
      -ms-filter: "progid:DXImageTransform.Microsoft.Alpha(Opacity=50)";
      

      These clutter log output when running HudsonTestCase/JenkinsRule tests, and might confuse standards-compliant browsers. Perhaps better to split browser-specific hacks into separate CSS files inserted only when the client identifies itself as that browser.

          [JENKINS-14749] Errors in styles.css

          Jesse Glick created issue -
          Pedro Rodriguez made changes -
          Assignee New: Pedro Rodriguez [ nacht ]
          Pedro Rodriguez made changes -
          Assignee Original: Pedro Rodriguez [ nacht ]

          evernat added a comment -

          Hi jglick,
          Now that css3 is almost main stream, is it OK to remove IE filter from style.css?

          evernat added a comment - Hi jglick , Now that css3 is almost main stream, is it OK to remove IE filter from style.css?

          Jesse Glick added a comment -

          @evernat perhaps; I really have no idea what this particular entry is for, or which versions of IE need it. (I know people still routinely use Jenkins with IE 9, maybe even 8.) In any event, my original suggestion of splitting browser-specific entries into dynamically inserted stylesheets would suppress the test warnings and probably also suppress warnings from modern browsers which no longer require the hacks.

          Jesse Glick added a comment - @evernat perhaps; I really have no idea what this particular entry is for, or which versions of IE need it. (I know people still routinely use Jenkins with IE 9, maybe even 8.) In any event, my original suggestion of splitting browser-specific entries into dynamically inserted stylesheets would suppress the test warnings and probably also suppress warnings from modern browsers which no longer require the hacks.

          evernat added a comment -

          after a google search,

          • opacity: 0.5; works since IE9 and in all modern browsers.
          • filter: alpha(opacity=50); works for IE8 and before
          • -ms-filter: "progid:DXImageTransform.Microsoft.Alpha(Opacity=50)"; also works for IE8 and before

          IE8 is certainly used only by users still having Windows XP, because they can't upgrade to IE9. But Windows XP is EOL and not supported anymore since yesterday. So IE8 usage will now drop fast like Windows XP usage.

          So I think that we can remove both -ms-filter and filter: alpha lines.

          evernat added a comment - after a google search, opacity: 0.5; works since IE9 and in all modern browsers. filter: alpha(opacity=50); works for IE8 and before -ms-filter: "progid:DXImageTransform.Microsoft.Alpha(Opacity=50)"; also works for IE8 and before IE8 is certainly used only by users still having Windows XP, because they can't upgrade to IE9. But Windows XP is EOL and not supported anymore since yesterday. So IE8 usage will now drop fast like Windows XP usage. So I think that we can remove both -ms-filter and filter: alpha lines.

          Jesse Glick added a comment -

          FWIW, a quick (~3min) search of support tickets from CloudBees customers reveals five companies (before I stopped counting) who are using IE 8 to access Jenkins. Some of these explicitly state (by way of apology) that IE 8 is the corporate IT mandate. So I doubt we can drop support for it so casually. Of course inessential aspects of its rendering could be skipped so long as the page view is still functional, if that simplifies the CSS.

          Jesse Glick added a comment - FWIW, a quick (~3min) search of support tickets from CloudBees customers reveals five companies (before I stopped counting) who are using IE 8 to access Jenkins. Some of these explicitly state (by way of apology) that IE 8 is the corporate IT mandate. So I doubt we can drop support for it so casually. Of course inessential aspects of its rendering could be skipped so long as the page view is still functional, if that simplifies the CSS.

          evernat added a comment -

          Forcing usage of a dinosaur like IE8, would need apologies indeed, even on the now officially dead Windows XP.

          evernat added a comment - Forcing usage of a dinosaur like IE8, would need apologies indeed, even on the now officially dead Windows XP.

          Jesse Glick added a comment -

          I think Tom is best placed to work on this at the moment.

          Jesse Glick added a comment - I think Tom is best placed to work on this at the moment.
          Jesse Glick made changes -
          Assignee New: Tom FENNELLY [ tfennelly ]

            basil Basil Crow
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: