Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-14759

Job created by posting config.xml to /createItem does not set GitHub webhook

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core, github-plugin
    • None

      If job is created by posting config.xml, even "build when a change is pushed on github" is checked in config, no hook is registered on github.

          [JENKINS-14759] Job created by posting config.xml to /createItem does not set GitHub webhook

          Nicolas De Loof created issue -

          Nicolas De Loof added a comment - - edited

          PushTrigger.start only set the hook for newInstance=true, but for jobs created from posting config.xml item.onLoad() is used, so newInstance=false
          This may require a fix in jenkins core ?

          Nicolas De Loof added a comment - - edited PushTrigger.start only set the hook for newInstance=true, but for jobs created from posting config.xml item.onLoad() is used, so newInstance=false This may require a fix in jenkins core ?
          Nicolas De Loof made changes -
          Resolution New: Cannot Reproduce [ 5 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]
          Nicolas De Loof made changes -
          Description Original: If job is created and later updated to "build when a change is pushed on github", no hook is registered on github and plugin silently ignore the setting.

          PushTrigger.start only set the hook for newInstance=true.
          New: If job is created by posting config.xml, even "build when a change is pushed on github" is checked in config, no hook is registered on github.

          PushTrigger.start only set the hook for newInstance=true, but for jobs created this way value is false.
          Priority Original: Major [ 3 ] New: Minor [ 4 ]
          Summary Original: when configured after job creation, webhook is not set on github New: Job created by posting config.xml to /creatIem don't get webhook set on github
          Nicolas De Loof made changes -
          Component/s New: core [ 15593 ]
          Component/s Original: github [ 15896 ]
          Description Original: If job is created by posting config.xml, even "build when a change is pushed on github" is checked in config, no hook is registered on github.

          PushTrigger.start only set the hook for newInstance=true, but for jobs created this way value is false.
          New: If job is created by posting config.xml, even "build when a change is pushed on github" is checked in config, no hook is registered on github.
          Nicolas De Loof made changes -
          Resolution Original: Cannot Reproduce [ 5 ]
          Status Original: Resolved [ 5 ] New: Reopened [ 4 ]
          Jesse Glick made changes -
          Summary Original: Job created by posting config.xml to /creatIem don't get webhook set on github New: Job created by posting config.xml to /createItem does not set GitHub webhook
          Jesse Glick made changes -
          Component/s New: github [ 15896 ]
          Jesse Glick made changes -
          Assignee Original: Nicolas De Loof [ ndeloof ] New: Jesse Glick [ jglick ]

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          core/src/main/java/hudson/model/AbstractItem.java
          core/src/main/java/hudson/model/AbstractProject.java
          core/src/main/java/hudson/model/ItemGroupMixIn.java
          core/src/main/java/hudson/model/Items.java
          core/src/main/java/hudson/triggers/Trigger.java
          test/pom.xml
          test/src/test/java/hudson/triggers/TriggerStartTest.java
          http://jenkins-ci.org/commit/jenkins/597ea1e6a2c8ec9aac432b6955417afb76588398
          Log:
          [FIXED JENKINS-14759] Job created by posting config.xml to /createItem does not set GitHub webhook.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/model/AbstractItem.java core/src/main/java/hudson/model/AbstractProject.java core/src/main/java/hudson/model/ItemGroupMixIn.java core/src/main/java/hudson/model/Items.java core/src/main/java/hudson/triggers/Trigger.java test/pom.xml test/src/test/java/hudson/triggers/TriggerStartTest.java http://jenkins-ci.org/commit/jenkins/597ea1e6a2c8ec9aac432b6955417afb76588398 Log: [FIXED JENKINS-14759] Job created by posting config.xml to /createItem does not set GitHub webhook.
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Reopened [ 4 ] New: Resolved [ 5 ]

            jglick Jesse Glick
            ndeloof Nicolas De Loof
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: