[JENKINS-14900] Copying from workspace drops files matching Ant's default excludes

Type: Bug
Resolution: Fixed
Priority: Major
Component/s: copyartifact-plugin
Labels:
None

Similar Issues:
Powered by SuggestiMate

Show

is duplicated by

JENKINS-17880 Not all files are copied.

Closed

is related to

JENKINS-13165 Cloning workspace loses hidden files/directories

Resolved

relates to

JENKINS-22637 "Copy Artifacts Plugin" should support ArtifactManager

Closed

Dave Hunt added a comment - 2012-08-22 21:24

With Jenkins 1.455 the plugin was successfully copying a workspace that contained a Mercurial repository. It appears that since ~~JENKINS-9118~~ was resolved and Ant was upgraded to 1.8.3 the default excludes now cover Mercurial's repository files, and therefore the files are not being copied. This is similar to ~~JENKINS-13888~~ for the Clone Workspace plugin, and may similarly require a change to Jenkins core.

Dave Hunt added a comment - 2012-08-22 21:24 With Jenkins 1.455 the plugin was successfully copying a workspace that contained a Mercurial repository. It appears that since JENKINS-9118 was resolved and Ant was upgraded to 1.8.3 the default excludes now cover Mercurial's repository files, and therefore the files are not being copied. This is similar to JENKINS-13888 for the Clone Workspace plugin, and may similarly require a change to Jenkins core.

Dave Hunt added a comment - 2012-10-19 13:00

Pull request with failing test that demonstrates this issue is here: https://github.com/jenkinsci/copyartifact-plugin/pull/12

This is preventing us from upgrading Jenkins past version 1.455 (March 2012)

Dave Hunt added a comment - 2012-10-19 13:00 Pull request with failing test that demonstrates this issue is here: https://github.com/jenkinsci/copyartifact-plugin/pull/12 This is preventing us from upgrading Jenkins past version 1.455 (March 2012)

Alan Harder added a comment - 2012-10-19 16:17

sorry, haven't worked on jenkins in a couple years

Alan Harder added a comment - 2012-10-19 16:17 sorry, haven't worked on jenkins in a couple years

Dave Hunt added a comment - 2012-10-19 16:30

Apologies if this is the wrong person to assign to - I was going by recent commits to this plugin.

Dave Hunt added a comment - 2012-10-19 16:30 Apologies if this is the wrong person to assign to - I was going by recent commits to this plugin.

Jesse Glick added a comment - 2012-10-23 15:29

I did fix one bug in the plugin, but I do not consider myself a maintainer of it.

Jesse Glick added a comment - 2012-10-23 15:29 I did fix one bug in the plugin, but I do not consider myself a maintainer of it.

Dave Hunt added a comment - 2013-01-08 19:42

Another attempt at assigning based on commit history. Hoping to find someone that can fix this or at least mentor me to fix it.

Dave Hunt added a comment - 2013-01-08 19:42 Another attempt at assigning based on commit history. Hoping to find someone that can fix this or at least mentor me to fix it.

Fred G added a comment - 2013-01-09 00:55

Same here, sorry. I fixed a few bugs, but I'm not the maintainer.

I'll try to have a look at it, but can't promise anything.
Your best bet is trying to fix it yourself.

Fred G added a comment - 2013-01-09 00:55 Same here, sorry. I fixed a few bugs, but I'm not the maintainer. I'll try to have a look at it, but can't promise anything. Your best bet is trying to fix it yourself.

Dave Hunt added a comment - 2013-01-09 10:54

I was afraid you'd say that Fred! I would appreciate you looking at this and giving me any pointers. I have already attempted to fix it myself, but so far had little success.

Dave Hunt added a comment - 2013-01-09 10:54 I was afraid you'd say that Fred! I would appreciate you looking at this and giving me any pointers. I have already attempted to fix it myself, but so far had little success.

ikedam added a comment - 2014-07-13 06:51

https://github.com/jenkinsci/copyartifact-plugin/pull/42

Fix for this issue should be introduced with fix for ~~JENKINS-18662~~.

ikedam added a comment - 2014-07-13 06:51 https://github.com/jenkinsci/copyartifact-plugin/pull/42 Fix for this issue should be introduced with fix for JENKINS-18662 .

SCM/JIRA link daemon added a comment - 2014-07-20 23:47

Code changed in jenkins
User: Dave Hunt
Path:
pom.xml
src/test/java/hudson/plugins/copyartifact/CopyArtifactTest.java
http://jenkins-ci.org/commit/copyartifact-plugin/ecfa6f42aaf6c1bc40db7cd93703c733d152fed7
Log:
Failing test for ~~JENKINS-14900~~.

SCM/JIRA link daemon added a comment - 2014-07-20 23:47 Code changed in jenkins User: Dave Hunt Path: pom.xml src/test/java/hudson/plugins/copyartifact/CopyArtifactTest.java http://jenkins-ci.org/commit/copyartifact-plugin/ecfa6f42aaf6c1bc40db7cd93703c733d152fed7 Log: Failing test for JENKINS-14900 .

SCM/JIRA link daemon added a comment - 2014-07-20 23:47

Code changed in jenkins
User: ikedam
Path:
src/test/java/hudson/plugins/copyartifact/CopyArtifactTest.java
http://jenkins-ci.org/commit/copyartifact-plugin/c04a128b5e0642b9519c8949024439d146750ad9
Log:
Merge pull request #12 from davehunt/~~JENKINS-14900~~-TEST

Failing test for ~~JENKINS-14900~~.

Conflicts:
pom.xml

SCM/JIRA link daemon added a comment - 2014-07-20 23:47 Code changed in jenkins User: ikedam Path: src/test/java/hudson/plugins/copyartifact/CopyArtifactTest.java http://jenkins-ci.org/commit/copyartifact-plugin/c04a128b5e0642b9519c8949024439d146750ad9 Log: Merge pull request #12 from davehunt/ JENKINS-14900 -TEST Failing test for JENKINS-14900 . Conflicts: pom.xml

SCM/JIRA link daemon added a comment - 2014-07-20 23:47

Code changed in jenkins
User: ikedam
Path:
src/test/java/hudson/plugins/copyartifact/CopyArtifactTest.java
http://jenkins-ci.org/commit/copyartifact-plugin/1f7f665a1840c56c622cd7533726a41532cdd5b1
Log:
~~JENKINS-14900~~ Added a test to reproduce ~~JENKINS-14900~~ when flatten=true.

SCM/JIRA link daemon added a comment - 2014-07-20 23:47 Code changed in jenkins User: ikedam Path: src/test/java/hudson/plugins/copyartifact/CopyArtifactTest.java http://jenkins-ci.org/commit/copyartifact-plugin/1f7f665a1840c56c622cd7533726a41532cdd5b1 Log: JENKINS-14900 Added a test to reproduce JENKINS-14900 when flatten=true.

SCM/JIRA link daemon added a comment - 2014-07-20 23:47

Code changed in jenkins
User: ikedam
Path:
src/main/java/hudson/plugins/copyartifact/CopyArtifact.java
src/main/java/hudson/plugins/copyartifact/FingerprintingCopyMethod.java
http://jenkins-ci.org/commit/copyartifact-plugin/609ca2e0e09db223961ae5faae74bb06e85eb4a0
Log:
[FIXED JENKINS-14900] Disabled ant default excludes.

SCM/JIRA link daemon added a comment - 2014-07-20 23:47 Code changed in jenkins User: ikedam Path: src/main/java/hudson/plugins/copyartifact/CopyArtifact.java src/main/java/hudson/plugins/copyartifact/FingerprintingCopyMethod.java http://jenkins-ci.org/commit/copyartifact-plugin/609ca2e0e09db223961ae5faae74bb06e85eb4a0 Log: [FIXED JENKINS-14900] Disabled ant default excludes.

SCM/JIRA link daemon added a comment - 2014-07-20 23:47

Code changed in jenkins
User: ikedam
Path:
src/main/java/hudson/plugins/copyartifact/Copier.java
src/main/java/hudson/plugins/copyartifact/CopyArtifact.java
src/main/java/hudson/plugins/copyartifact/FilePathCopyMethod.java
src/main/java/hudson/plugins/copyartifact/FingerprintingCopyMethod.java
src/main/resources/hudson/plugins/copyartifact/CopyArtifact/config.jelly
src/main/resources/hudson/plugins/copyartifact/CopyArtifact/config_ja.properties
src/main/resources/hudson/plugins/copyartifact/CopyArtifact/help-excludes.html
src/main/resources/hudson/plugins/copyartifact/CopyArtifact/help-excludes_ja.html
src/main/resources/hudson/plugins/copyartifact/CopyArtifact/help-filter.html
src/main/resources/hudson/plugins/copyartifact/CopyArtifact/help-filter_de.html
src/main/resources/hudson/plugins/copyartifact/CopyArtifact/help-filter_ja.html
src/test/java/hudson/plugins/copyartifact/CopyArtifactTest.java
http://jenkins-ci.org/commit/copyartifact-plugin/13282b4c62a11477ad6451030bd692560e858304
Log:
Merge pull request #42 from ikedam/feature/~~JENKINS-14900~~_Excludes

~~JENKINS-14900~~ ~~JENKINS-18662~~ ~~JENKINS-23444~~ Fixes for filter.

Compare: https://github.com/jenkinsci/copyartifact-plugin/compare/e894206e94ca...13282b4c62a1

SCM/JIRA link daemon added a comment - 2014-07-20 23:47 Code changed in jenkins User: ikedam Path: src/main/java/hudson/plugins/copyartifact/Copier.java src/main/java/hudson/plugins/copyartifact/CopyArtifact.java src/main/java/hudson/plugins/copyartifact/FilePathCopyMethod.java src/main/java/hudson/plugins/copyartifact/FingerprintingCopyMethod.java src/main/resources/hudson/plugins/copyartifact/CopyArtifact/config.jelly src/main/resources/hudson/plugins/copyartifact/CopyArtifact/config_ja.properties src/main/resources/hudson/plugins/copyartifact/CopyArtifact/help-excludes.html src/main/resources/hudson/plugins/copyartifact/CopyArtifact/help-excludes_ja.html src/main/resources/hudson/plugins/copyartifact/CopyArtifact/help-filter.html src/main/resources/hudson/plugins/copyartifact/CopyArtifact/help-filter_de.html src/main/resources/hudson/plugins/copyartifact/CopyArtifact/help-filter_ja.html src/test/java/hudson/plugins/copyartifact/CopyArtifactTest.java http://jenkins-ci.org/commit/copyartifact-plugin/13282b4c62a11477ad6451030bd692560e858304 Log: Merge pull request #42 from ikedam/feature/ JENKINS-14900 _Excludes JENKINS-14900 JENKINS-18662 JENKINS-23444 Fixes for filter. Compare: https://github.com/jenkinsci/copyartifact-plugin/compare/e894206e94ca...13282b4c62a1

ikedam added a comment - 2014-07-21 00:35

Released the fix in copyartifact 1.31.

ikedam added a comment - 2014-07-21 00:35 Released the fix in copyartifact 1.31.

Assignee:: Dave Hunt

Reporter:: Dave Hunt

Votes:: 1 Vote for this issue

Watchers:: 7 Start watching this issue

Created:: 2012-08-22 21:11

Updated:: 2018-02-21 02:25

Resolved:: 2014-07-20 23:47

Jenkins

Details

Attachments

Issue Links

Activity

Collapse comment: Dave Hunt added a comment - 2012-08-22 21:24

Expand comment: Dave Hunt added a comment - 2012-08-22 21:24

Collapse comment: Dave Hunt added a comment - 2012-10-19 13:00

Expand comment: Dave Hunt added a comment - 2012-10-19 13:00

Collapse comment: Alan Harder added a comment - 2012-10-19 16:17

Expand comment: Alan Harder added a comment - 2012-10-19 16:17

Collapse comment: Dave Hunt added a comment - 2012-10-19 16:30

Expand comment: Dave Hunt added a comment - 2012-10-19 16:30

Collapse comment: Jesse Glick added a comment - 2012-10-23 15:29

Expand comment: Jesse Glick added a comment - 2012-10-23 15:29

Collapse comment: Dave Hunt added a comment - 2013-01-08 19:42

Expand comment: Dave Hunt added a comment - 2013-01-08 19:42

Collapse comment: Fred G added a comment - 2013-01-09 00:55

Expand comment: Fred G added a comment - 2013-01-09 00:55

Collapse comment: Dave Hunt added a comment - 2013-01-09 10:54

Expand comment: Dave Hunt added a comment - 2013-01-09 10:54

Collapse comment: ikedam added a comment - 2014-07-13 06:51

Expand comment: ikedam added a comment - 2014-07-13 06:51

Collapse comment: SCM/JIRA link daemon added a comment - 2014-07-20 23:47

Expand comment: SCM/JIRA link daemon added a comment - 2014-07-20 23:47

Collapse comment: SCM/JIRA link daemon added a comment - 2014-07-20 23:47

Expand comment: SCM/JIRA link daemon added a comment - 2014-07-20 23:47

Collapse comment: SCM/JIRA link daemon added a comment - 2014-07-20 23:47

Expand comment: SCM/JIRA link daemon added a comment - 2014-07-20 23:47

Collapse comment: SCM/JIRA link daemon added a comment - 2014-07-20 23:47

Expand comment: SCM/JIRA link daemon added a comment - 2014-07-20 23:47

Collapse comment: SCM/JIRA link daemon added a comment - 2014-07-20 23:47

Expand comment: SCM/JIRA link daemon added a comment - 2014-07-20 23:47

Collapse comment: ikedam added a comment - 2014-07-21 00:35

Expand comment: ikedam added a comment - 2014-07-21 00:35

People

Dates