Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-15029

Update of MSBuild plugin to 1.15 causes Parameterized trigger plugin to fail.

    XMLWordPrintable

Details

    Description

      Upgraded Jenkins MSBuild plugin to 1.15 and Parameterized trigger plugin stops passing variables to MSBuild. This causes our builds to fails as paths aren't resolved.

      When I revert MSBuild back to 1.12 the correct variables are resolved.

      This is an extract from the console log:

      FailedConsole Output
      Started by upstream project "TFS Get - MiX Central - Main" build number 917
      Building in workspace C:\Software\Jenkins\.jenkins\jobs\MiX Track Web - Build\workspace
      No emails were triggered.
      Path To MSBuild.exe: C:\WINDOWS\Microsoft.NET\Framework64\v4.0.30319\MSBuild.exe
      FATAL: Can't find %SOURCE%\MiX.AssetManagement\MiX.AssetManagement.Reports.Web\MiX.AssetManagement.Reports.Web.csproj file
      Build step 'Build a Visual Studio project or solution using MSBuild' changed build result to FAILURE
      Build step 'Build a Visual Studio project or solution using MSBuild' marked build as failure
      Email was triggered for: Failure
      Sending email for trigger: Failure
      Sending email to: kolie.vanstaden@mixtelematics.com stephan.visagie@mixtelematics.com michaelc@mixtel.com
      Finished: FAILURE

      Attachments

        Activity

          icemanmike Michael Chamberlain created issue -
          firefart FireFart added a comment -

          same problem here.
          1.13 fixes the problem so this bug was intrudiced in 1.14

          firefart FireFart added a comment - same problem here. 1.13 fixes the problem so this bug was intrudiced in 1.14
          gbois Gregory Boissinot made changes -
          Field Original Value New Value
          Status Open [ 1 ] In Progress [ 3 ]

          Strange behavior.
          Could you try with $SOURCE?
          And if the problem persists, please attach your job configuration file (config.xnl).

          gbois Gregory Boissinot added a comment - Strange behavior. Could you try with $SOURCE? And if the problem persists, please attach your job configuration file (config.xnl).
          glittle Glen Little added a comment - - edited

          All my jobs stopped working too. Had to revert to 1.13.

          Sample "MSBuild Build File" entry:
          "%WORKSPACE%%SvnBranchName%\site.sln"

          This uses a parameter from Jenkins and one defined in the project configuration itself.

          (Also, it would be nice if the tool could wrap "" marks around the full entry - if there are spaces in the result and if the "" are not already added!)

          glittle Glen Little added a comment - - edited All my jobs stopped working too. Had to revert to 1.13. Sample "MSBuild Build File" entry: "%WORKSPACE%%SvnBranchName%\site.sln" This uses a parameter from Jenkins and one defined in the project configuration itself. (Also, it would be nice if the tool could wrap "" marks around the full entry - if there are spaces in the result and if the "" are not already added!)

          Please attach your job configuration file?

          gbois Gregory Boissinot added a comment - Please attach your job configuration file?
          glittle Glen Little added a comment -

          Sample job configuration file

          glittle Glen Little added a comment - Sample job configuration file
          glittle Glen Little made changes -
          Attachment config.xml [ 22443 ]

          Code changed in jenkins
          User: Gregory Boissinot
          Path:
          src/main/java/hudson/plugins/msbuild/MsBuildBuilder.java
          http://jenkins-ci.org/commit/msbuild-plugin/fdf464ea9b31c908b7474cbace838baf2135e2b6
          Log:
          Fix JENKINS-15029 and JENKINS-14898

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Gregory Boissinot Path: src/main/java/hudson/plugins/msbuild/MsBuildBuilder.java http://jenkins-ci.org/commit/msbuild-plugin/fdf464ea9b31c908b7474cbace838baf2135e2b6 Log: Fix JENKINS-15029 and JENKINS-14898
          gbois Gregory Boissinot made changes -
          Resolution Fixed [ 1 ]
          Status In Progress [ 3 ] Resolved [ 5 ]

          Hello

          I've tried the new MSBuild plugin version 1.16 and the issue persists.

          icemanmike Michael Chamberlain added a comment - Hello I've tried the new MSBuild plugin version 1.16 and the issue persists.
          icemanmike Michael Chamberlain made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          icemanmike Michael Chamberlain added a comment - - edited

          I've had a look at the other call logged for this 14898 and tried MSBuild v1.16 with the suggested UNIX path variable and that seems to work fine.
          Using the %SOURCE% variable format doesn't work. (Only if I change all of my variables to look like this ${SOURCE} it works.)

          icemanmike Michael Chamberlain added a comment - - edited I've had a look at the other call logged for this 14898 and tried MSBuild v1.16 with the suggested UNIX path variable and that seems to work fine. Using the %SOURCE% variable format doesn't work. (Only if I change all of my variables to look like this ${SOURCE} it works.)

          @Michael
          I don't really understand. Could I set to 'Resolved' the issue?

          gbois Gregory Boissinot added a comment - @Michael I don't really understand. Could I set to 'Resolved' the issue?
          glittle Glen Little added a comment -

          Please don't set the issue to Resolved if you don't understand it! Ask more questions if you need to, but the original description and the comments seem clear - "Using the %SOURCE% variable format doesn't work."

          glittle Glen Little added a comment - Please don't set the issue to Resolved if you don't understand it! Ask more questions if you need to, but the original description and the comments seem clear - "Using the %SOURCE% variable format doesn't work."

          It seems to work fine in my environment.
          Please could you check again with the last version?

          gbois Gregory Boissinot added a comment - It seems to work fine in my environment. Please could you check again with the last version?

          Hello Gregory.

          I've noticed that in our production environment I didn't have any problems with the %source% parameter on our 'Windows Server 2008 R2' computers.
          I DID have the problem on our 'Windows Server 2003' computers though. Both tests where done with the last version (MSBuild v1.16).

          Using a job to pass %SOURCE% parameter to another job. So in the end, on my Windows Server 2003 computers I had to change all the %SOURCE% parameters in my MSBUILD lines to ${SOURCE} for the parameter to pass in correctly to MSBUILD.

          Regards

          icemanmike Michael Chamberlain added a comment - Hello Gregory. I've noticed that in our production environment I didn't have any problems with the %source% parameter on our 'Windows Server 2008 R2' computers. I DID have the problem on our 'Windows Server 2003' computers though. Both tests where done with the last version (MSBuild v1.16). Using a job to pass %SOURCE% parameter to another job. So in the end, on my Windows Server 2003 computers I had to change all the %SOURCE% parameters in my MSBUILD lines to ${SOURCE} for the parameter to pass in correctly to MSBUILD. Regards

          For summary, it doesn't work for only Windows Server 2003?

          gbois Gregory Boissinot added a comment - For summary, it doesn't work for only Windows Server 2003?

          Hello Gregory

          Unfortunately I don't have any time to test exactly what the problem could be.(It could even be environmental setting) It just seemed strange that it worked fine on Windows Server 2008 and not 2003.

          It's no longer an issue for me as there is a workaround by using the UNIX format to reference the parameter.

          Best regards
          Michael

          icemanmike Michael Chamberlain added a comment - Hello Gregory Unfortunately I don't have any time to test exactly what the problem could be.(It could even be environmental setting) It just seemed strange that it worked fine on Windows Server 2008 and not 2003. It's no longer an issue for me as there is a workaround by using the UNIX format to reference the parameter. Best regards Michael
          ikedam ikedam added a comment -

          Sounds not related with parameterized-trigger plugin.
          Points that may help:

          • What happens without parameterized-trigger? (triggering directly)
          • What happens changing SOURCE to other name? (it may be a reserved name)
          • What is output when run set with Windows batch builder? (SOURCE is logged?)
          • Attach build.xml of failed build with msbuild-plugin.
          ikedam ikedam added a comment - Sounds not related with parameterized-trigger plugin. Points that may help: What happens without parameterized-trigger? (triggering directly) What happens changing SOURCE to other name? (it may be a reserved name) What is output when run set with Windows batch builder? (SOURCE is logged?) Attach build.xml of failed build with msbuild-plugin.
          ikedam ikedam made changes -
          Component/s parameterized-trigger [ 15592 ]

          Mark it as incomplete for now

          gbois Gregory Boissinot added a comment - Mark it as incomplete for now
          gbois Gregory Boissinot made changes -
          Resolution Incomplete [ 4 ]
          Status Reopened [ 4 ] Resolved [ 5 ]
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 145748 ] JNJira + In-Review [ 191610 ]

          People

            kdsweeney kdsweeney
            icemanmike Michael Chamberlain
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: