Details
-
Type:
Bug
-
Status: Reopened (View Workflow)
-
Priority:
Blocker
-
Resolution: Unresolved
-
Component/s: envinject-plugin
-
Labels:None
-
Environment:1.69, 1.92.1
-
Similar Issues:
Description
EnvJect unsets empty and whitespace properties
Example
return ["LABEL":" ",ANOTHER_LABEL:""]
[EnvInject] - Unset unresolved 'ANOTHER_LABEL' variable.
[EnvInject] - Unset unresolved 'LABEL' variable.
It appears that the fix for JENKINS-14930 caused the problem.
Unsetting blank variables should be optional.
Attachments
Issue Links
- relates to
-
-
- Open
-
Activity
it's still not possible to have an empty Environment variable.
Using pipeline step withEnv(['FOO=']) with result in key="FOO" and value="".
Then EnvVars.override is called and even removes "FOO" from Environment.
https://github.com/kohsuke/hudson/blob/master/core/src/main/java/hudson/EnvVars.java#L126
if(value==null || value.length()==0) { remove(key); return; }
The behavior would be okay, if the value is null. But for an explicit empty String it seems not reasonable, that the Key is deleted.
What needs to be done to change this? It could not be done in the withEnv Code except in dirty ways.
think think
added a comment - it's still not possible to have an empty Environment variable.
Using pipeline step withEnv( ['FOO='] ) with result in key="FOO" and value="".
Then EnvVars.override is called and even removes "FOO" from Environment.
https://github.com/kohsuke/hudson/blob/master/core/src/main/java/hudson/EnvVars.java#L126
if (value== null || value.length()==0) {
remove(key);
return ;
}
The behavior would be okay, if the value is null. But for an explicit empty String it seems not reasonable, that the Key is deleted.
What needs to be done to change this? It could not be done in the withEnv Code except in dirty ways. we use it for parameters to give the starter of a job the possibility to extend an existing path with a subpath. if the starter wants to use the root he wont type anything for this parameter... this doesn't work anymore...
Dominik Gabriel
added a comment - we use it for parameters to give the starter of a job the possibility to extend an existing path with a subpath. if the starter wants to use the root he wont type anything for this parameter... this doesn't work anymore... think think Pipeline does not use EnvInject so any Pipeline bug should be filed separately with steps to reproduce from scratch, in workflow-plugin.
I want to set a environment variable to an empty string ("") via withEnv(), but it seems not working.
I'm getting the same behaviour (blank properties are not set) in 1.92.1