Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-15340

Add 'Are you sure' on Reload configuration from disk

      The button "Reload configuration from disk" in Manage Jenkins can be easily pressed by mistake by an administrator.

      This happened to us and we lost functionality of Jenkins for more than an hour (we waited for Jenkins to come back by itself but it never did and we decided to restart the service on the master).

      Why not make the link points to an "Are you sure?" page like for the safe restart link?

      Thank you very much!

          [JENKINS-15340] Add 'Are you sure' on Reload configuration from disk

          Denis Blanchette created issue -

          Jesse Glick added a comment -

          Jenkins.doReload ought to @RequiresPOST or similar. Probably should be something like <l:confirmationLink href="…" post="true">…</> which would show a JavaScript popup confirmation dialog where available, then POST to the indicated URL; this has been asked for in other contexts.

          Jesse Glick added a comment - Jenkins.doReload ought to @RequiresPOST or similar. Probably should be something like <l:confirmationLink href="…" post="true">…</> which would show a JavaScript popup confirmation dialog where available, then POST to the indicated URL; this has been asked for in other contexts.
          Jesse Glick made changes -
          Link New: This issue is duplicated by JENKINS-16145 [ JENKINS-16145 ]

          Jesse Glick added a comment -

          Partially mitigated by JENKINS-12318 fix.

          Jesse Glick added a comment - Partially mitigated by JENKINS-12318 fix.
          Jesse Glick made changes -
          Link New: This issue is related to JENKINS-12318 [ JENKINS-12318 ]
          Jesse Glick made changes -
          Link New: This issue is related to JENKINS-3265 [ JENKINS-3265 ]
          Jesse Glick made changes -
          Link Original: This issue is related to JENKINS-12318 [ JENKINS-12318 ]

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          core/src/main/java/hudson/model/ManagementLink.java
          core/src/main/java/jenkins/management/ReloadLink.java
          core/src/main/java/jenkins/model/Jenkins.java
          core/src/main/java/jenkins/model/ModelObjectWithContextMenu.java
          core/src/main/resources/jenkins/model/Jenkins/manage.jelly
          core/src/main/resources/jenkins/model/Jenkins/manage.properties
          core/src/main/resources/lib/layout/breadcrumbs.js
          core/src/main/resources/lib/layout/confirmationLink.jelly
          core/src/main/resources/lib/layout/task.jelly
          http://jenkins-ci.org/commit/jenkins/9eb69772a505890a9767375b7c2a78e278895ef9
          Log:
          [FIXED JENKINS-15340] Ask for confirmation before reloading config from disk, as it may be expensive.
          First of all, /reload should require POST (also prevents XSS DoS attacks).
          Adding <l:confirmationLink> to encapsulate a link that requires confirmation upon clicking.
          Allowing a ManagementLink to request confirmation (also implying POST); could be used also for e.g. /quietDown.
          Enhancing <l:task> to support confirmation as well, and honoring this in context menu items.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/model/ManagementLink.java core/src/main/java/jenkins/management/ReloadLink.java core/src/main/java/jenkins/model/Jenkins.java core/src/main/java/jenkins/model/ModelObjectWithContextMenu.java core/src/main/resources/jenkins/model/Jenkins/manage.jelly core/src/main/resources/jenkins/model/Jenkins/manage.properties core/src/main/resources/lib/layout/breadcrumbs.js core/src/main/resources/lib/layout/confirmationLink.jelly core/src/main/resources/lib/layout/task.jelly http://jenkins-ci.org/commit/jenkins/9eb69772a505890a9767375b7c2a78e278895ef9 Log: [FIXED JENKINS-15340] Ask for confirmation before reloading config from disk, as it may be expensive. First of all, /reload should require POST (also prevents XSS DoS attacks). Adding <l:confirmationLink> to encapsulate a link that requires confirmation upon clicking. Allowing a ManagementLink to request confirmation (also implying POST); could be used also for e.g. /quietDown. Enhancing <l:task> to support confirmation as well, and honoring this in context menu items.
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]

          dogfood added a comment -

          Integrated in jenkins_main_trunk #2449
          [FIXED JENKINS-15340] Ask for confirmation before reloading config from disk, as it may be expensive. (Revision 9eb69772a505890a9767375b7c2a78e278895ef9)

          Result = UNSTABLE
          Jesse Glick : 9eb69772a505890a9767375b7c2a78e278895ef9
          Files :

          • core/src/main/resources/lib/layout/task.jelly
          • core/src/main/resources/lib/layout/breadcrumbs.js
          • core/src/main/java/hudson/model/ManagementLink.java
          • core/src/main/resources/jenkins/model/Jenkins/manage.jelly
          • core/src/main/resources/lib/layout/confirmationLink.jelly
          • core/src/main/resources/jenkins/model/Jenkins/manage.properties
          • core/src/main/java/jenkins/model/ModelObjectWithContextMenu.java
          • core/src/main/java/jenkins/model/Jenkins.java
          • changelog.html
          • core/src/main/java/jenkins/management/ReloadLink.java

          dogfood added a comment - Integrated in jenkins_main_trunk #2449 [FIXED JENKINS-15340] Ask for confirmation before reloading config from disk, as it may be expensive. (Revision 9eb69772a505890a9767375b7c2a78e278895ef9) Result = UNSTABLE Jesse Glick : 9eb69772a505890a9767375b7c2a78e278895ef9 Files : core/src/main/resources/lib/layout/task.jelly core/src/main/resources/lib/layout/breadcrumbs.js core/src/main/java/hudson/model/ManagementLink.java core/src/main/resources/jenkins/model/Jenkins/manage.jelly core/src/main/resources/lib/layout/confirmationLink.jelly core/src/main/resources/jenkins/model/Jenkins/manage.properties core/src/main/java/jenkins/model/ModelObjectWithContextMenu.java core/src/main/java/jenkins/model/Jenkins.java changelog.html core/src/main/java/jenkins/management/ReloadLink.java

            Unassigned Unassigned
            dblanchette Denis Blanchette
            Votes:
            3 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved: