Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-15638

Xvfb 'display name offset' defaults to 0, not 1 as described, if unset

    XMLWordPrintable

Details

    Description

      In 1.0.4, it seems like the "Xvfb display name offset" defaults to 0 when not set, instead of 1 as it says in the description?

      Jobs on executor #0 always get display :0 if "Xvfb specific displayname" and "Xvfb display name offset" are both left unset, and jobs running on executor #1 get display :1.

      Attachments

        Activity

          Code changed in jenkins
          User: Zoran Regvart
          Path:
          src/main/java/org/jenkinsci/plugins/xvfb/XvfbBuildWrapper.java
          http://jenkins-ci.org/commit/xvfb-plugin/fd33fe3d2da6690259b19126c2ba2c689b58186a
          Log:
          JENKINS-15638 Xvfb 'display name offset' defaults to 0, not 1 as
          described, if unset

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Zoran Regvart Path: src/main/java/org/jenkinsci/plugins/xvfb/XvfbBuildWrapper.java http://jenkins-ci.org/commit/xvfb-plugin/fd33fe3d2da6690259b19126c2ba2c689b58186a Log: JENKINS-15638 Xvfb 'display name offset' defaults to 0, not 1 as described, if unset
          zregvart zregvart added a comment -

          Fixed in version 1.0.5, thank you for reporting the issue

          zregvart zregvart added a comment - Fixed in version 1.0.5, thank you for reporting the issue
          frvi Fredrik Vihlborg added a comment - - edited

          Still seem to have the same issue. Downloaded latest xvfb.hpi, and restarted Jenkins. PluginManager states version 1.0.5.

          Job on first executor still gets the display :0, and a job running at the same time on the second executor gets display :1.
          The jobs are building on a node/slave.

          Running on Jenkins version 1.486.

          Also: The text field itself is always empty, i e if I set a value, and applies the change then reload the page, the text field is empty.

          A svn diff on the config.xml shows, when manually setting the value to 1:

          <screen>1024x768x24</screen>
          <debug>false</debug>
          <timeout>0</timeout>
          -<displayNameOffset>0</displayNameOffset>
          +<displayNameOffset>1</displayNameOffset>
          <additionalOptions></additionalOptions>

          frvi Fredrik Vihlborg added a comment - - edited Still seem to have the same issue. Downloaded latest xvfb.hpi, and restarted Jenkins. PluginManager states version 1.0.5. Job on first executor still gets the display :0, and a job running at the same time on the second executor gets display :1. The jobs are building on a node/slave. Running on Jenkins version 1.486. Also: The text field itself is always empty, i e if I set a value, and applies the change then reload the page, the text field is empty. A svn diff on the config.xml shows, when manually setting the value to 1: <screen>1024x768x24</screen> <debug>false</debug> <timeout>0</timeout> -<displayNameOffset>0</displayNameOffset> +<displayNameOffset>1</displayNameOffset> <additionalOptions></additionalOptions>

          Code changed in jenkins
          User: Zoran Regvart
          Path:
          src/main/java/org/jenkinsci/plugins/xvfb/XvfbBuildWrapper.java
          http://jenkins-ci.org/commit/xvfb-plugin/5ddf36dd787e981b6f143973f621d88e0616fa8b
          Log:
          JENKINS-15638 Xvfb 'display name offset' defaults to 0, not 1 as
          described, if unset

          • added missing getter for display name offset
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Zoran Regvart Path: src/main/java/org/jenkinsci/plugins/xvfb/XvfbBuildWrapper.java http://jenkins-ci.org/commit/xvfb-plugin/5ddf36dd787e981b6f143973f621d88e0616fa8b Log: JENKINS-15638 Xvfb 'display name offset' defaults to 0, not 1 as described, if unset added missing getter for display name offset
          zregvart zregvart added a comment -

          The display name offset property was missing getter, which was reflected in the empty value in configuration screen. Please upgrade to version 1.0.6, and make sure that display name offset is set to something greater than 0.

          zregvart zregvart added a comment - The display name offset property was missing getter, which was reflected in the empty value in configuration screen. Please upgrade to version 1.0.6, and make sure that display name offset is set to something greater than 0.

          People

            zregvart zregvart
            frvi Fredrik Vihlborg
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: