-
Bug
-
Resolution: Fixed
-
Critical
-
None
I have a job with store non-stored password parameter. When trying to rebuild the job, password is stored.
Expected results:
The rebuild plugin should not keep passwords. When clicking on rebuild button, it should promt for password once again.
[JENKINS-15882] rebuild plugin should not store non-stored password parameter
Kiril Nesenko
added a comment - I am triggering it manually, providing the password.
After the job finishes, I am able to rerun it without providing a password.
Kiril Nesenko
added a comment - I am triggering it manually, providing the password.
After the job finishes, I am able to rerun it without providing a password. 
Kiril Nesenko
added a comment - No I am not 
Rino
added a comment - Could you describe in more detail the steps to reproduce?
-Where do you configure a job with non-stored password parameters?
Would this issue be fixed if I add a configuration option to show an empty input field when rebuilding?
Rino
added a comment - Could you describe in more detail the steps to reproduce?
-Where do you configure a job with non-stored password parameters?
Would this issue be fixed if I add a configuration option to show an empty input field when rebuilding? 
Walter Kacynski
added a comment - Here is my usage scenario:
Create new Job which accepts build parameters. One of the parameters should be a "password" type parameter. Build this new job and enter a password. Click on re-build and the password is re-entered automatically.
Walter Kacynski
added a comment - Here is my usage scenario:
Create new Job which accepts build parameters. One of the parameters should be a "password" type parameter. Build this new job and enter a password. Click on re-build and the password is re-entered automatically. https://github.com/jenkinsci/rebuild-plugin/pull/8
Storing passwords is a feature of jenkins, so this can't be disabled from the rebuild plugin. The pull request adds a global configuration option to make sure that the rebuild plugin won't pre-fill the password field.
Rino
added a comment - - edited https://github.com/jenkinsci/rebuild-plugin/pull/8
Storing passwords is a feature of jenkins, so this can't be disabled from the rebuild plugin. The pull request adds a global configuration option to make sure that the rebuild plugin won't pre-fill the password field. Walter Kacynski
added a comment - I pulled down version 1.19 of the Rebuilder plugin but I don't see an option to configure this behavior. What am I missing?
Walter Kacynski
added a comment - I pulled down version 1.19 of the Rebuilder plugin but I don't see an option to configure this behavior. What am I missing? Rino
added a comment - The pull request is still open. In the meantime you could build the snapshot from source:
https://github.com/rinokadijk/rebuild-plugin.git
Rino
added a comment - The pull request is still open. In the meantime you could build the snapshot from source:
https://github.com/rinokadijk/rebuild-plugin.git Code changed in jenkins
User: Rino
Path:
src/main/java/com/sonyericsson/rebuild/RebuildAction.java
src/main/java/com/sonyericsson/rebuild/RebuildConfiguration.java
src/main/resources/com/sonyericsson/rebuild/RebuildAction/PasswordParameterValue.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildAction/global.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildAction/help-rememberPassword.html
src/main/resources/com/sonyericsson/rebuild/RebuildAction/parameterized.jelly
http://jenkins-ci.org/commit/rebuild-plugin/17cfac781eae06934a25498c1f6372f6676435a0
Log:
Fixed JENKINS-15882 - rebuild plugin should not store non-stored password parameter
Added global configuration option to (not) remember password
Code changed in jenkins
User: Rino
Path:
src/main/java/com/sonyericsson/rebuild/RebuildAction.java
src/main/java/com/sonyericsson/rebuild/RebuildConfiguration.java
src/main/resources/com/sonyericsson/rebuild/RebuildAction/PasswordParameterValue.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildAction/global.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildAction/help-rememberPassword.html
http://jenkins-ci.org/commit/rebuild-plugin/0eb0c0005525327e3818c4b961ab65da28fcd75d
Log:
JENKINS-15882 - rebuild plugin should not store non-stored password parameter
-Replaced if jelly tag by choose
-fixed global jelly to show documentation
-imrpoved documentation
-added license
-added javadoc
Code changed in jenkins
User: Rino
Path:
src/main/resources/com/sonyericsson/rebuild/RebuildAction/global.jelly
http://jenkins-ci.org/commit/rebuild-plugin/690ac040b745e95de347e429d9ed23c2312374b5
Log:
JENKINS-15882 - rebuild plugin should not store non-stored password parameter
-added default true
Code changed in jenkins
User: Rino
Path:
.gitignore
src/main/java/com/sonyericsson/rebuild/RebuildAction.java
src/main/java/com/sonyericsson/rebuild/RebuildConfiguration.java
src/main/java/com/sonyericsson/rebuild/RebuildDescriptor.java
src/main/resources/com/sonyericsson/rebuild/RebuildAction/PasswordParameterValue.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildAction/global.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildAction/help-rememberPassword.html
src/main/resources/com/sonyericsson/rebuild/RebuildAction/parameterized.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildDescriptor/config.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildDescriptor/help-rememberPasswordEnabled.html
http://jenkins-ci.org/commit/rebuild-plugin/6678b8e297661bdbb83649280546d927ea06c617
Log:
JENKINS-15882 - rebuild plugin should not store non-stored password parameter
- fixed review comment
Code changed in jenkins
User: Robert Sandell
Path:
.gitignore
src/main/java/com/sonyericsson/rebuild/RebuildAction.java
src/main/java/com/sonyericsson/rebuild/RebuildConfiguration.java
src/main/java/com/sonyericsson/rebuild/RebuildDescriptor.java
src/main/resources/com/sonyericsson/rebuild/RebuildAction/ExtendedChoiceParameterValue.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildAction/PasswordParameterValue.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildAction/parameterized.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildDescriptor/config.jelly
src/main/resources/com/sonyericsson/rebuild/RebuildDescriptor/help-rememberPasswordEnabled.html
http://jenkins-ci.org/commit/rebuild-plugin/50f9bf384cbca8125c9eefc8f48c132ee1a71247
Log:
Merge pull request #8 from rinokadijk/master
Fixed JENKINS-15882 - rebuild plugin should not store non-stored password parameter
Compare: https://github.com/jenkinsci/rebuild-plugin/compare/d7bc0e5155ed...50f9bf384cbc
Walter Kacynski
added a comment - I've tested this and it works great. 
How are you triggering the job and how is the password provided? Are you manually providing the password when starting the job?