The plugin build with these changes, in case anyone dares to run plugins from an untrusted source.

Hello,

I tried your patch.
I agree with you about ExcetuionPolicy ByPass.
But for the exit code, I do not think this is a good solution. When a script is executed, it should be fully executed and not stop on the first error (as batch files). To stop a script, you must use "exit 1" and so fail the build.
I found a better solution fot the exit code (the same than "Execute Windows batch command").

I created a pull request with my changes.

Damien

Code changed in jenkins
User: Damien Finck
Path:
src/main/java/hudson/plugins/powershell/PowerShell.java
http://jenkins-ci.org/commit/powershell-plugin/e81fe9920f4949657483e71c133c7045c3e96648
Log:
JENKINS-15890 Avoid ExecutionPolicy errors

ByPass PowerShell ExecutionPolicy

Code changed in jenkins
User: Damien Finck
Path:
src/main/java/hudson/plugins/powershell/PowerShell.java
http://jenkins-ci.org/commit/powershell-plugin/4f7c7b40f09d2a42b6d8407c7874836898058691
Log:
[FIXED JENKINS-15890] support of exit code

PowerShell Plugin now support exit code to fail the build

Code changed in jenkins
User: Damien Finck
Path:
.gitignore
README.md
pom.xml
src/main/java/hudson/plugins/powershell/PowerShell.java
src/main/resources/index.jelly
http://jenkins-ci.org/commit/powershell-plugin/b671a56671046bfb6c79d78cdfc938fd1f0cb374
Log:
Merge pull request #1 from damienfinck/master

[FIXED JENKINS-15890] PowerShell improvements

Compare: https://github.com/jenkinsci/powershell-plugin/compare/3ee3d3f79f3e...b671a5667104

While I get your reasoning using $LastExitCode doesn't quite cover detecting errors in PowerShell. $LastExitCode will only be set after an executable has been run, it not set when a cmdlet fails (and might be unset when no executable was started in the script). On top of that the script might start multiple executables and this only fails the build when the last of those fails. Perhaps checking $errors could be useful, but error handling in PowerShell is a bit painful anyway.

Can some describe how to apply this patch to the powershell plugin error for executionpolicy problems ? I don't see these 2 files under my Jenkins home directory. And does this patch work for Powershell 3.0 ?