Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-16213

the downstream build result was not updated correctly when it is triggered by multiple builds

      reproduce steps:
      0. config jobA and jobB, jobB is downstream of jobA; and jobA were configured with promotion condition "When the following downstream projects build successfully".
      1. trigger two builds(build 1 and 2) of "jobA" in short time;
      2. the downstream job "jobB" scheduled one build for the two upstream builds(jobA build 1 and 2), and the build finished sucessfully

      Unexpected result:

      Trying to promote the build 2 of jobA, the condition of the downstream projects build successfully was not satisfied.

          [JENKINS-16213] the downstream build result was not updated correctly when it is triggered by multiple builds

          li wei created issue -

          li wei added a comment -

          to fix this bug:

          remove "break" in 241 line of hudson.plugins.release_builds.conditions.DownstreamPassCondition

          li wei added a comment - to fix this bug: remove "break" in 241 line of hudson.plugins.release_builds.conditions.DownstreamPassCondition
          li wei made changes -
          Assignee New: li wei [ liweing ]
          li wei made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          li wei made changes -
          Status Original: In Progress [ 3 ] New: Open [ 1 ]
          Kari Sivonen made changes -
          Assignee Original: li wei [ liweing ] New: Kari Sivonen [ karisivo ]

          Kari Sivonen added a comment -

          To do this more cleaver, I take example from copy artifact plugin where is introduced global and job's parameter upstreamFilterStrategy. In Global parameter there is options UseOldest and UseNewest. In job configuration there is als option UseGlobalSetting. Depending selection latest or oldest job is promoted.

          Kari Sivonen added a comment - To do this more cleaver, I take example from copy artifact plugin where is introduced global and job's parameter upstreamFilterStrategy. In Global parameter there is options UseOldest and UseNewest. In job configuration there is als option UseGlobalSetting. Depending selection latest or oldest job is promoted.
          Jesse Glick made changes -
          Remote Link New: This issue links to "PR 41 (Web Link)" [ 11801 ]
          Jesse Glick made changes -
          Link New: This issue is related to JENKINS-11655 [ JENKINS-11655 ]

          Jesse Glick added a comment -

          I am doubtful that introducing a new option is necessary here. Probably a user error (failure to properly associate upstream and downstream builds via fingerprints); if fingerprints are in use and it is still promoting the wrong build, that is simply a bug that should not require the user to configure anything differently.

          Jesse Glick added a comment - I am doubtful that introducing a new option is necessary here. Probably a user error (failure to properly associate upstream and downstream builds via fingerprints); if fingerprints are in use and it is still promoting the wrong build, that is simply a bug that should not require the user to configure anything differently.

            karisivo Kari Sivonen
            liweing li wei
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated: