Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-16244

View.hasPeople too slow to use in sidepanel.jelly

      On large Jenkins installations, rendering view pages can be extremely slow. Thread dumps point to the use of View.hasPeople, which is an arbitrarily expensive call that must not be made from HTTP service.

          [JENKINS-16244] View.hasPeople too slow to use in sidepanel.jelly

          Jesse Glick created issue -
          Jesse Glick made changes -
          Link New: This issue is related to JENKINS-15206 [ JENKINS-15206 ]
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          Jesse Glick added a comment -

          Fixing by just unconditionally linking to asynchPeople.

          Unclear if hyperlink construction in this sidepanel is correct in all cases; https://github.com/jenkinsci/jenkins/commit/5c7184d3cdccde44eaf8d73a38151a1c6ee5f9a9 has discussion.

          Jesse Glick added a comment - Fixing by just unconditionally linking to asynchPeople . Unclear if hyperlink construction in this sidepanel is correct in all cases; https://github.com/jenkinsci/jenkins/commit/5c7184d3cdccde44eaf8d73a38151a1c6ee5f9a9 has discussion.
          Jesse Glick made changes -
          Priority Original: Major [ 3 ] New: Critical [ 2 ]

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          core/src/main/java/hudson/model/View.java
          core/src/main/java/jenkins/model/Jenkins.java
          core/src/main/resources/hudson/model/View/sidepanel.jelly
          http://jenkins-ci.org/commit/jenkins/73aac1073983e1f667d801387571d31857253ffc
          Log:
          [FIXED JENKINS-16244] View.hasPeople too slow to use in sidepanel.jelly.

          Compare: https://github.com/jenkinsci/jenkins/compare/5eede6e5d58d...73aac1073983

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/model/View.java core/src/main/java/jenkins/model/Jenkins.java core/src/main/resources/hudson/model/View/sidepanel.jelly http://jenkins-ci.org/commit/jenkins/73aac1073983e1f667d801387571d31857253ffc Log: [FIXED JENKINS-16244] View.hasPeople too slow to use in sidepanel.jelly. Compare: https://github.com/jenkinsci/jenkins/compare/5eede6e5d58d...73aac1073983
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]

          dogfood added a comment -

          Integrated in jenkins_main_trunk #2169

          Result = SUCCESS

          dogfood added a comment - Integrated in jenkins_main_trunk #2169 Result = SUCCESS

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          core/src/main/java/hudson/model/View.java
          core/src/main/java/jenkins/model/Jenkins.java
          core/src/main/resources/hudson/model/View/sidepanel.jelly
          http://jenkins-ci.org/commit/jenkins/4998a373c831665814233b2b330392299bdc101b
          Log:
          [FIXED JENKINS-16244] View.hasPeople too slow to use in sidepanel.jelly.(cherry picked from commit 73aac1073983e1f667d801387571d31857253ffc)

          Conflicts:
          changelog.html

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/model/View.java core/src/main/java/jenkins/model/Jenkins.java core/src/main/resources/hudson/model/View/sidepanel.jelly http://jenkins-ci.org/commit/jenkins/4998a373c831665814233b2b330392299bdc101b Log: [FIXED JENKINS-16244] View.hasPeople too slow to use in sidepanel.jelly.(cherry picked from commit 73aac1073983e1f667d801387571d31857253ffc) Conflicts: changelog.html
          Jesse Glick made changes -
          Labels Original: performance New: 1.480.3-fixed performance

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: