Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-16376

BuildStepMonitor.BUILD makes concurrent builds wait, could be changed to BuildStepMonitor.NONE?

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • email-ext-plugin
    • None

      We perform many concurrent builds in one job and are using the email-ext plugin. Sometimes and older build takes longer time to finish and then the new jobs just waits to be finished because BuildStepMonitor.BUILD is configured in the plugin.

      Could this one line be changed?

          [JENKINS-16376] BuildStepMonitor.BUILD makes concurrent builds wait, could be changed to BuildStepMonitor.NONE?

          Fredrik Jonsson created issue -

          Alex Earl added a comment -

          I'll research this.

          Alex Earl added a comment - I'll research this.

          Alex Earl added a comment -

          I think this change should be fine.

          Alex Earl added a comment - I think this change should be fine.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Alex Earl
          Path:
          src/main/java/hudson/plugins/emailext/ExtendedEmailPublisher.java
          http://jenkins-ci.org/commit/email-ext-plugin/e7bc7c814709e433d98fab1b31f340380043caf5
          Log:
          Fixed JENKINS-16376

          • Changed to BuildStepMonitor.NONE

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Alex Earl Path: src/main/java/hudson/plugins/emailext/ExtendedEmailPublisher.java http://jenkins-ci.org/commit/email-ext-plugin/e7bc7c814709e433d98fab1b31f340380043caf5 Log: Fixed JENKINS-16376 Changed to BuildStepMonitor.NONE

          Alex Earl added a comment -

          Changed to BuildStepMonitor.NONE

          Alex Earl added a comment - Changed to BuildStepMonitor.NONE
          Alex Earl made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]

          kutzi added a comment -

          IMO we actually do need BuildStepMonitor.BUILD - e.g. if a 'fixed' trigger is used.
          Otherwise you couldn't determin if a build is a fix for the previous build.

          kutzi added a comment - IMO we actually do need BuildStepMonitor.BUILD - e.g. if a 'fixed' trigger is used. Otherwise you couldn't determin if a build is a fix for the previous build.

          kutzi added a comment -

          What we could do is:
          check if we have a trigger which needs the previous build's result (fixed, still xyz) and only then require BuildStepMonitor.BUILD.
          But I'm not sure if this would be worth the effort and not being more unintuitive to use.

          kutzi added a comment - What we could do is: check if we have a trigger which needs the previous build's result (fixed, still xyz) and only then require BuildStepMonitor.BUILD. But I'm not sure if this would be worth the effort and not being more unintuitive to use.

          Alex Earl added a comment -

          I agree, I reverted. Wasn't thinking through the whole process. Need more sleep

          Alex Earl added a comment - I agree, I reverted. Wasn't thinking through the whole process. Need more sleep
          Alex Earl made changes -
          Resolution Original: Fixed [ 1 ]
          Status Original: Resolved [ 5 ] New: Reopened [ 4 ]

            jglick Jesse Glick
            nicefred Fredrik Jonsson
            Votes:
            4 Vote for this issue
            Watchers:
            18 Start watching this issue

              Created:
              Updated:
              Resolved: