Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-16381

Disable button should be an overlay of the build button not a separate button.

    • Icon: New Feature New Feature
    • Resolution: Fixed
    • Icon: Minor Minor
    • extra-columns-plugin
    • None

      It would be nice if the disable was part of the build button. The way this would work is when a mouse over of the build button occurs a menu would pop up with the option to build or disable the build.

      When the build is disable a red circle with an slash through it would replace the build button and the build action would be disabled. A mouse over the disable button would give the options to enable the build or build once.

      Doing the disable this way also cleans up the column real-estate; at the very least the current disable button should be made much smaller.

          [JENKINS-16381] Disable button should be an overlay of the build button not a separate button.

          Fred G added a comment -

          Modifications to the build button column would require changes in Jenkins core and you'd probably face strong opposition to change the current behavior. Therefore a new build button column would be easier to implement and release.

          Nevertheless I think the build button should remain a one-click button without another pop-up menu. There are plenty of pop-up menus around already.

          I agree that connecting the disable button with the build button in a visual way (red circle with a slash) would be an improvement.
          The current disable button is certainly not space-saving. I just used the same button that can be seen on the job page (which is IMHO misplaced and ugly anyway ).

          I'm open to suggestions for a new icon for the disable/enable button. It should have two states that clearly represent what happens when you click it (disable/enable). Just of the top of my head I can think of a light switch icon (eg. with on/off labels).
          WDYT?

          Fred G added a comment - Modifications to the build button column would require changes in Jenkins core and you'd probably face strong opposition to change the current behavior. Therefore a new build button column would be easier to implement and release. Nevertheless I think the build button should remain a one-click button without another pop-up menu. There are plenty of pop-up menus around already. I agree that connecting the disable button with the build button in a visual way (red circle with a slash) would be an improvement. The current disable button is certainly not space-saving. I just used the same button that can be seen on the job page (which is IMHO misplaced and ugly anyway ). I'm open to suggestions for a new icon for the disable/enable button. It should have two states that clearly represent what happens when you click it (disable/enable). Just of the top of my head I can think of a light switch icon (eg. with on/off labels). WDYT?

          Matthew Kruer added a comment -

          I got it, and its simple, use the GTK icon set, grab the grey pause icon for disabled, and the grey play icon for running. Pause and Play make more sense and are universally known.

          Matthew Kruer added a comment - I got it, and its simple, use the GTK icon set, grab the grey pause icon for disabled, and the grey play icon for running. Pause and Play make more sense and are universally known.

          Fred G added a comment -

          Sorry, went ahead with the switch icon for now. Pause and play could be misunderstood as an action to pause and continue a build instead of disabling/enabling it.
          I might change the switch icon in the future, depending on user feedback.

          Fred G added a comment - Sorry, went ahead with the switch icon for now. Pause and play could be misunderstood as an action to pause and continue a build instead of disabling/enabling it. I might change the switch icon in the future, depending on user feedback.

          Fred G added a comment -

          Implemented the minimum requirement (saving column width and visually improved button/icon).

          Fred G added a comment - Implemented the minimum requirement (saving column width and visually improved button/icon).

            mkruer Matthew Kruer
            mkruer Matthew Kruer
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: