• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Component/s: cvs-plugin
• Labels:

  • performance
• Environment:

  Jenkins 1.447 LTS

[JENKINS-16389] Emailing users at the end of a failed build very slow for big Jenkins instance using CVS

kutzi created issue - 2013-01-17 12:36

kutzi made changes - 2013-01-17 12:37

Component/s		New: cvs [ 15486 ]
Component/s	Original: subversion [ 15485 ]
Environment	Original: Jenkins 1.447 LTS Subversion 1.35 Although both Jenkins and subversion plugin are not latest version, I have browsed github for latest versions and I believe this issue to still be present.	New: Jenkins 1.447 LTS

kutzi made changes - 2013-01-17 12:37

Description

Original: At the end of a failing build, the hudson.tasks.MailSender.buildCulpritList determines who to email. The problem comes when hudson.scm.SubversionMailAddressResolverImpl.findMailAddressFor determines the email address of the user by finding all builds a user has committed to. This is done by iterating over every single Jenkins project (hudson.model.User.getProjects() first finds all projects and then uses AbstractProject.hasParticipant - which reads the changelog to see if the user participated). For a large system (we have tens of thousands of builds), this is not at all efficient. Unfortunately findMailAddressFor takes a user and not a project (as the obvious implementation would be to work out the email address from the commit). Also, the results aren't cached and so this is run for every user every time. I'm not sure if this can be resolved with just a fix to the subversion-plugin

New: At the end of a failing build, the hudson.tasks.MailSender.buildCulpritList determines who to email. The problem comes when hudson.scm.MailAddressResolverImpl.findMailAddressFor determines the email address of the user by finding all builds a user has committed to. This is done by iterating over every single Jenkins project (hudson.model.User.getProjects() first finds all projects and then uses AbstractProject.hasParticipant - which reads the changelog to see if the user participated). For a large system (we have tens of thousands of builds), this is not at all efficient. Unfortunately findMailAddressFor takes a user and not a project (as the obvious implementation would be to work out the email address from the commit). Also, the results aren't cached and so this is run for every user every time. I'm not sure if this can be resolved with just a fix to the subversion-plugin

kutzi made changes - 2013-01-17 12:38

Link

New: This issue is related to JENKINS-15440 [ JENKINS-15440 ]

kutzi made changes - 2013-01-17 12:39

Description

Original: At the end of a failing build, the hudson.tasks.MailSender.buildCulpritList determines who to email. The problem comes when hudson.scm.MailAddressResolverImpl.findMailAddressFor determines the email address of the user by finding all builds a user has committed to. This is done by iterating over every single Jenkins project (hudson.model.User.getProjects() first finds all projects and then uses AbstractProject.hasParticipant - which reads the changelog to see if the user participated). For a large system (we have tens of thousands of builds), this is not at all efficient. Unfortunately findMailAddressFor takes a user and not a project (as the obvious implementation would be to work out the email address from the commit). Also, the results aren't cached and so this is run for every user every time. I'm not sure if this can be resolved with just a fix to the subversion-plugin

New: Basically the same issue as JENKINS-15440, only for CVS. Description was mainly copied from there. At the end of a failing build, the hudson.tasks.MailSender.buildCulpritList determines who to email. The problem comes when hudson.scm.MailAddressResolverImpl.findMailAddressFor determines the email address of the user by finding all builds a user has committed to. This is done by iterating over every single Jenkins project (hudson.model.User.getProjects() first finds all projects and then uses AbstractProject.hasParticipant - which reads the changelog to see if the user participated). For a large system (we have tens of thousands of builds), this is not at all efficient. Unfortunately findMailAddressFor takes a user and not a project (as the obvious implementation would be to work out the email address from the commit). Also, the results aren't cached and so this is run for every user every time.

kutzi made changes - 2013-01-18 15:40

Assignee

Original: kutzi [ kutzi ]

Jesse Glick made changes - 2013-01-22 22:32

Link

New: This issue is blocking JENKINS-16437 [ JENKINS-16437 ]

Oliver Gondža made changes - 2013-01-31 16:00

Assignee

New: Oliver Gondža [ olivergondza ]

Oliver Gondža made changes - 2013-02-01 17:26

Resolution		New: Fixed [ 1 ]
Status	Original: Open [ 1 ]	New: Resolved [ 5 ]

kutzi made changes - 2013-02-18 11:30

Link

New: This issue is blocking JENKINS-16849 [ JENKINS-16849 ]

R. Tyler Croy made changes - 2016-07-25 23:55

Workflow

Original: JNJira [ 147207 ]

New: JNJira + In-Review [ 192281 ]