[JENKINS-16453] GitChangeSet.findOrCreateUser does not use correct method when checking for an email address - Jenkins Jira

XML

Word

Printable

When checking for an existing email address for a user the proper getAdress() method is not being used:

GitChangeSet.java, Line 274

if (fixEmpty(csAuthorEmail) != null && user.getProperty(Mailer.UserProperty.class)==null)

should look like:

if (fixEmpty(csAuthorEmail) != null && user.getProperty(Mailer.UserProperty.class).getAddress())

Matthias Richter created issue - 2013-01-23 12:07

Matthias Richter made changes - 2013-01-23 12:07

Field	Original Value	New Value
Description	When checking for an existing email address for a user the proper getAdress() method is not being used: {code:title=GitChangeSet.java, Line 274\|borderStyle=solid} if (fixEmpty(csAuthorEmail) != null && user.getProperty(Mailer.UserProperty.class)==null) {code} should look like: {code:java if (fixEmpty(csAuthorEmail) != null && user.getProperty(Mailer.UserProperty.class).getAddress()) {code}	When checking for an existing email address for a user the proper getAdress() method is not being used: {code:title=GitChangeSet.java, Line 274\|borderStyle=solid} if (fixEmpty(csAuthorEmail) != null && user.getProperty(Mailer.UserProperty.class)==null) {code} should look like: {code:java} if (fixEmpty(csAuthorEmail) != null && user.getProperty(Mailer.UserProperty.class).getAddress()) {code}

Matthias Richter made changes - 2013-02-04 09:17

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

R. Tyler Croy made changes - 2016-07-25 23:55

Workflow

JNJira [ 147275 ]

JNJira + In-Review [ 192313 ]

Mark Waite made changes - 2019-10-23 01:28

Status

Resolved [ 5 ]

Closed [ 6 ]