[JENKINS-16502] Permission to see an agent

Type: New Feature
Resolution: Unresolved
Priority: Minor
Component/s: core
Labels:

Similar Issues:
Powered by SuggestiMate

Show

In our environment it would be very helpful to be able to set Permissions, who can see specific agent.

It should be like with jobs/projects, where the method "hasPermission()" is called, before you get all Items of the jenkins-instance.

So it would be just needed in the Computer.java a new attribute "Permission VIEW", and in the Jenkins.java in the Method "getComputer()" the check, if the user has the Permission to see this agent.

depends on

JENKINS-17200 SCM.TAG permission not eagerly loaded

Open

is blocking

JENKINS-5517 Jenkins to hide agent names for anonymous users

Open

is duplicated by

JENKINS-65523 Node based security is displaying the Node without hiding it for people who doesnt have access to them

Closed

is related to

JENKINS-22760 Request for new slave-specific permission in Jenkins core

Open

relates to

JENKINS-15484 New permission controlling ability to configure your own User

Open

links to

CloudBees Internal OSS-55

(1 links to)

Christian Meyer created issue - 2013-01-28 09:35

SCM/JIRA link daemon added a comment - 2013-09-24 11:30

Code changed in jenkins
User: Stephen Connolly
Path:
changelog.html
core/src/main/java/hudson/model/Computer.java
core/src/main/java/jenkins/model/Jenkins.java
core/src/main/resources/hudson/model/Computer/builds.jelly
core/src/main/resources/hudson/model/Computer/delete.jelly
core/src/main/resources/hudson/model/Computer/index.jelly
core/src/main/resources/hudson/model/Computer/load-statistics.jelly
core/src/main/resources/hudson/model/Computer/markOffline.jelly
core/src/main/resources/hudson/model/Computer/setOfflineCause.jelly
core/src/main/resources/hudson/model/Messages.properties
http://jenkins-ci.org/commit/jenkins/647695e2ffc2f568ca1b80bc5b0cd7b0658eeb3d
Log:
JENKINS-16502 Permission to see an executor/slave

This is an initial version of the feature.
The information about slave names is still exposed via label autocomplete

SCM/JIRA link daemon added a comment - 2013-09-24 11:30 Code changed in jenkins User: Stephen Connolly Path: changelog.html core/src/main/java/hudson/model/Computer.java core/src/main/java/jenkins/model/Jenkins.java core/src/main/resources/hudson/model/Computer/builds.jelly core/src/main/resources/hudson/model/Computer/delete.jelly core/src/main/resources/hudson/model/Computer/index.jelly core/src/main/resources/hudson/model/Computer/load-statistics.jelly core/src/main/resources/hudson/model/Computer/markOffline.jelly core/src/main/resources/hudson/model/Computer/setOfflineCause.jelly core/src/main/resources/hudson/model/Messages.properties http://jenkins-ci.org/commit/jenkins/647695e2ffc2f568ca1b80bc5b0cd7b0658eeb3d Log: JENKINS-16502 Permission to see an executor/slave This is an initial version of the feature. The information about slave names is still exposed via label autocomplete

SCM/JIRA link daemon added a comment - 2013-09-24 11:30

Code changed in jenkins
User: Stephen Connolly
Path:
changelog.html
core/src/main/java/hudson/model/Computer.java
core/src/main/java/jenkins/model/Jenkins.java
core/src/main/resources/hudson/model/Computer/builds.jelly
core/src/main/resources/hudson/model/Computer/delete.jelly
core/src/main/resources/hudson/model/Computer/index.jelly
core/src/main/resources/hudson/model/Computer/load-statistics.jelly
core/src/main/resources/hudson/model/Computer/markOffline.jelly
core/src/main/resources/hudson/model/Computer/setOfflineCause.jelly
core/src/main/resources/hudson/model/Messages.properties
http://jenkins-ci.org/commit/jenkins/903ef107d3b279c2cffce99b4d61734fba286ef0
Log:
Merge pull request #951 from stephenc/master

JENKINS-16502 Permission to see an executor/slave

Compare: https://github.com/jenkinsci/jenkins/compare/84a176beefd2...903ef107d3b2

SCM/JIRA link daemon added a comment - 2013-09-24 11:30 Code changed in jenkins User: Stephen Connolly Path: changelog.html core/src/main/java/hudson/model/Computer.java core/src/main/java/jenkins/model/Jenkins.java core/src/main/resources/hudson/model/Computer/builds.jelly core/src/main/resources/hudson/model/Computer/delete.jelly core/src/main/resources/hudson/model/Computer/index.jelly core/src/main/resources/hudson/model/Computer/load-statistics.jelly core/src/main/resources/hudson/model/Computer/markOffline.jelly core/src/main/resources/hudson/model/Computer/setOfflineCause.jelly core/src/main/resources/hudson/model/Messages.properties http://jenkins-ci.org/commit/jenkins/903ef107d3b279c2cffce99b4d61734fba286ef0 Log: Merge pull request #951 from stephenc/master JENKINS-16502 Permission to see an executor/slave Compare: https://github.com/jenkinsci/jenkins/compare/84a176beefd2...903ef107d3b2

Stephen Connolly added a comment - 2013-09-24 11:32

towards Jenkins 1.533

Stephen Connolly added a comment - 2013-09-24 11:32 towards Jenkins 1.533

Stephen Connolly made changes - 2013-09-24 11:32

Resolution		New: Fixed [ 1 ]
Status	Original: Open [ 1 ]	New: Resolved [ 5 ]

dogfood added a comment - 2013-09-24 12:53

Integrated in jenkins_main_trunk #2890
JENKINS-16502 Permission to see an executor/slave (Revision 647695e2ffc2f568ca1b80bc5b0cd7b0658eeb3d)

Result = UNSTABLE
Stephen Connolly : 647695e2ffc2f568ca1b80bc5b0cd7b0658eeb3d
Files :

changelog.html
core/src/main/resources/hudson/model/Computer/builds.jelly
core/src/main/java/hudson/model/Computer.java
core/src/main/resources/hudson/model/Computer/setOfflineCause.jelly
core/src/main/resources/hudson/model/Computer/delete.jelly
core/src/main/resources/hudson/model/Computer/load-statistics.jelly
core/src/main/resources/hudson/model/Messages.properties
core/src/main/resources/hudson/model/Computer/index.jelly
core/src/main/resources/hudson/model/Computer/markOffline.jelly
core/src/main/java/jenkins/model/Jenkins.java

dogfood added a comment - 2013-09-24 12:53 Integrated in jenkins_main_trunk #2890 JENKINS-16502 Permission to see an executor/slave (Revision 647695e2ffc2f568ca1b80bc5b0cd7b0658eeb3d) Result = UNSTABLE Stephen Connolly : 647695e2ffc2f568ca1b80bc5b0cd7b0658eeb3d Files : changelog.html core/src/main/resources/hudson/model/Computer/builds.jelly core/src/main/java/hudson/model/Computer.java core/src/main/resources/hudson/model/Computer/setOfflineCause.jelly core/src/main/resources/hudson/model/Computer/delete.jelly core/src/main/resources/hudson/model/Computer/load-statistics.jelly core/src/main/resources/hudson/model/Messages.properties core/src/main/resources/hudson/model/Computer/index.jelly core/src/main/resources/hudson/model/Computer/markOffline.jelly core/src/main/java/jenkins/model/Jenkins.java

SCM/JIRA link daemon added a comment - 2013-09-27 05:26

Code changed in jenkins
User: Jesse Glick
Path:
changelog.html
core/src/main/java/hudson/model/Computer.java
core/src/main/java/jenkins/model/Jenkins.java
core/src/main/resources/hudson/model/Computer/builds.jelly
core/src/main/resources/hudson/model/Computer/delete.jelly
core/src/main/resources/hudson/model/Computer/index.jelly
core/src/main/resources/hudson/model/Computer/load-statistics.jelly
core/src/main/resources/hudson/model/Computer/markOffline.jelly
core/src/main/resources/hudson/model/Computer/setOfflineCause.jelly
core/src/main/resources/hudson/model/Messages.properties
http://jenkins-ci.org/commit/jenkins/3911ea2c1450e73fabaf51acc1b635a44a5257c6
Log:
Revert "JENKINS-16502 Permission to see an executor/slave"

This reverts commit 647695e2ffc2f568ca1b80bc5b0cd7b0658eeb3d.

SCM/JIRA link daemon added a comment - 2013-09-27 05:26 Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/model/Computer.java core/src/main/java/jenkins/model/Jenkins.java core/src/main/resources/hudson/model/Computer/builds.jelly core/src/main/resources/hudson/model/Computer/delete.jelly core/src/main/resources/hudson/model/Computer/index.jelly core/src/main/resources/hudson/model/Computer/load-statistics.jelly core/src/main/resources/hudson/model/Computer/markOffline.jelly core/src/main/resources/hudson/model/Computer/setOfflineCause.jelly core/src/main/resources/hudson/model/Messages.properties http://jenkins-ci.org/commit/jenkins/3911ea2c1450e73fabaf51acc1b635a44a5257c6 Log: Revert " JENKINS-16502 Permission to see an executor/slave" This reverts commit 647695e2ffc2f568ca1b80bc5b0cd7b0658eeb3d.

SCM/JIRA link daemon added a comment - 2013-09-27 05:27

Code changed in jenkins
User: Jesse Glick
Path:
changelog.html
core/src/main/java/hudson/model/Computer.java
core/src/main/java/jenkins/model/Jenkins.java
core/src/main/resources/hudson/model/Computer/builds.jelly
core/src/main/resources/hudson/model/Computer/delete.jelly
core/src/main/resources/hudson/model/Computer/index.jelly
core/src/main/resources/hudson/model/Computer/load-statistics.jelly
core/src/main/resources/hudson/model/Computer/markOffline.jelly
core/src/main/resources/hudson/model/Computer/setOfflineCause.jelly
core/src/main/resources/hudson/model/Messages.properties
http://jenkins-ci.org/commit/jenkins/0ebd8a6c3dedd8ff06a08af175571c6bc49893d9
Log:
Revert "JENKINS-16502 Permission to see an executor/slave"

This reverts commit 647695e2ffc2f568ca1b80bc5b0cd7b0658eeb3d.

SCM/JIRA link daemon added a comment - 2013-09-27 05:27 Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/model/Computer.java core/src/main/java/jenkins/model/Jenkins.java core/src/main/resources/hudson/model/Computer/builds.jelly core/src/main/resources/hudson/model/Computer/delete.jelly core/src/main/resources/hudson/model/Computer/index.jelly core/src/main/resources/hudson/model/Computer/load-statistics.jelly core/src/main/resources/hudson/model/Computer/markOffline.jelly core/src/main/resources/hudson/model/Computer/setOfflineCause.jelly core/src/main/resources/hudson/model/Messages.properties http://jenkins-ci.org/commit/jenkins/0ebd8a6c3dedd8ff06a08af175571c6bc49893d9 Log: Revert " JENKINS-16502 Permission to see an executor/slave" This reverts commit 647695e2ffc2f568ca1b80bc5b0cd7b0658eeb3d.

Jesse Glick added a comment - 2013-09-27 05:29

Reverted since this caused test failures, and these failures in fact seem legitimate: old installations would not have granted the new permission to non-admins, so computers would be hidden by default. Need to do tricks to conditionally enable this permission.

Jesse Glick added a comment - 2013-09-27 05:29 Reverted since this caused test failures, and these failures in fact seem legitimate: old installations would not have granted the new permission to non-admins, so computers would be hidden by default. Need to do tricks to conditionally enable this permission.

Jesse Glick made changes - 2013-09-27 05:29

Assignee	Original: Christian Meyer [ chrissy ]	New: Stephen Connolly [ stephenconnolly ]
Resolution	Original: Fixed [ 1 ]
Status	Original: Resolved [ 5 ]	New: Reopened [ 4 ]

Assignee:: Unassigned

Reporter:: Christian Meyer

Votes:: 7 Vote for this issue

Watchers:: 13 Start watching this issue

Created:: 2013-01-28 09:35

Updated:: 2024-06-11 18:04

Jenkins

Details

Description

Attachments

Issue Links

Activity

Collapse comment: SCM/JIRA link daemon added a comment - 2013-09-24 11:30

Expand comment: SCM/JIRA link daemon added a comment - 2013-09-24 11:30

Collapse comment: SCM/JIRA link daemon added a comment - 2013-09-24 11:30

Expand comment: SCM/JIRA link daemon added a comment - 2013-09-24 11:30

Collapse comment: Stephen Connolly added a comment - 2013-09-24 11:32

Expand comment: Stephen Connolly added a comment - 2013-09-24 11:32

Collapse comment: dogfood added a comment - 2013-09-24 12:53

Expand comment: dogfood added a comment - 2013-09-24 12:53

Collapse comment: SCM/JIRA link daemon added a comment - 2013-09-27 05:26

Expand comment: SCM/JIRA link daemon added a comment - 2013-09-27 05:26

Collapse comment: SCM/JIRA link daemon added a comment - 2013-09-27 05:27

Expand comment: SCM/JIRA link daemon added a comment - 2013-09-27 05:27

Collapse comment: Jesse Glick added a comment - 2013-09-27 05:29

Expand comment: Jesse Glick added a comment - 2013-09-27 05:29

People

Dates