Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-16561

Jelly form control f:validateButton giving a warning popup in IE irrespective of whether validation is successfull

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved (View Workflow)
    • Blocker
    • Resolution: Fixed
    • core
    • Windows 2008 R2 64 bit , Internet Explorer (8 and 9)

    Description

      Getting warning message in a popup saying "Failed to evaluate. Invalid arguments" for jelly form control validateButton. I am getting this pop up irrespective of actual result of validation.

      This is happening only in Internet Explorer(8 and 9). This is not getting reproduced when running jenkins using "mvn hpi:run" but
      getting reproduced when running jenkins using command "java -jar jenkins.war" and then manually importing hpi file from advanced tab.

      For complete details , refer to discussion in
      https://groups.google.com/forum/#!topic/jenkinsci-dev/h4vlO8SkA60

      Sample to reproduce this issue is available in my github
      https://github.com/sureshreddygithub/jenkinssamples.git

      or alternatively you can install https://wiki.jenkins-ci.org/display/JENKINS/SCTMExecutor plugin and try to validate in global configuration in IE.

      Root cause:

      For validate button form control , implementation is available @ scripts/hudson-behavior.js

      In validate function , we are using a custom function geval which is causing the issue.

      If i replace geval with eval i see that everything works as expected in IE as well.

      I will be submitting the fix in git shortly

      Attachments

        Issue Links

          Activity

            snallami suresh nallamilli created issue -
            snallami suresh nallamilli made changes -
            Field Original Value New Value
            Status Open [ 1 ] In Progress [ 3 ]
            snallami suresh nallamilli made changes -
            Status In Progress [ 3 ] Open [ 1 ]
            snallami suresh nallamilli made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            snallami suresh nallamilli made changes -
            Status In Progress [ 3 ] Open [ 1 ]
            jglick Jesse Glick made changes -
            Link This issue is blocking JENKINS-15617 [ JENKINS-15617 ]
            scm_issue_link SCM/JIRA link daemon made changes -
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Resolved [ 5 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 147384 ] JNJira + In-Review [ 192373 ]

            People

              snallami suresh nallamilli
              snallami suresh nallamilli
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: