Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-16778

Timestamper makes the build fail if the slave if put offline during the build.

    XMLWordPrintable

Details

    Description

      If a slave is put offline during a running build, the timestamper plugin issues a NPE at the end of the build, marking the build as failed.

      The stacktrace is the following

      17:11:18 Looks like the node went offline during the build. Check the slave log for the details.FATAL: null
      17:11:18 java.lang.NullPointerException
      17:11:18 at hudson.plugins.timestamper.TimestampFormatter.<init>(TimestampFormatter.java:71)
      17:11:20 at hudson.plugins.timestamper.TimestamperConfig$1.get(TimestamperConfig.java:59)
      17:11:20 at hudson.plugins.timestamper.TimestamperConfig$1.get(TimestamperConfig.java:54)
      17:11:20 at hudson.plugins.timestamper.TimestamperConfig.formatter(TimestamperConfig.java:148)
      17:11:20 at hudson.plugins.timestamper.annotator.TimestampAnnotatorFactory.newInstance(TimestampAnnotatorFactory.java:51)
      17:11:20 at hudson.console.ConsoleAnnotator._for(ConsoleAnnotator.java:143)
      17:11:20 at hudson.console.ConsoleAnnotator.initial(ConsoleAnnotator.java:133)
      17:11:20 at hudson.console.AnnotatedLargeText.createAnnotator(AnnotatedLargeText.java:138)
      17:11:20 at hudson.console.AnnotatedLargeText.writeHtmlTo(AnnotatedLargeText.java:155)
      17:11:20 at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:605)
      17:11:20 at hudson.model.Run.execute(Run.java:1543)
      17:11:20 at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46)
      17:11:20 at hudson.model.ResourceController.execute(ResourceController.java:88)
      17:11:20 at hudson.model.Executor.run(Executor.java:236)

      Attachments

        Issue Links

          Activity

            Steven, Joris, (or anyone with permissions - not sure where to see a list of people),

            Will you please publish a 1.5.4 with this latest fix?

            Thanks,
            Andy

            aje Andrew Erickson added a comment - Steven, Joris, (or anyone with permissions - not sure where to see a list of people), Will you please publish a 1.5.4 with this latest fix? Thanks, Andy

            Seconded.

            We're not that keen on using a self-compiled version, either. It should be a measure of last resort, after all.

            Plus, it always raises inquisitive questions by users when your productive server contains a "-SNAPSHOT" plugin.

            Best regards,
            Martin.

            mhschroe Martin Schröder added a comment - Seconded. We're not that keen on using a self-compiled version, either. It should be a measure of last resort, after all. Plus, it always raises inquisitive questions by users when your productive server contains a "-SNAPSHOT" plugin. Best regards, Martin.

            Back from holiday. Released Timestamper 1.5.4 with this fix.

            stevengbrown Steven G Brown added a comment - Back from holiday. Released Timestamper 1.5.4 with this fix.
            marc_guenther Marc Günther added a comment -

            Thanks Steven. I just tested thsis, and it works now. I still get a "Looks like the slave went offline..." message in the Console, but no more exception and it doesn't fail the build.

            marc_guenther Marc Günther added a comment - Thanks Steven. I just tested thsis, and it works now. I still get a "Looks like the slave went offline..." message in the Console, but no more exception and it doesn't fail the build.

            Great. Thanks everyone.

            stevengbrown Steven G Brown added a comment - Great. Thanks everyone.

            People

              stevengbrown Steven G Brown
              vlatombe Vincent Latombe
              Votes:
              2 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: