Code changed in jenkins
User: StevenGBrown
Path:
src/main/java/hudson/plugins/timestamper/TimestampFormatter.java
src/test/java/hudson/plugins/timestamper/TimestampFormatterTest.java
http://jenkins-ci.org/commit/timestamper-plugin/4029ac433521b354014aeb730509acd9e61e10e6
Log:
[FIXED JENKINS-16778] Allow for a null stapler request

–
You received this message because you are subscribed to the Google Groups "Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Fix included in Timestamper 1.5.3 release.

Code changed in jenkins
User: StevenGBrown
Path:
src/main/java/hudson/plugins/timestamper/annotator/TimestampAnnotatorFactory.java
http://jenkins-ci.org/commit/timestamper-plugin/8317afcb23693e91b21e2330577dcba2db2d1058
Log:
Merge pull request #3 from jdewinne/master

JENKINS-16778: Timestamper makes the build fail if the slave is put offline during the build.

Compare: https://github.com/jenkinsci/timestamper-plugin/compare/09ec70200054...8317afcb2369

I can definitely confirm what Joris stated.

The bug is still not fixed. If you mark a node as temporarily offline while a build is running, the Timestamper plugin will still throw an NPE:
---------------------------------------------
10:16:03 Looks like the node went offline during the build. Check the slave log for the details.FATAL: null
10:16:03 java.lang.NullPointerException
10:16:03 at hudson.plugins.timestamper.annotator.TimestampAnnotatorFactory.getOffset(TimestampAnnotatorFactory.java:65)
10:16:03 at hudson.plugins.timestamper.annotator.TimestampAnnotatorFactory.newInstance(TimestampAnnotatorFactory.java:52)
10:16:03 at hudson.console.ConsoleAnnotator._for(ConsoleAnnotator.java:143)
10:16:03 at hudson.console.ConsoleAnnotator.initial(ConsoleAnnotator.java:133)
10:16:03 at hudson.console.AnnotatedLargeText.createAnnotator(AnnotatedLargeText.java:140)
10:16:03 at hudson.console.AnnotatedLargeText.writeHtmlTo(AnnotatedLargeText.java:157)
10:16:03 at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:605)
10:16:03 at hudson.model.Run.execute(Run.java:1568)
[...]
---------------------------------------------

One thing to note is that this happens right in the middle of a build-step in our case. It will cause whatever is currently running to abort.

I hope this can help you track down the issue.

Martin,

I've implemented a fix for this. So this will be fixed with the next release of the plugin. If you want you can checkout the code and use the latest version from github.

Regards,
Joris

Steven, Joris, (or anyone with permissions - not sure where to see a list of people),

Will you please publish a 1.5.4 with this latest fix?

Thanks,
Andy

Seconded.

We're not that keen on using a self-compiled version, either. It should be a measure of last resort, after all.

Plus, it always raises inquisitive questions by users when your productive server contains a "-SNAPSHOT" plugin.

Best regards,
Martin.

Back from holiday. Released Timestamper 1.5.4 with this fix.

Thanks Steven. I just tested thsis, and it works now. I still get a "Looks like the slave went offline..." message in the Console, but no more exception and it doesn't fail the build.

Great. Thanks everyone.